Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1292201 > unrolled thread

Re: [PATCH v4 2/2] drm: panel: simple: add QiaoDian qd43003c0-40

Started byNicolas Ferre <nicolas.ferre@atmel.com>
First post2015-12-15 14:50 +0100
Last post2015-12-16 21:30 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v4 2/2] drm: panel: simple: add QiaoDian qd43003c0-40 Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-12-15 14:50 +0100
    Re: [PATCH v4 2/2] drm: panel: simple: add QiaoDian qd43003c0-40 Thierry Reding <thierry.reding@gmail.com> - 2015-12-16 18:20 +0100
      Re: [PATCH v4 2/2] drm: panel: simple: add QiaoDian qd43003c0-40 Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-12-16 21:30 +0100

#1292201 — Re: [PATCH v4 2/2] drm: panel: simple: add QiaoDian qd43003c0-40

FromNicolas Ferre <nicolas.ferre@atmel.com>
Date2015-12-15 14:50 +0100
SubjectRe: [PATCH v4 2/2] drm: panel: simple: add QiaoDian qd43003c0-40
Message-ID<qFY9l-4Mo-31@gated-at.bofh.it>
Le 02/12/2015 23:03, Alexandre Belloni a écrit :
> From: Josh Wu <josh.wu@atmel.com>
> 
> The QiaoDian Xianshi QD43003C0-40 is a 4"3 TFT LCD panel.
> 
> Timings from the OTA5180A document, ver 0.9, section
> 10.1.1:
>   http://www.orientdisplay.com/pdf/OTA5180A.pdf
> 
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Acked-by: Rob Herring <robh@kernel.org>

If it can speed-up things:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thierry, it seems that this patch keeps on sitting aside for quite some
time, and Alexandre only rebased it lately so it can be easier to take
(so this v4).

Can we see this trivial patch move forward so that we can at least see
it appearing in linux-next and use our screen with Mainline?

Bye,

> ---
> Changes in v4:
>  - rebased on v4.4-rc1
> 
>  .../display/panel/qiaodian,qd43003c0-40.txt        |  7 ++++++
>  drivers/gpu/drm/panel/panel-simple.c               | 27 ++++++++++++++++++++++
>  2 files changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/qiaodian,qd43003c0-40.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/qiaodian,qd43003c0-40.txt b/Documentation/devicetree/bindings/display/panel/qiaodian,qd43003c0-40.txt
> new file mode 100644
> index 000000000000..0fbdab89ac3d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/qiaodian,qd43003c0-40.txt
> @@ -0,0 +1,7 @@
> +QiaoDian XianShi Corporation 4"3 TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "qiaodian,qd43003c0-40"
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index f97b73ec4713..c93ffa615005 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1027,6 +1027,30 @@ static const struct panel_desc ortustech_com43h4m85ulc = {
>  	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>  };
>  
> +static const struct drm_display_mode qd43003c0_40_mode = {
> +	.clock = 9000,
> +	.hdisplay = 480,
> +	.hsync_start = 480 + 8,
> +	.hsync_end = 480 + 8 + 4,
> +	.htotal = 480 + 8 + 4 + 39,
> +	.vdisplay = 272,
> +	.vsync_start = 272 + 4,
> +	.vsync_end = 272 + 4 + 10,
> +	.vtotal = 272 + 4 + 10 + 2,
> +	.vrefresh = 60,
> +};
> +
> +static const struct panel_desc qd43003c0_40 = {
> +	.modes = &qd43003c0_40_mode,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 95,
> +		.height = 53,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +};
> +
>  static const struct drm_display_mode samsung_ltn101nt05_mode = {
>  	.clock = 54030,
>  	.hdisplay = 1024,
> @@ -1182,6 +1206,9 @@ static const struct of_device_id platform_of_match[] = {
>  		.compatible = "ortustech,com43h4m85ulc",
>  		.data = &ortustech_com43h4m85ulc,
>  	}, {
> +		.compatible = "qiaodian,qd43003c0-40",
> +		.data = &qd43003c0_40,
> +	}, {
>  		.compatible = "samsung,ltn101nt05",
>  		.data = &samsung_ltn101nt05,
>  	}, {
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1293135

FromThierry Reding <thierry.reding@gmail.com>
Date2015-12-16 18:20 +0100
Message-ID<qGnU5-4Ey-3@gated-at.bofh.it>
In reply to#1292201

[Multipart message — attachments visible in raw view] — view raw

On Tue, Dec 15, 2015 at 02:43:47PM +0100, Nicolas Ferre wrote:
> Le 02/12/2015 23:03, Alexandre Belloni a écrit :
> > From: Josh Wu <josh.wu@atmel.com>
> > 
> > The QiaoDian Xianshi QD43003C0-40 is a 4"3 TFT LCD panel.
> > 
> > Timings from the OTA5180A document, ver 0.9, section
> > 10.1.1:
> >   http://www.orientdisplay.com/pdf/OTA5180A.pdf
> > 
> > Signed-off-by: Josh Wu <josh.wu@atmel.com>
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> 
> If it can speed-up things:
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> 
> Thierry, it seems that this patch keeps on sitting aside for quite some
> time, and Alexandre only rebased it lately so it can be easier to take
> (so this v4).
> 
> Can we see this trivial patch move forward so that we can at least see
> it appearing in linux-next and use our screen with Mainline?

Please make sure to Cc: dri-devel@lists.freedesktop.org on patches that
apply under drivers/gpu/drm to make sure that patchwork picks them up. I
recommend also sending the corresponding vendor prefix patches to that
list, which makes it a whole lot easier to track.

Also, please use "drm/panel: " as the prefix (instead of "drm: panel: ")
to make it easier for me to pick up things. I was about to send out a
pull request for drm/panel when I noticed that there was this patch. The
v4 wasn't Cc: dri-devel, so I ended up applying v3 from patchwork. From
the changelog it seems like that's okay, though.

Thierry

[toc] | [prev] | [next] | [standalone]


#1293339

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2015-12-16 21:30 +0100
Message-ID<qGqRZ-6vM-15@gated-at.bofh.it>
In reply to#1293135
Hi,

On 16/12/2015 at 18:14:06 +0100, Thierry Reding wrote :
> Also, please use "drm/panel: " as the prefix (instead of "drm: panel: ")
> to make it easier for me to pick up things. I was about to send out a
> pull request for drm/panel when I noticed that there was this patch. The
> v4 wasn't Cc: dri-devel, so I ended up applying v3 from patchwork. From
> the changelog it seems like that's okay, though.
> 

I think v3 didn't have the documentation at the correct place, this
should be:
Documentation/devicetree/bindings/display/panel/qiaodian,qd43003c0-40.txt



-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web