Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1290991 > unrolled thread
| Started by | MyungJoo Ham <myungjoo.ham@samsung.com> |
|---|---|
| First post | 2015-12-14 10:10 +0100 |
| Last post | 2015-12-18 02:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
Re: [PATCH v4 05/20] PM / devfreq: Add new passive governor MyungJoo Ham <myungjoo.ham@samsung.com> - 2015-12-14 10:10 +0100
Re: [PATCH v4 05/20] PM / devfreq: Add new passive governor Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-18 02:30 +0100
| From | MyungJoo Ham <myungjoo.ham@samsung.com> |
|---|---|
| Date | 2015-12-14 10:10 +0100 |
| Subject | Re: [PATCH v4 05/20] PM / devfreq: Add new passive governor |
| Message-ID | <qFxiN-43P-13@gated-at.bofh.it> |
PiAgIA0KPiAgVGhpcyBwYXRjaCBhZGRzIHRoZSBuZXcgcGFzc2l2ZSBnb3Zlcm5vciBmb3IgREVW RlJFUSBmcmFtZXdvcmsuIFRoZSBmb2xsb3dpbmcNCj4gZ292ZXJub3JzIGFyZSBhbHJlYWR5IHBy ZXNlbnQgYW5kIHVzZWQgZm9yIERWRlMgKER5bmFtaWMgVm9sdGFnZSBhbmQgRnJlcXVlbmN5DQo+ IFNjYWxpbmcpIGRyaXZlcnMuIFRoZSBmb2xsb3dpbmcgZ292ZXJub3JzIGFyZSBpbmRlcGVuZGVu dGx5IHVzZWQgZm9yIG9uZSBkZXZpY2UNCj4gZHJpdmVyIHdoaWNoIGRvbid0IGdpdmUgdGhlIGlu Zmx1ZW5jZSB0byBvdGhlciBkZXZpY2UgZHJ2aWVycyBhbmQgYWxzbyBkb24ndA0KPiByZWNlaXZl IHRoZSBlZmZlY3QgZnJvbSBvdGhlciBkZXZpY2UgZHJpdmVycy4NCj4gLSBvbmRlbWFuZCAvIHBl cmZvcm1hbmNlIC8gcG93ZXJzYXZlIC8gdXNlcnNwYWNlDQo+IA0KPiBUaGUgcGFzc2l2ZSBnb3Zl cm5vciBkZXBlbmRzIG9uIG9wZXJhdGlvbiBvZiBwYXJlbnQgZHJpdmVyIHdpdGggc3BlY2lmaWMN Cj4gZ292ZXJub3MgZXh0cmVtZWx5IGFuZCBpcyBub3QgYWJsZSB0byBkZWNpZGUgdGhlIG5ldyBm cmVxdWVuY3kgYnkgb25lc2VsZi4NCj4gQWNjb3JkaW5nIHRvIHRoZSBkZWNpZGVkIG5ldyBmcmVx dWVuY3kgb2YgcGFyZW50IGRyaXZlciB3aXRoIGdvdmVybm9yLA0KPiB0aGUgcGFzc2l2ZSBnb3Zl cm5vciB1c2VzIGl0IHRvIGRlY2lkZSB0aGUgYXBwcm9wcmlhdGUgZnJlcXVlbmN5IGZvciBvd24N Cj4gZGV2aWNlIGRyaXZlci4gVGhlIHBhc3NpdmUgZ292ZXJub3IgbXVzdCBuZWVkIHRoZSBmb2xs b3dpbmcgaW5mb3JtYXRpb24NCj4gZnJvbSBkZXZpY2UgdHJlZToNCj4gLSB0aGUgc291cmNlIGNs b2NrIGFuZCBPUFAgdGFibGVzDQo+IC0gdGhlIGluc3RhbmNlIG9mIHBhcmVudCBkZXZpY2UNCj4g DQo+IEZvciBleGFtZXBsZSwNCj4gdGhlcmUgYXJlIG9uZSBtb3JlIGRldmZyZXEgZGV2aWNlIGRy aXZlcnMgd2hpY2ggbmVlZCB0byBjaGFuZ2UgdGhlaXIgc291cmNlDQo+IGNsb2NrIGFjY29yZGlu ZyB0byB0aGVpciB1dGlsaXphdGlvbiBvbiBydW50aW1lLiBCdXQsIHRoZXkgc2hhcmUgdGhlIHNh bWUNCj4gcG93ZXIgbGluZSAoZS5nLiwgcmVndWxhdG9yKS4gU28sIHNwZWNpZmljIGRldmljZSBk cml2ZXIgaXMgb3BlcmF0ZWQgYXMgcGFyZW50DQo+IHdpdGggb25kZW1hbmQgZ292ZXJub3IgYW5k IHRoZW4gdGhlIHJlc3QgZGV2aWNlIGRyaXZlciB3aXRoIHBhc3NpdmUgZ292ZXJub3INCj4gaXMg aW5mbHVlbmNlZCBieSBwYXJlbnQgZGV2aWNlLg0KPiANCj4gU3VnZ2VzdGVkLWJ5OiBNeXVuZ2pv byBIYW0gPG15dW5nam9vLmhhbUBzYW1zdW5nLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogQ2hhbndv byBDaG9pIDxjdzAwLmNob2lAc2Ftc3VuZy5jb20+DQo+IFtsaW51eC5hbW9vbjogVGVzdGVkIG9u IE9kcm9pZCBVM10NCj4gVGVzdGVkLWJ5OiBBbmFuZCBNb29uIDxsaW51eC5hbW9vbkBnbWFpbC5j b20+DQo+IC0tLQ0KPiAgZHJpdmVycy9kZXZmcmVxL0tjb25maWcgICAgICAgICAgICB8ICAgOSAr KysrDQo+ICBkcml2ZXJzL2RldmZyZXEvTWFrZWZpbGUgICAgICAgICAgIHwgICAxICsNCj4gIGRy aXZlcnMvZGV2ZnJlcS9kZXZmcmVxLmMgICAgICAgICAgfCAgNDcgKysrKysrKysrKysrKysrKw0K PiAgZHJpdmVycy9kZXZmcmVxL2dvdmVybm9yX3Bhc3NpdmUuYyB8IDEwOCArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrDQo+ICBpbmNsdWRlL2xpbnV4L2RldmZyZXEuaCAgICAg ICAgICAgIHwgIDE1ICsrKysrKw0KPiAgNSBmaWxlcyBjaGFuZ2VkLCAxODAgaW5zZXJ0aW9ucygr KQ0KPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZGV2ZnJlcS9nb3Zlcm5vcl9wYXNzaXZl LmMNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2RldmZyZXEvS2NvbmZpZyBiL2RyaXZlcnMv ZGV2ZnJlcS9LY29uZmlnDQo+IGluZGV4IDU1ZWM3NzRmNzk0Yy4uZDAzZjYzNWE5M2UxIDEwMDY0 NA0KPiAtLS0gYS9kcml2ZXJzL2RldmZyZXEvS2NvbmZpZw0KPiArKysgYi9kcml2ZXJzL2RldmZy ZXEvS2NvbmZpZw0KPiBAQCAtNjQsNiArNjQsMTUgQEAgY29uZmlnIERFVkZSRVFfR09WX1VTRVJT UEFDRQ0KPiAgCSAgT3RoZXJ3aXNlLCB0aGUgZ292ZXJub3IgZG9lcyBub3QgY2hhbmdlIHRoZSBm cmVxdW5lY3kNCj4gIAkgIGdpdmVuIGF0IHRoZSBpbml0aWFsaXphdGlvbi4NCj4gIA0KPiArY29u ZmlnIERFVkZSRVFfR09WX1BBU1NJVkUNCj4gKwl0cmlzdGF0ZSAiUGFzc2l2ZSINCj4gKwloZWxw DQo+ICsJICBTZXRzIHRoZSBmcmVxdWVuY3kgYnkgb3RoZXIgZ292ZXJub3JzIChzaW1wbGVfb25k ZW1hbmQsIHBlcmZvcm1hbmNlLA0KPiArCSAgcG93ZXJzYXZlLCB1c2Vyc2FwY2UpIG9mIGEgcGFy ZW50IGRldmZyZXEgZGV2aWNlLiBUaGlzIGdvdmVybm9yDQo+ICsJICBhbHdheXMgaGFzIHRoZSBk ZXBlbmRlbmN5IG9uIHRoZSBjaG9zZW4gZnJlcXVlbmN5IGZyb20gcGFpcmVkDQo+ICsJICBnb3Zl cm5vci4gVGhpcyBnb3Zlcm5vciBkb2VzIG5vdCBjaGFuZ2UgdGhlIGZyZXF1ZW5jeSBieSBvbmVz ZWxmDQo+ICsJICB0aHJvdWdoIHN5c2ZzIGVudHJ5Lg0KDQoJU2V0cyB0aGUgZnJlcXVlbmN5IGJh c2VkIG9uIHRoZSBmcmVxdWVuY3kgb2YgaXRzIHBhcmVudCBkZXZmcmVxDQoJZGV2aWNlLiBUaGlz IGdvdmVybm9yIGRvZXMgbm90IGNoYW5nZSB0aGUgZnJlcXVlbmN5IGJ5IGl0c2VsZg0KCXRocm91 Z2ggc3lzZnMgZW50cmllcy4NCg0KPiArDQo+ICBjb21tZW50ICJERVZGUkVRIERyaXZlcnMiDQo+ ICANCj4gIGNvbmZpZyBBUk1fRVhZTk9TX0JVU19ERVZGUkVRDQo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2RldmZyZXEvTWFrZWZpbGUgYi9kcml2ZXJzL2RldmZyZXEvTWFrZWZpbGUNCj4gaW5kZXgg Mzc1ZWJiYjRmY2ZiLi5mODFjMzEzYjRiNzkgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZGV2ZnJl cS9NYWtlZmlsZQ0KPiArKysgYi9kcml2ZXJzL2RldmZyZXEvTWFrZWZpbGUNCltdDQo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2RldmZyZXEvZGV2ZnJlcS5jIGIvZHJpdmVycy9kZXZmcmVxL2RldmZy ZXEuYw0KPiBpbmRleCA5ODRjNWU5ZTdiZGQuLjE1ZTU4Nzc5ZTRjMCAxMDA2NDQNCj4gLS0tIGEv ZHJpdmVycy9kZXZmcmVxL2RldmZyZXEuYw0KPiArKysgYi9kcml2ZXJzL2RldmZyZXEvZGV2ZnJl cS5jDQo+IEBAIC0xOTAsNiArMTkwLDMxIEBAIHN0YXRpYyBzdHJ1Y3QgZGV2ZnJlcV9nb3Zlcm5v ciAqZmluZF9kZXZmcmVxX2dvdmVybm9yKGNvbnN0IGNoYXIgKm5hbWUpDQo+ICANCj4gIC8qIExv YWQgbW9uaXRvcmluZyBoZWxwZXIgZnVuY3Rpb25zIGZvciBnb3Zlcm5vcnMgdXNlICovDQo+ICAN Cj4gK3N0YXRpYyBpbnQgdXBkYXRlX2RldmZyZXFfcGFzc2l2ZShzdHJ1Y3QgZGV2ZnJlcSAqZGV2 ZnJlcSwgdW5zaWduZWQgbG9uZyBmcmVxKQ0KPiArew0KPiArCXN0cnVjdCBkZXZmcmVxICpwYXNz aXZlOw0KPiArCXVuc2lnbmVkIGxvbmcgcmF0ZTsNCj4gKwlpbnQgcmV0Ow0KPiArDQo+ICsJbGlz dF9mb3JfZWFjaF9lbnRyeShwYXNzaXZlLCAmZGV2ZnJlcS0+cGFzc2l2ZV9kZXZfbGlzdCwgcGFz c2l2ZV9ub2RlKSB7DQo+ICsJCWlmICghcGFzc2l2ZS0+Z292ZXJub3IpDQo+ICsJCQljb250aW51 ZTsNCj4gKwkJcmF0ZSA9IGZyZXE7DQo+ICsNCj4gKwkJcmV0ID0gcGFzc2l2ZS0+Z292ZXJub3It PmdldF90YXJnZXRfZnJlcShwYXNzaXZlLCAmcmF0ZSk7DQo+ICsJCWlmIChyZXQpDQo+ICsJCQly ZXR1cm4gcmV0Ow0KPiArDQo+ICsJCXJldCA9IHBhc3NpdmUtPnByb2ZpbGUtPnRhcmdldChwYXNz aXZlLT5kZXYucGFyZW50LCAmcmF0ZSwgMCk7DQo+ICsJCWlmIChyZXQpDQo+ICsJCQlyZXR1cm4g cmV0Ow0KPiArDQo+ICsJCXBhc3NpdmUtPnByZXZpb3VzX2ZyZXEgPSByYXRlOw0KPiArCX0NCj4g Kw0KPiArCXJldHVybiAwOw0KPiArfQ0KPiArDQo+ICAvKioNCj4gICAqIHVwZGF0ZV9kZXZmcmVx KCkgLSBSZWV2YWx1YXRlIHRoZSBkZXZpY2UgYW5kIGNvbmZpZ3VyZSBmcmVxdWVuY3kuDQo+ICAg KiBAZGV2ZnJlcToJdGhlIGRldmZyZXEgaW5zdGFuY2UuDQo+IEBAIC0yMzMsMTAgKzI1OCwxOCBA QCBpbnQgdXBkYXRlX2RldmZyZXEoc3RydWN0IGRldmZyZXEgKmRldmZyZXEpDQo+ICAJCWZsYWdz IHw9IERFVkZSRVFfRkxBR19MRUFTVF9VUFBFUl9CT1VORDsgLyogVXNlIExVQiAqLw0KPiAgCX0N Cj4gIA0KPiArCWlmICghbGlzdF9lbXB0eSgmZGV2ZnJlcS0+cGFzc2l2ZV9kZXZfbGlzdCkNCj4g KwkJJiYgZGV2ZnJlcS0+cHJldmlvdXNfZnJlcSA+IGZyZXEpDQo+ICsJCXVwZGF0ZV9kZXZmcmVx X3Bhc3NpdmUoZGV2ZnJlcSwgZnJlcSk7DQo+ICsNCg0KQ291bGQgeW91IHBsZWFzZSBjb21tZW50 IHNvbWV3aGVyZSBhcHByb3ByaWF0ZQ0KdGhhdCB0aGUgZGVwZW5kZW50IGlzIGdvaW5nIHRvIGJl IGNoYW5nZWQNCmJlZm9yZSBpdHMgcGFyZW50IGlmIHRoZSBmcmVxdWVuY3kgaXMgZ29pbmcgZG93 bi4NCihhbmQgYWZ0ZXIgaWYgZ29pbmcgdXApDQpBbmQgc3RhdGUgd2h5IGFzIHdlbGwuDQoNCkFu ZCwgaXMgdGhpcyB2aWFibGUgdW5pdmVyc2FsbHk/DQoNCj4gIAllcnIgPSBkZXZmcmVxLT5wcm9m aWxlLT50YXJnZXQoZGV2ZnJlcS0+ZGV2LnBhcmVudCwgJmZyZXEsIGZsYWdzKTsNCj4gIAlpZiAo ZXJyKQ0KPiAgCQlyZXR1cm4gZXJyOw0KPiAgDQo+ICsJaWYgKCFsaXN0X2VtcHR5KCZkZXZmcmVx LT5wYXNzaXZlX2Rldl9saXN0KQ0KPiArCQkmJiBkZXZmcmVxLT5wcmV2aW91c19mcmVxIDwgZnJl cSkNCj4gKwkJdXBkYXRlX2RldmZyZXFfcGFzc2l2ZShkZXZmcmVxLCBmcmVxKTsNCj4gKw0KPiAg CWlmIChkZXZmcmVxLT5wcm9maWxlLT5mcmVxX3RhYmxlKQ0KPiAgCQlpZiAoZGV2ZnJlcV91cGRh dGVfc3RhdHVzKGRldmZyZXEsIGZyZXEpKQ0KPiAgCQkJZGV2X2VycigmZGV2ZnJlcS0+ZGV2LA0K PiBAQCAtNDQyLDYgKzQ3NSwxMCBAQCBzdGF0aWMgdm9pZCBfcmVtb3ZlX2RldmZyZXEoc3RydWN0 IGRldmZyZXEgKmRldmZyZXEpDQo+ICAJCXJldHVybjsNCj4gIAl9DQo+ICAJbGlzdF9kZWwoJmRl dmZyZXEtPm5vZGUpOw0KPiArCWxpc3RfZGVsKCZkZXZmcmVxLT5wYXNzaXZlX25vZGUpOw0KPiAr CWlmICghbGlzdF9lbXB0eSgmZGV2ZnJlcS0+cGFzc2l2ZV9kZXZfbGlzdCkpDQo+ICsJCWxpc3Rf ZGVsX2luaXQoJmRldmZyZXEtPnBhc3NpdmVfZGV2X2xpc3QpOw0KPiArDQo+ICAJbXV0ZXhfdW5s b2NrKCZkZXZmcmVxX2xpc3RfbG9jayk7DQo+ICANCj4gIAlpZiAoZGV2ZnJlcS0+Z292ZXJub3Ip DQo+IEBAIC01NTksNiArNTk2LDE2IEBAIHN0cnVjdCBkZXZmcmVxICpkZXZmcmVxX2FkZF9kZXZp Y2Uoc3RydWN0IGRldmljZSAqZGV2LA0KPiAgCQlnb3RvIGVycl9pbml0Ow0KPiAgCX0NCj4gIA0K PiArCWlmICghc3RybmNtcChkZXZmcmVxLT5nb3Zlcm5vcl9uYW1lLCAicGFzc2l2ZSIsIDcpKSB7 DQo+ICsJCXN0cnVjdCBkZXZmcmVxICpwYXJlbnRfZGV2ZnJlcSA9DQo+ICsJCQkoKHN0cnVjdCBk ZXZmcmVxX3Bhc3NpdmVfZGF0YSAqKWRhdGEpLT5wYXJlbnQ7DQo+ICsNCj4gKwkJbGlzdF9hZGQo JmRldmZyZXEtPnBhc3NpdmVfbm9kZSwNCj4gKwkJCSZwYXJlbnRfZGV2ZnJlcS0+cGFzc2l2ZV9k ZXZfbGlzdCk7DQo+ICsJfSBlbHNlIHsNCj4gKwkJSU5JVF9MSVNUX0hFQUQoJmRldmZyZXEtPnBh c3NpdmVfZGV2X2xpc3QpOw0KPiArCX0NCj4gKw0KPiAgCXJldHVybiBkZXZmcmVxOw0KPiAgDQo+ ICBlcnJfaW5pdDoNCg0KVGhpcyBjb2RlIGhhcyBiZWNvbWUgdG9vIG11Y2ggaW52YXNpdmUgdG8g ZGV2ZnJlcS5jDQp3aGlsZSBiZWluZyB0b28gc3BlY2lhbCBmb3IgdGhlIHBhc3NpdmUgZ292ZXJu b3IuDQoNCldoeSBkb24ndCB5b3UgYWRkIG5vdGlmaWVyIGNoYWluIHRvIGRldmZyZXEuYywgd2hp Y2ggY2FuIGJlIHVzZWQNCmJ5IGFueW9uZSBlbHNlIGFzIHdlbGwsIGFuZCB1c2UgdGhhdCBub3Rp ZmllciBmb3IgcGFzc2l2ZSBnb3Zlcm5vcj8NCllvdSBtYXkgcmVmZXIgdG8gImNwdWZyZXFfcmVn aXN0ZXJfbm90aWZpZXIoKSIgd2l0aCANCkNQVUZSRVFfVFJBTlNJVElPTl9OT1RJRklFUi4NCg0K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kZXZmcmVxL2dvdmVybm9yX3Bhc3NpdmUuYyBiL2RyaXZl cnMvZGV2ZnJlcS9nb3Zlcm5vcl9wYXNzaXZlLmMNCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCg0K VGhlbiwgdXRpbGl6aW5nIG5vdGlmaWVyLWJsb2NrIGF0IGdvdmVybm9yX3Bhc3NpdmUuYyBiZWNv bWVzIHBvc3NpYmxlLg0KDQpZb3Ugd2lsbCBhbHNvIGJlIGFibGUgdG8gd3JpdGUgYW55IGZyZXF1 ZW5jeSBkZWNpZGluZyBjb2RlDQppbnNpZGUgZ292ZXJub3JfcGFzc2l2ZS5jIGFzIHdlbGwsIG5v dCBpbiBkZXZmcmVxLmMuDQoNCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvZGV2ZnJlcS5o IGIvaW5jbHVkZS9saW51eC9kZXZmcmVxLmgNCj4gaW5kZXggNmZhMDJhMjBlYjYzLi45NWM1NDU3 OGExYjQgMTAwNjQ0DQo+IC0tLSBhL2luY2x1ZGUvbGludXgvZGV2ZnJlcS5oDQo+ICsrKyBiL2lu Y2x1ZGUvbGludXgvZGV2ZnJlcS5oDQo+IEBAIC0xNzcsNiArMTc3LDkgQEAgc3RydWN0IGRldmZy ZXEgew0KPiAgCXVuc2lnbmVkIGludCAqdHJhbnNfdGFibGU7DQo+ICAJdW5zaWduZWQgbG9uZyAq dGltZV9pbl9zdGF0ZTsNCj4gIAl1bnNpZ25lZCBsb25nIGxhc3Rfc3RhdF91cGRhdGVkOw0KPiAr DQo+ICsJc3RydWN0IGxpc3RfaGVhZCBwYXNzaXZlX2Rldl9saXN0Ow0KPiArCXN0cnVjdCBsaXN0 X2hlYWQgcGFzc2l2ZV9ub2RlOw0KPiAgfTsNCg0KWW91IHdpbGwgbmVlZCBvbmx5IG9uZSBub3Rp ZmllciBoZWFkIGhlcmUuDQoNCj4gIA0KPiAgI2lmIGRlZmluZWQoQ09ORklHX1BNX0RFVkZSRVEp DQo+IEBAIC0yNDEsNiArMjQ0LDE4IEBAIHN0cnVjdCBkZXZmcmVxX3NpbXBsZV9vbmRlbWFuZF9k YXRhIHsNCj4gIH07DQo+ICAjZW5kaWYNCj4gIA0KPiArLyoqDQo+ICsgKiBzdHJ1Y3QgZGV2ZnJl cV9wYXNzaXZlX2RhdGEgLSB2b2lkICpkYXRhIGZlZCB0byBzdHJ1Y3QgZGV2ZnJlcQ0KPiArICoJ YW5kIGRldmZyZXFfYWRkX2RldmljZQ0KPiArICogQHBhcmVudDoJCVRoZSBwYXJlbnQgZGV2ZnJl cSBkZXZpY2UuDQo+ICsgKg0KPiArICogSWYgdGhlIGZlZCBkZXZmcmVxX3Bhc3NpdmVfZGF0YSBw b2ludGVyIGlzIE5VTEwgdG8gdGhlIGdvdmVybm9yLA0KPiArICogdGhlIGdvdmVybm9yIHJldHVy biBFUlJPUi4NCj4gKyAqLw0KPiArc3RydWN0IGRldmZyZXFfcGFzc2l2ZV9kYXRhIHsNCj4gKwlz dHJ1Y3QgZGV2ZnJlcSAqcGFyZW50Ow0KPiArfTsNCj4gKw0KDQpQbGVhc2UgZW5jbG9zZSB0aGUg YWJvdmUgd2l0aCAjaWYNCg0KPiAgI2Vsc2UgLyogIUNPTkZJR19QTV9ERVZGUkVRICovDQo+ICBz dGF0aWMgaW5saW5lIHN0cnVjdCBkZXZmcmVxICpkZXZmcmVxX2FkZF9kZXZpY2Uoc3RydWN0IGRl dmljZSAqZGV2LA0KPiAgCQkJCQkgIHN0cnVjdCBkZXZmcmVxX2Rldl9wcm9maWxlICpwcm9maWxl LA0KPiAtLSANCj4gMS45LjENCj4gDQo= -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2015-12-18 02:30 +0100 |
| Message-ID | <qGS1Q-7o5-7@gated-at.bofh.it> |
| In reply to | #1290991 |
On 2015년 12월 14일 18:04, MyungJoo Ham wrote:
>>
>> This patch adds the new passive governor for DEVFREQ framework. The following
>> governors are already present and used for DVFS (Dynamic Voltage and Frequency
>> Scaling) drivers. The following governors are independently used for one device
>> driver which don't give the influence to other device drviers and also don't
>> receive the effect from other device drivers.
>> - ondemand / performance / powersave / userspace
>>
>> The passive governor depends on operation of parent driver with specific
>> governos extremely and is not able to decide the new frequency by oneself.
>> According to the decided new frequency of parent driver with governor,
>> the passive governor uses it to decide the appropriate frequency for own
>> device driver. The passive governor must need the following information
>> from device tree:
>> - the source clock and OPP tables
>> - the instance of parent device
>>
>> For exameple,
>> there are one more devfreq device drivers which need to change their source
>> clock according to their utilization on runtime. But, they share the same
>> power line (e.g., regulator). So, specific device driver is operated as parent
>> with ondemand governor and then the rest device driver with passive governor
>> is influenced by parent device.
>>
>> Suggested-by: Myungjoo Ham <myungjoo.ham@samsung.com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> [linux.amoon: Tested on Odroid U3]
>> Tested-by: Anand Moon <linux.amoon@gmail.com>
>> ---
>> drivers/devfreq/Kconfig | 9 ++++
>> drivers/devfreq/Makefile | 1 +
>> drivers/devfreq/devfreq.c | 47 ++++++++++++++++
>> drivers/devfreq/governor_passive.c | 108 +++++++++++++++++++++++++++++++++++++
>> include/linux/devfreq.h | 15 ++++++
>> 5 files changed, 180 insertions(+)
>> create mode 100644 drivers/devfreq/governor_passive.c
>>
>> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
>> index 55ec774f794c..d03f635a93e1 100644
>> --- a/drivers/devfreq/Kconfig
>> +++ b/drivers/devfreq/Kconfig
>> @@ -64,6 +64,15 @@ config DEVFREQ_GOV_USERSPACE
>> Otherwise, the governor does not change the frequnecy
>> given at the initialization.
>>
>> +config DEVFREQ_GOV_PASSIVE
>> + tristate "Passive"
>> + help
>> + Sets the frequency by other governors (simple_ondemand, performance,
>> + powersave, usersapce) of a parent devfreq device. This governor
>> + always has the dependency on the chosen frequency from paired
>> + governor. This governor does not change the frequency by oneself
>> + through sysfs entry.
>
> Sets the frequency based on the frequency of its parent devfreq
> device. This governor does not change the frequency by itself
> through sysfs entries.
OK. I'll modify it.
>
>> +
>> comment "DEVFREQ Drivers"
>>
>> config ARM_EXYNOS_BUS_DEVFREQ
>> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile
>> index 375ebbb4fcfb..f81c313b4b79 100644
>> --- a/drivers/devfreq/Makefile
>> +++ b/drivers/devfreq/Makefile
> []
>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>> index 984c5e9e7bdd..15e58779e4c0 100644
>> --- a/drivers/devfreq/devfreq.c
>> +++ b/drivers/devfreq/devfreq.c
>> @@ -190,6 +190,31 @@ static struct devfreq_governor *find_devfreq_governor(const char *name)
>>
>> /* Load monitoring helper functions for governors use */
>>
>> +static int update_devfreq_passive(struct devfreq *devfreq, unsigned long freq)
>> +{
>> + struct devfreq *passive;
>> + unsigned long rate;
>> + int ret;
>> +
>> + list_for_each_entry(passive, &devfreq->passive_dev_list, passive_node) {
>> + if (!passive->governor)
>> + continue;
>> + rate = freq;
>> +
>> + ret = passive->governor->get_target_freq(passive, &rate);
>> + if (ret)
>> + return ret;
>> +
>> + ret = passive->profile->target(passive->dev.parent, &rate, 0);
>> + if (ret)
>> + return ret;
>> +
>> + passive->previous_freq = rate;
>> + }
>> +
>> + return 0;
>> +}
>> +
>> /**
>> * update_devfreq() - Reevaluate the device and configure frequency.
>> * @devfreq: the devfreq instance.
>> @@ -233,10 +258,18 @@ int update_devfreq(struct devfreq *devfreq)
>> flags |= DEVFREQ_FLAG_LEAST_UPPER_BOUND; /* Use LUB */
>> }
>>
>> + if (!list_empty(&devfreq->passive_dev_list)
>> + && devfreq->previous_freq > freq)
>> + update_devfreq_passive(devfreq, freq);
>> +
>
> Could you please comment somewhere appropriate
> that the dependent is going to be changed
> before its parent if the frequency is going down.
> (and after if going up)
> And state why as well.
I use the DEVFREQ_TRANSITION_NOTIFIER instead of this implementation.
>
> And, is this viable universally?
>
>> err = devfreq->profile->target(devfreq->dev.parent, &freq, flags);
>> if (err)
>> return err;
>>
>> + if (!list_empty(&devfreq->passive_dev_list)
>> + && devfreq->previous_freq < freq)
>> + update_devfreq_passive(devfreq, freq);
>> +
>> if (devfreq->profile->freq_table)
>> if (devfreq_update_status(devfreq, freq))
>> dev_err(&devfreq->dev,
>> @@ -442,6 +475,10 @@ static void _remove_devfreq(struct devfreq *devfreq)
>> return;
>> }
>> list_del(&devfreq->node);
>> + list_del(&devfreq->passive_node);
>> + if (!list_empty(&devfreq->passive_dev_list))
>> + list_del_init(&devfreq->passive_dev_list);
>> +
>> mutex_unlock(&devfreq_list_lock);
>>
>> if (devfreq->governor)
>> @@ -559,6 +596,16 @@ struct devfreq *devfreq_add_device(struct device *dev,
>> goto err_init;
>> }
>>
>> + if (!strncmp(devfreq->governor_name, "passive", 7)) {
>> + struct devfreq *parent_devfreq =
>> + ((struct devfreq_passive_data *)data)->parent;
>> +
>> + list_add(&devfreq->passive_node,
>> + &parent_devfreq->passive_dev_list);
>> + } else {
>> + INIT_LIST_HEAD(&devfreq->passive_dev_list);
>> + }
>> +
>> return devfreq;
>>
>> err_init:
>
> This code has become too much invasive to devfreq.c
> while being too special for the passive governor.
I agree. I'll implement again with notifier.
>
> Why don't you add notifier chain to devfreq.c, which can be used
> by anyone else as well, and use that notifier for passive governor?
> You may refer to "cpufreq_register_notifier()" with
> CPUFREQ_TRANSITION_NOTIFIER.
OK. I'll add the new notifier of DEVFREQ_TRANSITION_NOTIFIER
The list of supported notification:
DEVFREQ_PRECHANGE
DEVFREQ_POSTCHANGE
>
>> diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c
>> new file mode 100644
>
> Then, utilizing notifier-block at governor_passive.c becomes possible.
>
> You will also be able to write any frequency deciding code
> inside governor_passive.c as well, not in devfreq.c.
OK, I'll use DEVFREQ_TRANSITION_NOTIFIER for passive governor.
>
>> diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
>> index 6fa02a20eb63..95c54578a1b4 100644
>> --- a/include/linux/devfreq.h
>> +++ b/include/linux/devfreq.h
>> @@ -177,6 +177,9 @@ struct devfreq {
>> unsigned int *trans_table;
>> unsigned long *time_in_state;
>> unsigned long last_stat_updated;
>> +
>> + struct list_head passive_dev_list;
>> + struct list_head passive_node;
>> };
>
> You will need only one notifier head here.
OK.
>
>>
>> #if defined(CONFIG_PM_DEVFREQ)
>> @@ -241,6 +244,18 @@ struct devfreq_simple_ondemand_data {
>> };
>> #endif
>>
>> +/**
>> + * struct devfreq_passive_data - void *data fed to struct devfreq
>> + * and devfreq_add_device
>> + * @parent: The parent devfreq device.
>> + *
>> + * If the fed devfreq_passive_data pointer is NULL to the governor,
>> + * the governor return ERROR.
>> + */
>> +struct devfreq_passive_data {
>> + struct devfreq *parent;
>> +};
>> +
>
> Please enclose the above with #if
OK.
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web