Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1293733 > unrolled thread

[PATCH 2/2] power:bq27xxx: fix register numbers of bq27500

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] power:bq27xxx: fix register numbers of bq27500 "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-12-17 11:20 +0100
    Re: [PATCH 2/2] power:bq27xxx: fix register numbers of bq27500 "Andrew F. Davis" <afd@ti.com> - 2015-12-24 04:00 +0100

#1293733 — [PATCH 2/2] power:bq27xxx: fix register numbers of bq27500

bug: according to data sheet some register numbers are wrong.

tested: no

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 drivers/power/bq27xxx_battery.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
index e54a125..f9a5f4f 100644
--- a/drivers/power/bq27xxx_battery.c
+++ b/drivers/power/bq27xxx_battery.c
@@ -198,10 +198,10 @@ static u8 bq27500_regs[] = {
 	INVALID_REG_ADDR,	/* TTECP - NA	*/
 	0x0c,	/* NAC		*/
 	0x12,	/* LMD(FCC)	*/
-	0x1e,	/* CYCT		*/
+	0x2a,	/* CYCT		*/
 	INVALID_REG_ADDR,	/* AE - NA	*/
-	0x20,	/* SOC(RSOC)	*/
-	0x2e,	/* DCAP(ILMD)	*/
+	0x2c,	/* SOC(RSOC)	*/
+	0x3c,	/* DCAP(ILMD)	*/
 	INVALID_REG_ADDR,	/* AP - NA	*/
 };
 
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1297730

On 12/17/2015 04:12 AM, H. Nikolaus Schaller wrote:
> bug: according to data sheet some register numbers are wrong.
>
> tested: no
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>

Indeed they are, good catch.

Acked-by: Andrew F. Davis <afd@ti.com>

> ---
>   drivers/power/bq27xxx_battery.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> index e54a125..f9a5f4f 100644
> --- a/drivers/power/bq27xxx_battery.c
> +++ b/drivers/power/bq27xxx_battery.c
> @@ -198,10 +198,10 @@ static u8 bq27500_regs[] = {
>   	INVALID_REG_ADDR,	/* TTECP - NA	*/
>   	0x0c,	/* NAC		*/
>   	0x12,	/* LMD(FCC)	*/
> -	0x1e,	/* CYCT		*/
> +	0x2a,	/* CYCT		*/
>   	INVALID_REG_ADDR,	/* AE - NA	*/
> -	0x20,	/* SOC(RSOC)	*/
> -	0x2e,	/* DCAP(ILMD)	*/
> +	0x2c,	/* SOC(RSOC)	*/
> +	0x3c,	/* DCAP(ILMD)	*/
>   	INVALID_REG_ADDR,	/* AP - NA	*/
>   };
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web