Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1293681 > unrolled thread

[PATCH 0/3] Introduce reg stride order

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] Introduce reg stride order  Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-17 09:50 +0100
    [PATCH 3/3] regcache: flat: Introduce regcache_get_index() Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-17 09:50 +0100

#1293681 — [PATCH 0/3] Introduce reg stride order

Xiubo Li (3):
  regmap: core: Introduce register stride order
  regcache: Introduce the index parsing API
  regcache: flat: Introduce regcache_get_index()

 drivers/base/regmap/internal.h      | 13 +++++++++++++
 drivers/base/regmap/regcache-flat.c | 11 ++++++-----
 drivers/base/regmap/regmap.c        | 15 +++++++++------
 3 files changed, 28 insertions(+), 11 deletions(-)

-- 
1.8.3.1



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1293683 — [PATCH 3/3] regcache: flat: Introduce regcache_get_index()

Here we introduce regcache_get_index(), which using register stride
order and bit rotation, will save some memory spaces for flat cache.
Though this will also lost some access performance, since the bit
rotation is used to get the index of the cache array, and this could
be ingored for memory I/O accessing.

Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
---
 drivers/base/regmap/regcache-flat.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/base/regmap/regcache-flat.c b/drivers/base/regmap/regcache-flat.c
index 686c9e0..218cf39 100644
--- a/drivers/base/regmap/regcache-flat.c
+++ b/drivers/base/regmap/regcache-flat.c
@@ -21,15 +21,16 @@ static int regcache_flat_init(struct regmap *map)
 	int i;
 	unsigned int *cache;
 
-	map->cache = kcalloc(map->max_register + 1, sizeof(unsigned int),
-			     GFP_KERNEL);
+	map->cache = kcalloc(regcache_get_index(map, map->max_register) + 1,
+			     sizeof(unsigned int), GFP_KERNEL);
 	if (!map->cache)
 		return -ENOMEM;
 
 	cache = map->cache;
 
 	for (i = 0; i < map->num_reg_defaults; i++)
-		cache[map->reg_defaults[i].reg] = map->reg_defaults[i].def;
+		cache[regcache_get_index(map, map->reg_defaults[i].reg)] =
+				map->reg_defaults[i].def;
 
 	return 0;
 }
@@ -47,7 +48,7 @@ static int regcache_flat_read(struct regmap *map,
 {
 	unsigned int *cache = map->cache;
 
-	*value = cache[reg];
+	*value = cache[regcache_get_index(map, reg)];
 
 	return 0;
 }
@@ -57,7 +58,7 @@ static int regcache_flat_write(struct regmap *map, unsigned int reg,
 {
 	unsigned int *cache = map->cache;
 
-	cache[reg] = value;
+	cache[regcache_get_index(map, reg)] = value;
 
 	return 0;
 }
-- 
1.8.3.1



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web