Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1290576 > unrolled thread

Re: [PATCH 0/9] Fix checkpatch errors

Started byGreg KH <gregkh@linuxfoundation.org>
First post2015-12-13 08:10 +0100
Last post2015-12-13 21:40 +0100
Articles 5 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 0/9] Fix checkpatch errors Greg KH <gregkh@linuxfoundation.org> - 2015-12-13 08:10 +0100
    Re: [PATCH 0/9] Fix checkpatch errors Frederik <frederik.voelkel@fau.de> - 2015-12-13 18:50 +0100
      Re: [PATCH 0/9] Fix checkpatch errors Nicolai Stange <nicstange@gmail.com> - 2015-12-13 19:20 +0100
        Re: [PATCH 0/9] Fix checkpatch errors Frederik <frederik.voelkel@fau.de> - 2015-12-13 19:30 +0100
          Re: [PATCH 0/9] Fix checkpatch errors Ken Moffat <zarniwhoop@ntlworld.com> - 2015-12-13 21:40 +0100

#1290576 — Re: [PATCH 0/9] Fix checkpatch errors

FromGreg KH <gregkh@linuxfoundation.org>
Date2015-12-13 08:10 +0100
SubjectRe: [PATCH 0/9] Fix checkpatch errors
Message-ID<qF8X8-5dl-5@gated-at.bofh.it>
On Fri, Dec 11, 2015 at 11:36:00AM +0100, Frederik Völkel wrote:
> This patch series fixes all checkpatch error in 68328serial.c except
> 5 trailing whitespace errors we are unsure how to fix.

What are the errors you are not sure how to fix?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1290656

FromFrederik <frederik.voelkel@fau.de>
Date2015-12-13 18:50 +0100
Message-ID<qFiWt-2XZ-3@gated-at.bofh.it>
In reply to#1290576
On Sat, 12. Dec 23:06, Greg KH wrote:
> On Fri, Dec 11, 2015 at 11:36:00AM +0100, Frederik Völkel wrote:
> > This patch series fixes all checkpatch error in 68328serial.c except
> > 5 trailing whitespace errors we are unsure how to fix.
> 
> What are the errors you are not sure how to fix?
> 
> thanks,
> 
> greg k-h

All 5 errors are at comments. It is not clear to us where exactly the
trailing whitespace is checkpatch complains(lines 271, 770, 889, 993
and 1040).

Greetings,

Lukas and Frederik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1290662

FromNicolai Stange <nicstange@gmail.com>
Date2015-12-13 19:20 +0100
Message-ID<qFjpw-3nE-11@gated-at.bofh.it>
In reply to#1290656
Frederik <frederik.voelkel@fau.de> writes:

> On Sat, 12. Dec 23:06, Greg KH wrote:
>> On Fri, Dec 11, 2015 at 11:36:00AM +0100, Frederik Völkel wrote:
>> > This patch series fixes all checkpatch error in 68328serial.c except
>> > 5 trailing whitespace errors we are unsure how to fix.
>> 
>> What are the errors you are not sure how to fix?
>> 
>> thanks,
>> 
>> greg k-h
>
> All 5 errors are at comments. It is not clear to us where exactly the
> trailing whitespace is checkpatch complains(lines 271, 770, 889, 993
> and 1040).

W/o your series applied (so line numbering might be slightly
different), checkpatch.pl says:

  ERROR: trailing whitespace
  #270: FILE: -:270:
  +^I * This do { } while() loop will get ALL chars out of Rx FIFO $

AFAICS, your patch [7/9] ("drivers: tty: 68328serial.c: remove trailing
whitespaces") doesn't fix this one.

In good old regexp tradition, the '$' sign denotes the end of line. So,
there is a single space after "FIFO" and before the end of line.

If you happen to be Emacs users, consider trying out whitespace-mode.
If not, try to find another way to make your editor visualize whitespace
somehow.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1290664

FromFrederik <frederik.voelkel@fau.de>
Date2015-12-13 19:30 +0100
Message-ID<qFjzb-3sE-21@gated-at.bofh.it>
In reply to#1290662
On Sun, 13. Dec 19:15, Nicolai Stange wrote:
> Frederik <frederik.voelkel@fau.de> writes:
> 
> > On Sat, 12. Dec 23:06, Greg KH wrote:
> >> On Fri, Dec 11, 2015 at 11:36:00AM +0100, Frederik Völkel wrote:
> >> > This patch series fixes all checkpatch error in 68328serial.c except
> >> > 5 trailing whitespace errors we are unsure how to fix.
> >> 
> >> What are the errors you are not sure how to fix?
> >> 
> >> thanks,
> >> 
> >> greg k-h
> >
> > All 5 errors are at comments. It is not clear to us where exactly the
> > trailing whitespace is checkpatch complains(lines 271, 770, 889, 993
> > and 1040).
> 
> W/o your series applied (so line numbering might be slightly
> different), checkpatch.pl says:
> 
>   ERROR: trailing whitespace
>   #270: FILE: -:270:
>   +^I * This do { } while() loop will get ALL chars out of Rx FIFO $
> 
> AFAICS, your patch [7/9] ("drivers: tty: 68328serial.c: remove trailing
> whitespaces") doesn't fix this one.
> 
> In good old regexp tradition, the '$' sign denotes the end of line. So,
> there is a single space after "FIFO" and before the end of line.
> 
> If you happen to be Emacs users, consider trying out whitespace-mode.
> If not, try to find another way to make your editor visualize whitespace
> somehow.

Oh right I see. We will fix that and resend.

Thank you!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1290694

FromKen Moffat <zarniwhoop@ntlworld.com>
Date2015-12-13 21:40 +0100
Message-ID<qFlB0-4IZ-15@gated-at.bofh.it>
In reply to#1290664
On Sun, Dec 13, 2015 at 07:26:04PM +0100, Frederik wrote:
> On Sun, 13. Dec 19:15, Nicolai Stange wrote:
> > Frederik <frederik.voelkel@fau.de> writes:
> > 
> > W/o your series applied (so line numbering might be slightly
> > different), checkpatch.pl says:
> > 
> >   ERROR: trailing whitespace
> >   #270: FILE: -:270:
> >   +^I * This do { } while() loop will get ALL chars out of Rx FIFO $
> > 
> > AFAICS, your patch [7/9] ("drivers: tty: 68328serial.c: remove trailing
> > whitespaces") doesn't fix this one.
> > 
> > In good old regexp tradition, the '$' sign denotes the end of line. So,
> > there is a single space after "FIFO" and before the end of line.
> > 
> > If you happen to be Emacs users, consider trying out whitespace-mode.
> > If not, try to find another way to make your editor visualize whitespace
> > somehow.
> 
> Oh right I see. We will fix that and resend.
> 
> Thank you!
If you are using vim, I have the following in my .vimrc.  It was
originally posted here many years ago.  Seems to work on all my x86
boxes, but AFAIR it didn't work on a ppc, so might not work on other
architectures.

"for redundant whitespace, from Jeremy Kerr via Olof Johanson
highlight RedundantWhitespace ctermbg=red guibg=red
match RedundantWhitespace /\s\+$\| \+\ze\t/

HTH

ĸen
-- 
This email was written using 100% recycled letters.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web