Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1290615 > unrolled thread
| Started by | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| First post | 2015-12-13 14:50 +0100 |
| Last post | 2015-12-13 15:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] Staging: iio: accel: Fixed NULL comparison style Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2015-12-13 14:50 +0100
Re: [PATCH v2] Staging: iio: accel: Fixed NULL comparison style Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-13 15:00 +0100
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Date | 2015-12-13 14:50 +0100 |
| Subject | [PATCH v2] Staging: iio: accel: Fixed NULL comparison style |
| Message-ID | <qFfce-yf-3@gated-at.bofh.it> |
The variable u8 **rx_p, is a pointer-to-pointer and hence the check should
be "if (!*rx_p)" and not "if (!rx_p)".
In the earlier version, checkpatch.pl gave the following check, which was
buggy:
CHECK: Comparison to NULL could be written "!rx_p"
+ if (*rx_p == NULL) {
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
Changes in v2:
-Replaced "if (!rx_p)" with "if (!*rx_p)"
drivers/staging/iio/accel/sca3000_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c
index 5339b10..1920dc60 100644
--- a/drivers/staging/iio/accel/sca3000_ring.c
+++ b/drivers/staging/iio/accel/sca3000_ring.c
@@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
}
};
*rx_p = kmalloc(len, GFP_KERNEL);
- if (!rx_p) {
+ if (!*rx_p) {
ret = -ENOMEM;
goto error_ret;
}
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2015-12-13 15:00 +0100 |
| Message-ID | <qFflU-CN-13@gated-at.bofh.it> |
| In reply to | #1290615 |
You have to resend it to apply on the original code, we are not going to
apply the first version of this patch. In other words it is:
- if (*rx_p == NULL) {
+ if (!*rxp) {
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web