Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1290154 > unrolled thread

Re: [lm-sensors] LM90 driver and ti tmp461 detection

Started byJean Delvare <jdelvare@suse.de>
First post2015-12-12 11:10 +0100
Last post2015-12-18 09:30 +0100
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [lm-sensors] LM90 driver and ti tmp461 detection Jean Delvare <jdelvare@suse.de> - 2015-12-12 11:10 +0100
    Re: [lm-sensors] LM90 driver and ti tmp461 detection Andreas Werner <andreas.werner@men.de> - 2015-12-15 16:40 +0100
      Re: [lm-sensors] LM90 driver and ti tmp461 detection Jean Delvare <jdelvare@suse.de> - 2015-12-17 12:50 +0100
        Re: [lm-sensors] LM90 driver and ti tmp461 detection Andreas Werner <andreas.werner@men.de> - 2015-12-17 13:00 +0100
        Re: [lm-sensors] LM90 driver and ti tmp461 detection Guenter Roeck <linux@roeck-us.net> - 2015-12-17 16:00 +0100
          Re: [lm-sensors] LM90 driver and ti tmp461 detection Andreas Werner <andreas.werner@men.de> - 2015-12-18 09:30 +0100

#1290154 — Re: [lm-sensors] LM90 driver and ti tmp461 detection

FromJean Delvare <jdelvare@suse.de>
Date2015-12-12 11:10 +0100
SubjectRe: [lm-sensors] LM90 driver and ti tmp461 detection
Message-ID<qEPhL-My-1@gated-at.bofh.it>
Hallo Andreas,

On Thu, 10 Dec 2015 18:12:31 +0100, Andreas Werner wrote:
> thanks for the register dump :-)

Can you please share the register dump of your TMP461 with us?

Thanks,
-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1292265

FromAndreas Werner <andreas.werner@men.de>
Date2015-12-15 16:40 +0100
Message-ID<qFZRM-64B-19@gated-at.bofh.it>
In reply to#1290154
On Sat, Dec 12, 2015 at 11:08:42AM +0100, Jean Delvare wrote:
> Hallo Andreas,
> 
> On Thu, 10 Dec 2015 18:12:31 +0100, Andreas Werner wrote:
> > thanks for the register dump :-)
> 
> Can you please share the register dump of your TMP461 with us?
> 
> Thanks,
> -- 
> Jean Delvare
> SUSE L3 Support

Hi,
here is the register dump of the tmp461.
It seemse that we really cannot detect if it is a tmp461 or a tmp451.
Also the magic "ID Register" offset 0xff is 0x00 for both devices.

     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    0123456789abcdef
00: 5a 00 2c 00 05 7f 80 7f 80 00 00 00 00 00 00 00    Z.,.?????.......
10: 00 00 00 f0 00 80 03 00 00 7f 00 00 00 00 00 00    ...?.??..?......
20: 7f 0a 01 00 00 XX 00 00 00 00 0e 00 00 00 40 00    ???..X....?...@.
30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 55 00    ..............U.

Regards
Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1293803

FromJean Delvare <jdelvare@suse.de>
Date2015-12-17 12:50 +0100
Message-ID<qGFeh-7iO-5@gated-at.bofh.it>
In reply to#1292265
Hi Andreas,

On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote:
> here is the register dump of the tmp461.

Thanks.

> It seemse that we really cannot detect if it is a tmp461 or a tmp451.
> Also the magic "ID Register" offset 0xff is 0x00 for both devices.

I would use register 0x16, which doesn't exist but reads 0x00 on the
TMP451. It could in theory also read 0x00 on the TMP461 but only if
both channels are disabled, which makes little sense. More likely at
least one channel will be enabled so you'll have value 0x01-0x03 if
this is a TMP461.

-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1293813

FromAndreas Werner <andreas.werner@men.de>
Date2015-12-17 13:00 +0100
Message-ID<qGFnY-7mN-7@gated-at.bofh.it>
In reply to#1293803
On Thu, Dec 17, 2015 at 12:48:08PM +0100, Jean Delvare wrote:
> Hi Andreas,
> 
> On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote:
> > here is the register dump of the tmp461.
> 
> Thanks.
> 
> > It seemse that we really cannot detect if it is a tmp461 or a tmp451.
> > Also the magic "ID Register" offset 0xff is 0x00 for both devices.
> 
> I would use register 0x16, which doesn't exist but reads 0x00 on the
> TMP451. It could in theory also read 0x00 on the TMP461 but only if
> both channels are disabled, which makes little sense. More likely at
> least one channel will be enabled so you'll have value 0x01-0x03 if
> this is a TMP461.
>

Yes you are right. Both channels are enabled during POR, so the chance
to have a 0x00 as in the TMP451 will be very low.
 
> -- 
> Jean Delvare
> SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1293955

FromGuenter Roeck <linux@roeck-us.net>
Date2015-12-17 16:00 +0100
Message-ID<qGIcb-Ma-27@gated-at.bofh.it>
In reply to#1293803
On Thu, Dec 17, 2015 at 12:48:08PM +0100, Jean Delvare wrote:
> Hi Andreas,
> 
> On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote:
> > here is the register dump of the tmp461.
> 
> Thanks.
> 
> > It seemse that we really cannot detect if it is a tmp461 or a tmp451.
> > Also the magic "ID Register" offset 0xff is 0x00 for both devices.
> 
> I would use register 0x16, which doesn't exist but reads 0x00 on the
> TMP451. It could in theory also read 0x00 on the TMP461 but only if
> both channels are disabled, which makes little sense. More likely at
> least one channel will be enabled so you'll have value 0x01-0x03 if
> this is a TMP461.
> 
Excellent idea!

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1294493

FromAndreas Werner <andreas.werner@men.de>
Date2015-12-18 09:30 +0100
Message-ID<qGYAi-3aB-13@gated-at.bofh.it>
In reply to#1293955
On Thu, Dec 17, 2015 at 06:57:51AM -0800, Guenter Roeck wrote:
> On Thu, Dec 17, 2015 at 12:48:08PM +0100, Jean Delvare wrote:
> > Hi Andreas,
> > 
> > On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote:
> > > here is the register dump of the tmp461.
> > 
> > Thanks.
> > 
> > > It seemse that we really cannot detect if it is a tmp461 or a tmp451.
> > > Also the magic "ID Register" offset 0xff is 0x00 for both devices.
> > 
> > I would use register 0x16, which doesn't exist but reads 0x00 on the
> > TMP451. It could in theory also read 0x00 on the TMP461 but only if
> > both channels are disabled, which makes little sense. More likely at
> > least one channel will be enabled so you'll have value 0x01-0x03 if
> > this is a TMP461.
> > 
> Excellent idea!
> 
> Guenter

Ok, i will implement the detection for the tm461 and also the temp calculation
for setting the temperature value.

Will send a patch as soon as i am done.

Regards
Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web