Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1292225 > unrolled thread

[PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes

Started byJisheng Zhang <jszhang@marvell.com>
First post2015-12-15 15:50 +0100
Last post2015-12-15 16:00 +0100
Articles 4 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes Jisheng Zhang <jszhang@marvell.com> - 2015-12-15 15:50 +0100
    Re: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes Arnd Bergmann <arnd@arndb.de> - 2015-12-15 15:50 +0100
      Re: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific  pmu nodes Jisheng Zhang <jszhang@marvell.com> - 2015-12-15 16:00 +0100
        Re: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu  nodes Mark Rutland <mark.rutland@arm.com> - 2015-12-15 16:00 +0100

#1292225 — [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes

FromJisheng Zhang <jszhang@marvell.com>
Date2015-12-15 15:50 +0100
Subject[PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes
Message-ID<qFZ5n-5o7-1@gated-at.bofh.it>
Commit ac82d1277215 ("arm64: perf: add Cortex-A53 support") adds the
cortex A53 PMU support, thus instead of using the generic armv8-pmuv3
compatibility use the more specific Cortex A53 compatibility.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm64/boot/dts/marvell/berlin4ct.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
index 099ad93..e48d424 100644
--- a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
+++ b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
@@ -115,7 +115,7 @@
 	};
 
 	pmu {
-		compatible = "arm,armv8-pmuv3";
+		compatible = "arm,cortex-a53-pmu";
 		interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1292228

FromArnd Bergmann <arnd@arndb.de>
Date2015-12-15 15:50 +0100
Message-ID<qFZ5o-5o7-11@gated-at.bofh.it>
In reply to#1292225
On Tuesday 15 December 2015 22:36:12 Jisheng Zhang wrote:
> -               compatible = "arm,armv8-pmuv3";
> +               compatible = "arm,cortex-a53-pmu";
> 

Should this list both?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1292232 — Re: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes

FromJisheng Zhang <jszhang@marvell.com>
Date2015-12-15 16:00 +0100
SubjectRe: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes
Message-ID<qFZf4-5rq-1@gated-at.bofh.it>
In reply to#1292228
Dear Arnd,

On Tue, 15 Dec 2015 15:43:53 +0100 Arnd Bergmann wrote:

> On Tuesday 15 December 2015 22:36:12 Jisheng Zhang wrote:
> > -               compatible = "arm,armv8-pmuv3";
> > +               compatible = "arm,cortex-a53-pmu";
> >   
> 
> Should this list both?

IMHO, we don't need to list both. The pmu binding document also says:
"compatible : should be one of ...."

Dear Mark,

Could you please give suggestions?

Thanks,
Jisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1292234 — Re: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes

FromMark Rutland <mark.rutland@arm.com>
Date2015-12-15 16:00 +0100
SubjectRe: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes
Message-ID<qFZf4-5rq-17@gated-at.bofh.it>
In reply to#1292232
On Tue, Dec 15, 2015 at 10:47:09PM +0800, Jisheng Zhang wrote:
> Dear Arnd,
> 
> On Tue, 15 Dec 2015 15:43:53 +0100 Arnd Bergmann wrote:
> 
> > On Tuesday 15 December 2015 22:36:12 Jisheng Zhang wrote:
> > > -               compatible = "arm,armv8-pmuv3";
> > > +               compatible = "arm,cortex-a53-pmu";
> > >   
> > 
> > Should this list both?
> 
> IMHO, we don't need to list both. The pmu binding document also says:
> "compatible : should be one of ...."
> 
> Dear Mark,
> 
> Could you please give suggestions?

That should probably reads as "should contain at least one of".

It's probably best to keep "arm,armv8-pmuv3" as a fallback in the
compatible list.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web