Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1290213 > unrolled thread

[PATCH] clk:gcc-msm8916: add missing mss_q6_bimc_axi clock

Back to article view | Back to linux.kernel

Contents

  [PATCH] clk:gcc-msm8916: add missing mss_q6_bimc_axi clock Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-12-12 16:40 +0100
    Re: [PATCH] clk:gcc-msm8916: add missing mss_q6_bimc_axi clock Georgi Djakov <georgi.djakov@linaro.org> - 2015-12-15 14:20 +0100
      Re: [PATCH] clk:gcc-msm8916: add missing mss_q6_bimc_axi clock Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-12-15 14:30 +0100

#1290213 — [PATCH] clk:gcc-msm8916: add missing mss_q6_bimc_axi clock

This clock is required for loading the qdsp firmware.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/clk/qcom/gcc-msm8916.c               | 18 ++++++++++++++++++
 include/dt-bindings/clock/qcom,gcc-msm8916.h |  1 +
 2 files changed, 19 insertions(+)

diff --git a/drivers/clk/qcom/gcc-msm8916.c b/drivers/clk/qcom/gcc-msm8916.c
index e3bf09d..1ec5a27 100644
--- a/drivers/clk/qcom/gcc-msm8916.c
+++ b/drivers/clk/qcom/gcc-msm8916.c
@@ -2590,6 +2590,23 @@ static struct clk_branch gcc_mss_cfg_ahb_clk = {
 	},
 };
 
+static struct clk_branch gcc_mss_q6_bimc_axi_clk = {
+	.halt_reg = 0x49004,
+	.clkr = {
+		.enable_reg = 0x49004,
+		.enable_mask = BIT(0),
+		.hw.init = &(struct clk_init_data){
+			.name = "gcc_mss_q6_bimc_axi_clk",
+			.parent_names = (const char *[]){
+				"pcnoc_bfdcd_clk_src",
+			},
+			.num_parents = 1,
+			.flags = CLK_SET_RATE_PARENT,
+			.ops = &clk_branch2_ops,
+		},
+	},
+};
+
 static struct clk_branch gcc_oxili_ahb_clk = {
 	.halt_reg = 0x59028,
 	.clkr = {
@@ -3227,6 +3244,7 @@ static struct clk_regmap *gcc_msm8916_clocks[] = {
 	[GCC_ULTAUDIO_LPAIF_SEC_I2S_CLK] = &gcc_ultaudio_lpaif_sec_i2s_clk.clkr,
 	[GCC_ULTAUDIO_LPAIF_AUX_I2S_CLK] = &gcc_ultaudio_lpaif_aux_i2s_clk.clkr,
 	[GCC_CODEC_DIGCODEC_CLK] = &gcc_codec_digcodec_clk.clkr,
+	[GCC_MSS_Q6_BIMC_AXI_CLK] = &gcc_mss_q6_bimc_axi_clk.clkr,
 };
 
 static struct gdsc *gcc_msm8916_gdscs[] = {
diff --git a/include/dt-bindings/clock/qcom,gcc-msm8916.h b/include/dt-bindings/clock/qcom,gcc-msm8916.h
index 257e2fb..28a27a4 100644
--- a/include/dt-bindings/clock/qcom,gcc-msm8916.h
+++ b/include/dt-bindings/clock/qcom,gcc-msm8916.h
@@ -174,6 +174,7 @@
 #define GCC_ULTAUDIO_LPAIF_SEC_I2S_CLK		157
 #define GCC_ULTAUDIO_LPAIF_AUX_I2S_CLK		158
 #define GCC_CODEC_DIGCODEC_CLK			159
+#define GCC_MSS_Q6_BIMC_AXI_CLK			160
 
 /* Indexes for GDSCs */
 #define BIMC_GDSC				0
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1292165

Hi Srini,
Thanks for the patch.

On 12/12/2015 05:39 PM, Srinivas Kandagatla wrote:
> This clock is required for loading the qdsp firmware.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  drivers/clk/qcom/gcc-msm8916.c               | 18 ++++++++++++++++++
>  include/dt-bindings/clock/qcom,gcc-msm8916.h |  1 +
>  2 files changed, 19 insertions(+)
> 
> diff --git a/drivers/clk/qcom/gcc-msm8916.c b/drivers/clk/qcom/gcc-msm8916.c
> index e3bf09d..1ec5a27 100644
> --- a/drivers/clk/qcom/gcc-msm8916.c
> +++ b/drivers/clk/qcom/gcc-msm8916.c
> @@ -2590,6 +2590,23 @@ static struct clk_branch gcc_mss_cfg_ahb_clk = {
>  	},
>  };
>  
> +static struct clk_branch gcc_mss_q6_bimc_axi_clk = {
> +	.halt_reg = 0x49004,
> +	.clkr = {
> +		.enable_reg = 0x49004,
> +		.enable_mask = BIT(0),
> +		.hw.init = &(struct clk_init_data){
> +			.name = "gcc_mss_q6_bimc_axi_clk",
> +			.parent_names = (const char *[]){
> +				"pcnoc_bfdcd_clk_src",

Looks like the parent should be bimc_ddr_clk_src.
Otherwise looks fine to me.

BR,
Georgi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1292175

On 15/12/15 13:15, Georgi Djakov wrote:
> Hi Srini,
> Thanks for the patch.
>
> On 12/12/2015 05:39 PM, Srinivas Kandagatla wrote:
>> This clock is required for loading the qdsp firmware.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>>   drivers/clk/qcom/gcc-msm8916.c               | 18 ++++++++++++++++++
>>   include/dt-bindings/clock/qcom,gcc-msm8916.h |  1 +
>>   2 files changed, 19 insertions(+)
>>
>> diff --git a/drivers/clk/qcom/gcc-msm8916.c b/drivers/clk/qcom/gcc-msm8916.c
>> index e3bf09d..1ec5a27 100644
>> --- a/drivers/clk/qcom/gcc-msm8916.c
>> +++ b/drivers/clk/qcom/gcc-msm8916.c
>> @@ -2590,6 +2590,23 @@ static struct clk_branch gcc_mss_cfg_ahb_clk = {
>>   	},
>>   };
>>
>> +static struct clk_branch gcc_mss_q6_bimc_axi_clk = {
>> +	.halt_reg = 0x49004,
>> +	.clkr = {
>> +		.enable_reg = 0x49004,
>> +		.enable_mask = BIT(0),
>> +		.hw.init = &(struct clk_init_data){
>> +			.name = "gcc_mss_q6_bimc_axi_clk",
>> +			.parent_names = (const char *[]){
>> +				"pcnoc_bfdcd_clk_src",
>
> Looks like the parent should be bimc_ddr_clk_src.
> Otherwise looks fine to me.

Thanks for review, I will fix it and send v2.

--srini
>
> BR,
> Georgi
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web