Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1291595 > unrolled thread

Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some  codes improvement Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-14 22:40 +0100
    Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes  improvement Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> - 2015-12-15 06:50 +0100

#1291595 — Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement

On Wed, Nov 25, 2015 at 07:18:37PM +0800, xinhui wrote:
> From: xinhui <xinhui@linux.vnet.ibm.com>
> 
> If gsm driver fails to activate one mux, and this mux is not stored in
> gsm_mux[], there would be a warning in gsm_cleanup_mux(). Actually this
> is a legal case. So just do a simple check instead of WARN_ON.
> 
> There is one filed gsm->num to store its index of gsm_mux[]. So use
> gsm->num to remove itself from gsm_mux[] instead of the for-loop
> traverse.
> 
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Fixes: 5a64096700dc ("tty/n_gsm.c: fix a memory leak in gsmld_open")
> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>

the signed-off-by name has to match your from: name :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1291862 — Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement

Hi, Greg
	This patch is dropped, I have created another patch based on Jiri' patch.
On 2015/12/15 02:55, Greg Kroah-Hartman wrote:
> On Wed, Nov 25, 2015 at 07:18:37PM +0800, xinhui wrote:
>> From: xinhui <xinhui@linux.vnet.ibm.com>
>>
>> If gsm driver fails to activate one mux, and this mux is not stored in
>> gsm_mux[], there would be a warning in gsm_cleanup_mux(). Actually this
>> is a legal case. So just do a simple check instead of WARN_ON.
>>
>> There is one filed gsm->num to store its index of gsm_mux[]. So use
>> gsm->num to remove itself from gsm_mux[] instead of the for-loop
>> traverse.
>>
>> Reported-by: Dmitry Vyukov <dvyukov@google.com>
>> Fixes: 5a64096700dc ("tty/n_gsm.c: fix a memory leak in gsmld_open")
>> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
>
> the signed-off-by name has to match your from: name :(
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web