Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1289320 > unrolled thread

[PATCH] scsi_dh_alua: fix build warning

Started bySudip Mukherjee <sudipm.mukherjee@gmail.com>
First post2015-12-11 09:40 +0100
Last post2015-12-11 09:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] scsi_dh_alua: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-11 09:40 +0100
    Re: [PATCH] scsi_dh_alua: fix build warning Hannes Reinecke <hare@suse.de> - 2015-12-11 09:40 +0100

#1289320 — [PATCH] scsi_dh_alua: fix build warning

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2015-12-11 09:40 +0100
Subject[PATCH] scsi_dh_alua: fix build warning
Message-ID<qErp7-1Ja-7@gated-at.bofh.it>
We were getting build warning about unused variables "vpd_pg83" and "d"

Fixes: 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()")
Cc: Hannes Reinecke <hare@suse.de>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
build warning with next-20151211 and build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/96209206
---

 drivers/scsi/device_handler/scsi_dh_alua.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index f100cbb..5a328bf 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -320,8 +320,6 @@ static int alua_check_tpgs(struct scsi_device *sdev)
  */
 static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h)
 {
-	unsigned char *d;
-	unsigned char __rcu *vpd_pg83;
 	int rel_port = -1, group_id;
 
 	group_id = scsi_vpd_tpg_id(sdev, &rel_port);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1289321

FromHannes Reinecke <hare@suse.de>
Date2015-12-11 09:40 +0100
Message-ID<qErp8-1Ja-13@gated-at.bofh.it>
In reply to#1289320
On 12/11/2015 09:36 AM, Sudip Mukherjee wrote:
> We were getting build warning about unused variables "vpd_pg83" and "d"
>
> Fixes: 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()")
> Cc: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> build warning with next-20151211 and build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/96209206
> ---
>
>   drivers/scsi/device_handler/scsi_dh_alua.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index f100cbb..5a328bf 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -320,8 +320,6 @@ static int alua_check_tpgs(struct scsi_device *sdev)
>    */
>   static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h)
>   {
> -	unsigned char *d;
> -	unsigned char __rcu *vpd_pg83;
>   	int rel_port = -1, group_id;
>
>   	group_id = scsi_vpd_tpg_id(sdev, &rel_port);
>
A fix for this is already queued in Martin Petersens tree.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web