Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1285290 > unrolled thread
| Started by | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| First post | 2015-12-07 14:20 +0100 |
| Last post | 2015-12-10 21:20 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] arm: dts: berlin: fix BG2Q sdhci clk Jisheng Zhang <jszhang@marvell.com> - 2015-12-07 14:20 +0100
[PATCH 2/2] ARM: dts: berlin: add 2nd clock for BG2Q sdhci0 and sdhci1 Jisheng Zhang <jszhang@marvell.com> - 2015-12-07 14:20 +0100
[PATCH 1/2] ARM: dts: berlin: correct BG2Q's sdhci2 2nd clock Jisheng Zhang <jszhang@marvell.com> - 2015-12-07 14:20 +0100
Re: [PATCH 0/2] arm: dts: berlin: fix BG2Q sdhci clk Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-12-10 21:20 +0100
| From | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| Date | 2015-12-07 14:20 +0100 |
| Subject | [PATCH 0/2] arm: dts: berlin: fix BG2Q sdhci clk |
| Message-ID | <qD3RT-4Wd-1@gated-at.bofh.it> |
CLKID_SDIO is used as the 2nd optional clk for all sdhci hosts in BG2Q. We removed CLK_IGNORE_UNUSED from CLKID_SDIO's flag. These two patches fixes this clk issue. Jisheng Zhang (2): ARM: dts: berlin: correct BG2Q's sdhci2 2nd clock ARM: dts: berlin: add 2nd clock for BG2Q sdhci0 and sdhci1 arch/arm/boot/dts/berlin2q.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| Date | 2015-12-07 14:20 +0100 |
| Subject | [PATCH 2/2] ARM: dts: berlin: add 2nd clock for BG2Q sdhci0 and sdhci1 |
| Message-ID | <qD3RT-4Wd-5@gated-at.bofh.it> |
| In reply to | #1285290 |
We removed CLK_IGNORE_UNUSED from CLKID_SDIO's flag, so the sdhci0 and
sdhci1 don't work. We fix this by adding the optional 2nd clock for
BG2Q's sdhci0 and sdhci1. This patch brings another benefit: the 2nd
clock can be disabled during runtime pm, so saves power a bit.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
arch/arm/boot/dts/berlin2q.dtsi | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 5b10129..fb1da99 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -118,7 +118,8 @@
sdhci0: sdhci@ab0000 {
compatible = "mrvl,pxav3-mmc";
reg = <0xab0000 0x200>;
- clocks = <&chip_clk CLKID_SDIO1XIN>;
+ clocks = <&chip_clk CLKID_SDIO1XIN>, <&chip_clk CLKID_SDIO>;
+ clock-names = "io", "core";
interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
@@ -126,7 +127,8 @@
sdhci1: sdhci@ab0800 {
compatible = "mrvl,pxav3-mmc";
reg = <0xab0800 0x200>;
- clocks = <&chip_clk CLKID_SDIO1XIN>;
+ clocks = <&chip_clk CLKID_SDIO1XIN>, <&chip_clk CLKID_SDIO>;
+ clock-names = "io", "core";
interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
--
2.6.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| Date | 2015-12-07 14:20 +0100 |
| Subject | [PATCH 1/2] ARM: dts: berlin: correct BG2Q's sdhci2 2nd clock |
| Message-ID | <qD3RU-4Wd-23@gated-at.bofh.it> |
| In reply to | #1285290 |
The optional 2nd clock is CLKID_SDIO. We removed CLK_IGNORE_UNUSED from CLKID_SDIO's flag, so the sdhci2 doesn't work. This patch fixes this issue by correcting the sdhci2's 2nd clock. Signed-off-by: Jisheng Zhang <jszhang@marvell.com> --- arch/arm/boot/dts/berlin2q.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi index 8ea177f..5b10129 100644 --- a/arch/arm/boot/dts/berlin2q.dtsi +++ b/arch/arm/boot/dts/berlin2q.dtsi @@ -135,7 +135,7 @@ compatible = "mrvl,pxav3-mmc"; reg = <0xab1000 0x200>; interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&chip_clk CLKID_NFC_ECC>, <&chip_clk CLKID_NFC>; + clocks = <&chip_clk CLKID_NFC_ECC>, <&chip_clk CLKID_SDIO>; clock-names = "io", "core"; status = "disabled"; }; -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> |
|---|---|
| Date | 2015-12-10 21:20 +0100 |
| Message-ID | <qEfR0-2uZ-5@gated-at.bofh.it> |
| In reply to | #1285290 |
On 07.12.2015 14:09, Jisheng Zhang wrote: > CLKID_SDIO is used as the 2nd optional clk for all sdhci hosts in BG2Q. > We removed CLK_IGNORE_UNUSED from CLKID_SDIO's flag. These two patches > fixes this clk issue. > > Jisheng Zhang (2): > ARM: dts: berlin: correct BG2Q's sdhci2 2nd clock > ARM: dts: berlin: add 2nd clock for BG2Q sdhci0 and sdhci1 > > arch/arm/boot/dts/berlin2q.dtsi | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > Series applied to berlin/fixes. Thanks! Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web