Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1288684 > unrolled thread

Re: [PATCH v7 0/4] usb/gadget: independent registration of gadgets and gadget drivers

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v7 0/4] usb/gadget: independent registration of gadgets and gadget drivers Felipe Balbi <balbi@ti.com> - 2015-12-10 18:10 +0100
    Re: [PATCH v7 0/4] usb/gadget: independent registration of gadgets and gadget drivers Felipe Balbi <balbi@ti.com> - 2015-12-10 18:10 +0100
      Re: [PATCH v7 0/4] usb/gadget: independent registration of gadgets and gadget drivers Felipe Balbi <balbi@ti.com> - 2015-12-10 18:20 +0100
        Re: [PATCH v7 0/4] usb/gadget: independent registration of gadgets and  gadget drivers Marek Szyprowski <m.szyprowski@samsung.com> - 2015-12-11 10:40 +0100

#1288684 — Re: [PATCH v7 0/4] usb/gadget: independent registration of gadgets and gadget drivers

[Multipart message — attachments visible in raw view] — view raw

Hi,

Marek Szyprowski <m.szyprowski@samsung.com> writes:
> Hello,
>
> This is a resurrection of the patches initially submitted by Ruslan
> Bilovol in the following thread: https://lkml.org/lkml/2015/6/22/554
>
> The changes since the original submission (v5) includes rebase onto
> latest linux-next branch, simplification of the code requested by Alan
> Stern and Felipe Balbi, removal of a patch, which deleted __init/__exit
> attributes (this change has been already merged) and fixes of the
> checkpatch issues.
>
> This feature is urgently needed, because it is not longer possible to
> use workaround to avoid deferred probe in UDC drivers due to
> not-yet-probed i2c regulator drivers (for more information see
> https://lkml.org/lkml/2015/10/30/374 ).
>
> This patchset has been successfully tested on Odroid XU3 boards with
> DWC3 UDC driver being deferred by missing regulator drivers.

there is one problem with this patchset. If I try to statically link
gadget drivers, only one can be chosen, even though I can enable both
dwc3 and dummy_hcd just fine. And, actually, this brings another
problem. How do we handle systems which have 2 USB peripheral
controllers (say, 2 instances of dwc3) and choose which gadget driver
will bind to which controller ?

-- 
balbi

[toc] | [next] | [standalone]

#1288685

[Multipart message — attachments visible in raw view] — view raw

Hi,

Felipe Balbi <balbi@ti.com> writes:
> Marek Szyprowski <m.szyprowski@samsung.com> writes:
>> Hello,
>>
>> This is a resurrection of the patches initially submitted by Ruslan
>> Bilovol in the following thread: https://lkml.org/lkml/2015/6/22/554
>>
>> The changes since the original submission (v5) includes rebase onto
>> latest linux-next branch, simplification of the code requested by Alan
>> Stern and Felipe Balbi, removal of a patch, which deleted __init/__exit
>> attributes (this change has been already merged) and fixes of the
>> checkpatch issues.
>>
>> This feature is urgently needed, because it is not longer possible to
>> use workaround to avoid deferred probe in UDC drivers due to
>> not-yet-probed i2c regulator drivers (for more information see
>> https://lkml.org/lkml/2015/10/30/374 ).
>>
>> This patchset has been successfully tested on Odroid XU3 boards with
>> DWC3 UDC driver being deferred by missing regulator drivers.
>
> there is one problem with this patchset. If I try to statically link
> gadget drivers, only one can be chosen, even though I can enable both
> dwc3 and dummy_hcd just fine. And, actually, this brings another
> problem. How do we handle systems which have 2 USB peripheral
> controllers (say, 2 instances of dwc3) and choose which gadget driver
> will bind to which controller ?

We also seem to have issues with Kconfig. If I try to make gadget driver
built-in, when compiling I'll get asked again if I want gadget drivers
built-in.

Another one: I just tried dummy_hcd built-in, g_zero built-in, dwc3 as a
module. I can never load anything to dwc3 ;-)

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1288698

[Multipart message — attachments visible in raw view] — view raw

Hi,

Felipe Balbi <balbi@ti.com> writes:
> Felipe Balbi <balbi@ti.com> writes:
>> Marek Szyprowski <m.szyprowski@samsung.com> writes:
>>> Hello,
>>>
>>> This is a resurrection of the patches initially submitted by Ruslan
>>> Bilovol in the following thread: https://lkml.org/lkml/2015/6/22/554
>>>
>>> The changes since the original submission (v5) includes rebase onto
>>> latest linux-next branch, simplification of the code requested by Alan
>>> Stern and Felipe Balbi, removal of a patch, which deleted __init/__exit
>>> attributes (this change has been already merged) and fixes of the
>>> checkpatch issues.
>>>
>>> This feature is urgently needed, because it is not longer possible to
>>> use workaround to avoid deferred probe in UDC drivers due to
>>> not-yet-probed i2c regulator drivers (for more information see
>>> https://lkml.org/lkml/2015/10/30/374 ).
>>>
>>> This patchset has been successfully tested on Odroid XU3 boards with
>>> DWC3 UDC driver being deferred by missing regulator drivers.
>>
>> there is one problem with this patchset. If I try to statically link
>> gadget drivers, only one can be chosen, even though I can enable both
>> dwc3 and dummy_hcd just fine. And, actually, this brings another
>> problem. How do we handle systems which have 2 USB peripheral
>> controllers (say, 2 instances of dwc3) and choose which gadget driver
>> will bind to which controller ?
>
> We also seem to have issues with Kconfig. If I try to make gadget driver
> built-in, when compiling I'll get asked again if I want gadget drivers
> built-in.
>
> Another one: I just tried dummy_hcd built-in, g_zero built-in, dwc3 as a
> module. I can never load anything to dwc3 ;-)

In all fairness, none of these are regressions. Can we agree to look at
these during v4.5-rc so maybe v4.6 has a final solution ?

cheers

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1289361 — Re: [PATCH v7 0/4] usb/gadget: independent registration of gadgets and gadget drivers

Hello,

On 2015-12-10 18:13, Felipe Balbi wrote:
> Felipe Balbi <balbi@ti.com> writes:
>> Felipe Balbi <balbi@ti.com> writes:
>>> Marek Szyprowski <m.szyprowski@samsung.com> writes:
>>>> This is a resurrection of the patches initially submitted by Ruslan
>>>> Bilovol in the following thread: https://lkml.org/lkml/2015/6/22/554
>>>>
>>>> The changes since the original submission (v5) includes rebase onto
>>>> latest linux-next branch, simplification of the code requested by Alan
>>>> Stern and Felipe Balbi, removal of a patch, which deleted __init/__exit
>>>> attributes (this change has been already merged) and fixes of the
>>>> checkpatch issues.
>>>>
>>>> This feature is urgently needed, because it is not longer possible to
>>>> use workaround to avoid deferred probe in UDC drivers due to
>>>> not-yet-probed i2c regulator drivers (for more information see
>>>> https://lkml.org/lkml/2015/10/30/374 ).
>>>>
>>>> This patchset has been successfully tested on Odroid XU3 boards with
>>>> DWC3 UDC driver being deferred by missing regulator drivers.
>>> there is one problem with this patchset. If I try to statically link
>>> gadget drivers, only one can be chosen, even though I can enable both
>>> dwc3 and dummy_hcd just fine. And, actually, this brings another
>>> problem. How do we handle systems which have 2 USB peripheral
>>> controllers (say, 2 instances of dwc3) and choose which gadget driver
>>> will bind to which controller ?
>> We also seem to have issues with Kconfig. If I try to make gadget driver
>> built-in, when compiling I'll get asked again if I want gadget drivers
>> built-in.
>>
>> Another one: I just tried dummy_hcd built-in, g_zero built-in, dwc3 as a
>> module. I can never load anything to dwc3 ;-)
> In all fairness, none of these are regressions. Can we agree to look at
> these during v4.5-rc so maybe v4.6 has a final solution ?

IMHO solving all the above issues requires reviving one of the previously
abandoned gadget-bus patch series, i.e.
http://thread.gmane.org/gmane.linux.usb.general/109745

Is this an approach You are interested in?

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web