Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1290203 > unrolled thread
| Started by | Benjamin Young <youngcdev@gmail.com> |
|---|---|
| First post | 2015-12-12 15:50 +0100 |
| Last post | 2015-12-12 16:10 +0100 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH] staging: netlogic: Coding Style Fix Comparison to NULL could be written with ! Benjamin Young <youngcdev@gmail.com> - 2015-12-12 15:50 +0100
Re: [PATCH] staging: netlogic: Coding Style Fix Comparison to NULL could be written with ! Benjamin Young <youngcdev@gmail.com> - 2015-12-12 16:10 +0100
| From | Benjamin Young <youngcdev@gmail.com> |
|---|---|
| Date | 2015-12-12 15:50 +0100 |
| Subject | [PATCH] staging: netlogic: Coding Style Fix Comparison to NULL could be written with ! |
| Message-ID | <qETEJ-3og-13@gated-at.bofh.it> |
Fixed coding style for null comparisons in netlogic driver to be more consistant
with the rest of the kernel coding style
Signed-off-by: Benjamin Young <youngcdev@gmail.com>
---
drivers/staging/netlogic/xlr_net.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
index 8ae0175..ac93e63 100644
--- a/drivers/staging/netlogic/xlr_net.c
+++ b/drivers/staging/netlogic/xlr_net.c
@@ -147,7 +147,7 @@ static void xlr_net_fmn_handler(int bkt, int src_stnid, int size,
addr = addr - MAC_SKB_BACK_PTR_SIZE;
skb = (struct sk_buff *) *(unsigned long *)addr;
skb->dev = adapter->netdev[port];
- if (skb->dev == NULL)
+ if (!skb->dev)
return;
ndev = skb->dev;
priv = netdev_priv(ndev);
@@ -878,7 +878,7 @@ static int xlr_setup_mdio(struct xlr_net_priv *priv,
priv->mii_bus->write = xlr_mii_write;
priv->mii_bus->parent = &pdev->dev;
priv->mii_bus->irq = kmalloc(sizeof(int)*PHY_MAX_ADDR, GFP_KERNEL);
- if (priv->mii_bus->irq == NULL) {
+ if (!priv->mii_bus->irq) {
pr_err("irq alloc failed\n");
mdiobus_free(priv->mii_bus);
return -ENOMEM;
@@ -1037,7 +1037,7 @@ static int xlr_net_probe(struct platform_device *pdev)
priv->nd = (struct xlr_net_data *)pdev->dev.platform_data;
res = platform_get_resource(pdev, IORESOURCE_MEM, port);
- if (res == NULL) {
+ if (!res) {
pr_err("No memory resource for MAC %d\n",
priv->port_id);
err = -ENODEV;
@@ -1052,7 +1052,7 @@ static int xlr_net_probe(struct platform_device *pdev)
adapter->netdev[port] = ndev;
res = platform_get_resource(pdev, IORESOURCE_IRQ, port);
- if (res == NULL) {
+ if (!res) {
pr_err("No irq resource for MAC %d\n", priv->port_id);
err = -ENODEV;
goto err_gmac;
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Benjamin Young <youngcdev@gmail.com> |
|---|---|
| Date | 2015-12-12 16:10 +0100 |
| Subject | Re: [PATCH] staging: netlogic: Coding Style Fix Comparison to NULL could be written with ! |
| Message-ID | <qETY6-3K6-9@gated-at.bofh.it> |
| In reply to | #1290203 |
On Sat, Dec 12, 2015 at 06:45:59AM -0800, Benjamin Young wrote:
> Fixed coding style for null comparisons in netlogic driver to be more consistant
> with the rest of the kernel coding style
>
> Signed-off-by: Benjamin Young <youngcdev@gmail.com>
> ---
> drivers/staging/netlogic/xlr_net.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
> index 8ae0175..ac93e63 100644
> --- a/drivers/staging/netlogic/xlr_net.c
> +++ b/drivers/staging/netlogic/xlr_net.c
> @@ -147,7 +147,7 @@ static void xlr_net_fmn_handler(int bkt, int src_stnid, int size,
> addr = addr - MAC_SKB_BACK_PTR_SIZE;
> skb = (struct sk_buff *) *(unsigned long *)addr;
> skb->dev = adapter->netdev[port];
> - if (skb->dev == NULL)
> + if (!skb->dev)
> return;
> ndev = skb->dev;
> priv = netdev_priv(ndev);
> @@ -878,7 +878,7 @@ static int xlr_setup_mdio(struct xlr_net_priv *priv,
> priv->mii_bus->write = xlr_mii_write;
> priv->mii_bus->parent = &pdev->dev;
> priv->mii_bus->irq = kmalloc(sizeof(int)*PHY_MAX_ADDR, GFP_KERNEL);
> - if (priv->mii_bus->irq == NULL) {
> + if (!priv->mii_bus->irq) {
> pr_err("irq alloc failed\n");
> mdiobus_free(priv->mii_bus);
> return -ENOMEM;
> @@ -1037,7 +1037,7 @@ static int xlr_net_probe(struct platform_device *pdev)
> priv->nd = (struct xlr_net_data *)pdev->dev.platform_data;
> res = platform_get_resource(pdev, IORESOURCE_MEM, port);
>
> - if (res == NULL) {
> + if (!res) {
> pr_err("No memory resource for MAC %d\n",
> priv->port_id);
> err = -ENODEV;
> @@ -1052,7 +1052,7 @@ static int xlr_net_probe(struct platform_device *pdev)
> adapter->netdev[port] = ndev;
>
> res = platform_get_resource(pdev, IORESOURCE_IRQ, port);
> - if (res == NULL) {
> + if (!res) {
> pr_err("No irq resource for MAC %d\n", priv->port_id);
> err = -ENODEV;
> goto err_gmac;
> --
> 2.5.0
>
Adding broadcom engineers. (Sorry did not see these adresses in the TODO file origionally)
Thanks,
Benjamin Young
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web