Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1289847 > unrolled thread

[PATCH] wan: wanxl: add pci_disable_device in case of error

Started bySaurabh Sengar <saurabh.truth@gmail.com>
First post2015-12-11 20:30 +0100
Last post2015-12-14 22:30 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] wan: wanxl: add pci_disable_device in case of error Saurabh Sengar <saurabh.truth@gmail.com> - 2015-12-11 20:30 +0100
    Re: [PATCH] wan: wanxl: add pci_disable_device in case of error David Miller <davem@davemloft.net> - 2015-12-14 22:30 +0100

#1289847 — [PATCH] wan: wanxl: add pci_disable_device in case of error

FromSaurabh Sengar <saurabh.truth@gmail.com>
Date2015-12-11 20:30 +0100
Subject[PATCH] wan: wanxl: add pci_disable_device in case of error
Message-ID<qEBya-ej-17@gated-at.bofh.it>
If there is 'no suitable DMA available' error, device should be disabled
before returning

Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
 drivers/net/wan/wanxl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
index e73f138..a20d688 100644
--- a/drivers/net/wan/wanxl.c
+++ b/drivers/net/wan/wanxl.c
@@ -586,6 +586,7 @@ static int wanxl_pci_init_one(struct pci_dev *pdev,
 	if (pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(28)) ||
 	    pci_set_dma_mask(pdev, DMA_BIT_MASK(28))) {
 		pr_err("No usable DMA configuration\n");
+		pci_disable_device(pdev);
 		return -EIO;
 	}
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1291589

FromDavid Miller <davem@davemloft.net>
Date2015-12-14 22:30 +0100
Message-ID<qFIQW-3c1-13@gated-at.bofh.it>
In reply to#1289847
From: Saurabh Sengar <saurabh.truth@gmail.com>
Date: Sat, 12 Dec 2015 00:58:19 +0530

> If there is 'no suitable DMA available' error, device should be disabled
> before returning
> 
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web