Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1288432 > unrolled thread

Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the  function call "kfree_skb" Stefan Schmidt <stefan@osg.samsung.com> - 2015-12-10 11:20 +0100
    Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb" Marcel Holtmann <marcel@holtmann.org> - 2015-12-10 19:20 +0100
      Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the  function call "kfree_skb" Stefan Schmidt <stefan@osg.samsung.com> - 2015-12-10 23:50 +0100
      Re: ieee802154-atusb: Delete an unnecessary check before the function  call "kfree_skb" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-11 14:10 +0100
        Re: ieee802154-atusb: Delete an unnecessary check before the function  call "kfree_skb" Stefan Schmidt <stefan@osg.samsung.com> - 2015-12-11 14:30 +0100

#1288432 — Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Marcel,

On 17/11/15 17:18, Stefan Schmidt wrote:
> Hello.
>
> On 17/11/15 17:17, Stefan Schmidt wrote:
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Mon, 16 Nov 2015 13:50:23 +0100
>>
>> The kfree_skb() function tests whether its argument is NULL and then
>> returns immediately. Thus the test around the call is not needed.
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>> ---
>>  drivers/net/ieee802154/atusb.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ieee802154/atusb.c 
>> b/drivers/net/ieee802154/atusb.c
>> index 199a94a..b1cd865 100644
>> --- a/drivers/net/ieee802154/atusb.c
>> +++ b/drivers/net/ieee802154/atusb.c
>> @@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb)
>>          urb = usb_get_from_anchor(&atusb->idle_urbs);
>>          if (!urb)
>>              break;
>> -        if (urb->context)
>> -            kfree_skb(urb->context);
>> +        kfree_skb(urb->context);
>>          usb_free_urb(urb);
>>      }
>>  }
>
> Acked-by: Stefan Schmidt <stefan@osg.samsung.com>


You got the original patch and my ACK on this one or would you prefer me 
to resend it again?

regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1288778 — Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Hi Stefan,

>>> From: Markus Elfring <elfring@users.sourceforge.net>
>>> Date: Mon, 16 Nov 2015 13:50:23 +0100
>>> 
>>> The kfree_skb() function tests whether its argument is NULL and then
>>> returns immediately. Thus the test around the call is not needed.
>>> 
>>> This issue was detected by using the Coccinelle software.
>>> 
>>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>>> ---
>>> drivers/net/ieee802154/atusb.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>> 
>>> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
>>> index 199a94a..b1cd865 100644
>>> --- a/drivers/net/ieee802154/atusb.c
>>> +++ b/drivers/net/ieee802154/atusb.c
>>> @@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb)
>>>         urb = usb_get_from_anchor(&atusb->idle_urbs);
>>>         if (!urb)
>>>             break;
>>> -        if (urb->context)
>>> -            kfree_skb(urb->context);
>>> +        kfree_skb(urb->context);
>>>         usb_free_urb(urb);
>>>     }
>>> }
>> 
>> Acked-by: Stefan Schmidt <stefan@osg.samsung.com>
> 
> 
> You got the original patch and my ACK on this one or would you prefer me to resend it again?

this slipped through, but now it does no longer apply.

Applying: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"
error: patch failed: drivers/net/ieee802154/atusb.c:310
error: drivers/net/ieee802154/atusb.c: patch does not apply
Patch failed at 0001 ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1288985

Hello.

On 10/12/15 19:16, Marcel Holtmann wrote:
> Hi Stefan,
>
>>>> From: Markus Elfring <elfring@users.sourceforge.net>
>>>> Date: Mon, 16 Nov 2015 13:50:23 +0100
>>>>
>>>> The kfree_skb() function tests whether its argument is NULL and then
>>>> returns immediately. Thus the test around the call is not needed.
>>>>
>>>> This issue was detected by using the Coccinelle software.
>>>>
>>>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>>>> ---
>>>> drivers/net/ieee802154/atusb.c | 3 +--
>>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
>>>> index 199a94a..b1cd865 100644
>>>> --- a/drivers/net/ieee802154/atusb.c
>>>> +++ b/drivers/net/ieee802154/atusb.c
>>>> @@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb)
>>>>          urb = usb_get_from_anchor(&atusb->idle_urbs);
>>>>          if (!urb)
>>>>              break;
>>>> -        if (urb->context)
>>>> -            kfree_skb(urb->context);
>>>> +        kfree_skb(urb->context);
>>>>          usb_free_urb(urb);
>>>>      }
>>>> }
>>> Acked-by: Stefan Schmidt <stefan@osg.samsung.com>
>>
>> You got the original patch and my ACK on this one or would you prefer me to resend it again?
> this slipped through, but now it does no longer apply.
>
> Applying: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"
> error: patch failed: drivers/net/ieee802154/atusb.c:310
> error: drivers/net/ieee802154/atusb.c: patch does not apply
> Patch failed at 0001 ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Not good. I did another resend, this one applied, compiled and worked 
fine for me. You will be in the to line.

regards
Stefan Schmidt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1289552 — Re: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

> this slipped through, but now it does no longer apply.
> 
> Applying: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"
> error: patch failed: drivers/net/ieee802154/atusb.c:310
> error: drivers/net/ieee802154/atusb.c: patch does not apply
> Patch failed at 0001 ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

How can this hiccup happen?

A command like the following is still working for me on source files
for the software "Linux next-20151211".

elfring@Sonne:~/Projekte/Linux/next-patched> git apply ~/Projekte/Bau/Linux/scripts/Coccinelle/deletions1/next/20151113/Flicken/0001-ieee802154-atusb-Delete-an-unnecessary-check-before.patch

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1289563 — Re: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Hello.

On 11/12/15 14:07, SF Markus Elfring wrote:
>> this slipped through, but now it does no longer apply.
>>
>> Applying: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"
>> error: patch failed: drivers/net/ieee802154/atusb.c:310
>> error: drivers/net/ieee802154/atusb.c: patch does not apply
>> Patch failed at 0001 ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"
> How can this hiccup happen?
>

I might have been a problem when I was resending your patch the first 
time as Marcel was not able to find the original one.

I have send it a second time now and it worked fine. The patch is 
already applied to the bluetooth-next tree and thus on its way. All good 
now.

https://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=4188146566a9f1d57dfce77fd9457f7304b69dfa

regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web