Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1287942 > unrolled thread
| Started by | "Geyslan G. Bem" <geyslan@gmail.com> |
|---|---|
| First post | 2015-12-09 23:40 +0100 |
| Last post | 2015-12-10 10:20 +0100 |
| Articles | 4 on this page of 24 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 1/9v2] usb: host: ehci.h: remove space before comma "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-09 23:40 +0100
[PATCH 3/9v2] usb: host: ehci.h: remove space before open square bracket "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-09 23:40 +0100
Re: [PATCH 3/9v2] usb: host: ehci.h: remove space before open square bracket Peter Senna Tschudin <peter.senna@gmail.com> - 2015-12-10 10:30 +0100
[PATCH 4/9v2] usb: host: ehci.h: fix single statement macros "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-09 23:40 +0100
Re: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros Peter Senna Tschudin <peter.senna@gmail.com> - 2015-12-10 11:00 +0100
Re: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-10 13:00 +0100
Re: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 13:30 +0100
Re: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 14:10 +0100
Re: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-10 15:50 +0100
Re: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 16:00 +0100
Re: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-10 18:30 +0100
Re: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-10 18:50 +0100
Re: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 19:10 +0100
Re: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 18:50 +0100
[PATCH 5/9v2] usb: host: ehci.h: remove direct use of __attribute__ keyword "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-09 23:40 +0100
Re: [PATCH 5/9v2] usb: host: ehci.h: remove direct use of __attribute__ keyword Peter Senna Tschudin <peter.senna@gmail.com> - 2015-12-10 11:10 +0100
Re: [PATCH 5/9v2] usb: host: ehci.h: remove direct use of __attribute__ keyword "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 11:30 +0100
[PATCH 7/9v2] usb: host: ehci.h: remove macros trailing semicolon "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-09 23:40 +0100
Re: [PATCH 7/9v2] usb: host: ehci.h: remove macros trailing semicolon Peter Senna Tschudin <peter.senna@gmail.com> - 2015-12-10 11:30 +0100
[PATCH 6/9v2] usb: host: ehci.h: use space after comma "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-09 23:40 +0100
Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma Peter Senna Tschudin <peter.senna@gmail.com> - 2015-12-10 11:20 +0100
Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma Alan Stern <stern@rowland.harvard.edu> - 2015-12-10 17:00 +0100
Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 17:10 +0100
Re: [PATCH 1/9v2] usb: host: ehci.h: remove space before comma Peter Senna Tschudin <peter.senna@gmail.com> - 2015-12-10 10:20 +0100
Page 2 of 2 — ← Prev page 1 [2]
| From | Peter Senna Tschudin <peter.senna@gmail.com> |
|---|---|
| Date | 2015-12-10 11:20 +0100 |
| Subject | Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma |
| Message-ID | <qE6ul-4PD-1@gated-at.bofh.it> |
| In reply to | #1287948 |
On Wed, Dec 09, 2015 at 07:32:35PM -0300, Geyslan G. Bem wrote:
> Put space after comma.
>
> This patch also changes QH_NEXT macro for better reading.
>
> Caught by checkpatch: "ERROR: space required after that ','"
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
> drivers/usb/host/ehci.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index 7b2b213..ea56147 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -334,7 +334,7 @@ struct ehci_qtd {
> /*-------------------------------------------------------------------------*/
>
> /* type tag from {qh,itd,sitd,fstn}->hw_next */
> -#define Q_NEXT_TYPE(ehci,dma) ((dma) & cpu_to_hc32(ehci, 3 << 1))
> +#define Q_NEXT_TYPE(ehci, dma) ((dma) & cpu_to_hc32(ehci, 3 << 1))
>
> /*
> * Now the following defines are not converted using the
> @@ -350,7 +350,8 @@ struct ehci_qtd {
> #define Q_TYPE_FSTN (3 << 1)
>
> /* next async queue entry, or pointer to interrupt/periodic QH */
> -#define QH_NEXT(ehci,dma) (cpu_to_hc32(ehci, (((u32)dma)&~0x01f)|Q_TYPE_QH))
> +#define QH_NEXT(ehci, dma) \
> + (cpu_to_hc32(ehci, (((u32) dma) & ~0x01f) | Q_TYPE_QH))
For the maintainers: Is having two lines here better than having a line with 83 chars?
>
> /* for periodic/async schedules and qtd lists, mark end of list */
> #define EHCI_LIST_END(ehci) cpu_to_hc32(ehci, 1) /* "null pointer" to hw */
> --
> 2.6.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Alan Stern <stern@rowland.harvard.edu> |
|---|---|
| Date | 2015-12-10 17:00 +0100 |
| Subject | Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma |
| Message-ID | <qEbNp-8az-17@gated-at.bofh.it> |
| In reply to | #1288426 |
On Thu, 10 Dec 2015, Peter Senna Tschudin wrote: > > /* next async queue entry, or pointer to interrupt/periodic QH */ > > -#define QH_NEXT(ehci,dma) (cpu_to_hc32(ehci, (((u32)dma)&~0x01f)|Q_TYPE_QH)) > > +#define QH_NEXT(ehci, dma) \ > > + (cpu_to_hc32(ehci, (((u32) dma) & ~0x01f) | Q_TYPE_QH)) > > For the maintainers: Is having two lines here better than having a line with 83 chars? Two lines is better. This patch is fine and so are the other 7 -- I never received 9/9v2 (the original 9/9 was okay). Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Geyslan G. Bem" <geyslan@gmail.com> |
|---|---|
| Date | 2015-12-10 17:10 +0100 |
| Subject | Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma |
| Message-ID | <qEbX4-8tz-13@gated-at.bofh.it> |
| In reply to | #1288624 |
2015-12-10 12:57 GMT-03:00 Alan Stern <stern@rowland.harvard.edu>: > On Thu, 10 Dec 2015, Peter Senna Tschudin wrote: > >> > /* next async queue entry, or pointer to interrupt/periodic QH */ >> > -#define QH_NEXT(ehci,dma) (cpu_to_hc32(ehci, (((u32)dma)&~0x01f)|Q_TYPE_QH)) >> > +#define QH_NEXT(ehci, dma) \ >> > + (cpu_to_hc32(ehci, (((u32) dma) & ~0x01f) | Q_TYPE_QH)) >> >> For the maintainers: Is having two lines here better than having a line with 83 chars? > > Two lines is better. This patch is fine and so are the other 7 -- I > never received 9/9v2 (the original 9/9 was okay). Alan, The 9 is v1 only, since it mentions the tool (coccinelle) correctly. Tks. > > Alan Stern > -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Peter Senna Tschudin <peter.senna@gmail.com> |
|---|---|
| Date | 2015-12-10 10:20 +0100 |
| Message-ID | <qE5yi-4b1-23@gated-at.bofh.it> |
| In reply to | #1287942 |
On Wed, Dec 09, 2015 at 07:32:30PM -0300, Geyslan G. Bem wrote: > Get rid of spaces before comma. > > Caught by checkpatch: "ERROR: space prohibited before that ','" > > Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> > --- It is a good idea to include here (after the ---) what changed from V1. Other than that: Acked-by: Peter Senna Tschudin <peter.senna@gmail.com> Not related to this patch, I did not receive patch 9/9v2. > drivers/usb/host/ehci.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h > index ec61aed..6a36ef4 100644 > --- a/drivers/usb/host/ehci.h > +++ b/drivers/usb/host/ehci.h > @@ -852,13 +852,13 @@ static inline u32 hc32_to_cpup (const struct ehci_hcd *ehci, const __hc32 *x) > /*-------------------------------------------------------------------------*/ > > #define ehci_dbg(ehci, fmt, args...) \ > - dev_dbg(ehci_to_hcd(ehci)->self.controller , fmt , ## args) > + dev_dbg(ehci_to_hcd(ehci)->self.controller, fmt, ## args) > #define ehci_err(ehci, fmt, args...) \ > - dev_err(ehci_to_hcd(ehci)->self.controller , fmt , ## args) > + dev_err(ehci_to_hcd(ehci)->self.controller, fmt, ## args) > #define ehci_info(ehci, fmt, args...) \ > - dev_info(ehci_to_hcd(ehci)->self.controller , fmt , ## args) > + dev_info(ehci_to_hcd(ehci)->self.controller, fmt, ## args) > #define ehci_warn(ehci, fmt, args...) \ > - dev_warn(ehci_to_hcd(ehci)->self.controller , fmt , ## args) > + dev_warn(ehci_to_hcd(ehci)->self.controller, fmt, ## args) > > > #ifndef CONFIG_DYNAMIC_DEBUG > -- > 2.6.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Page 2 of 2 — ← Prev page 1 [2]
Back to top | Article view | linux.kernel
csiph-web