Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1288184 > unrolled thread
| Started by | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| First post | 2015-12-10 05:10 +0100 |
| Last post | 2015-12-11 15:00 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data Vinod Koul <vinod.koul@intel.com> - 2015-12-10 05:10 +0100
RE: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data "Wang, Annie" <Annie.Wang@amd.com> - 2015-12-10 07:40 +0100
Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data Vinod Koul <vinod.koul@intel.com> - 2015-12-11 10:30 +0100
Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-11 15:00 +0100
| From | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| Date | 2015-12-10 05:10 +0100 |
| Subject | Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data |
| Message-ID | <qE0Ih-11h-11@gated-at.bofh.it> |
On Fri, Dec 04, 2015 at 11:24:21AM +0800, Wang Hongcheng wrote:
> has_no_cap_mask means this device has no preset cap mask.
> mcbuf_sz means bytes to allocate for MC buffer.
MC ?
> flags is for irq sharing, default is non-shared, in AMD
> Carrizo, pl330 shares IRQ with its corresponding UART device.
>
> Signed-off-by: Wang Hongcheng <annie.wang@amd.com>
> ---
> drivers/acpi/acpi_apd.c | 13 ++++++++++++-
> drivers/dma/pl330.c | 19 +++++++++++++------
> include/linux/amba/pl330.h | 3 +++
> 3 files changed, 28 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index eb3316a..7a582f5 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -21,6 +21,7 @@
> #include <linux/amba/bus.h>
> #include <linux/kernel.h>
> #include <linux/sizes.h>
> +#include <linux/amba/pl330.h>
> #include <linux/interrupt.h>
>
> #include "internal.h"
> @@ -35,6 +36,16 @@ struct apd_private_data;
> #define ACPI_APD_SYSFS BIT(0)
> #define ACPI_APD_PM BIT(1)
>
> +static u8 peri_id[2] = { 0, 1 };
> +
> +static struct dma_pl330_platdata amd_pl330 = {
> + .nr_valid_peri = 2,
> + .peri_id = peri_id,
> + .has_no_cap_mask = true,
> + .mcbuf_sz = 0,
> + .flags = IRQF_SHARED,
> +};
Why not DT or ACPI for this?
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Wang, Annie" <Annie.Wang@amd.com> |
|---|---|
| Date | 2015-12-10 07:40 +0100 |
| Message-ID | <qE33r-2pm-5@gated-at.bofh.it> |
| In reply to | #1288184 |
>-----Original Message-----
>From: Vinod Koul [mailto:vinod.koul@intel.com]
>Sent: Thursday, December 10, 2015 12:09 PM
>To: Wang, Annie
>Cc: Mika Westerberg; Joerg Roedel; Greg Kroah-Hartman; Rafael J. Wysocki;
>linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
>serial@vger.kernel.org; dmaengine@vger.kernel.org; iommu@lists.linux-
>foundation.org; Borislav Petkov; Huang, Ray; Wan, Vincent; Xue, Ken; Li, Tony
>Subject: Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data
>
>On Fri, Dec 04, 2015 at 11:24:21AM +0800, Wang Hongcheng wrote:
>> has_no_cap_mask means this device has no preset cap mask.
>> mcbuf_sz means bytes to allocate for MC buffer.
>
>MC ?
Size of MicroCode buffers for each channel. I will update the comment.
>> flags is for irq sharing, default is non-shared, in AMD Carrizo, pl330
>> shares IRQ with its corresponding UART device.
>>
>> Signed-off-by: Wang Hongcheng <annie.wang@amd.com>
>> ---
>> drivers/acpi/acpi_apd.c | 13 ++++++++++++-
>> drivers/dma/pl330.c | 19 +++++++++++++------
>> include/linux/amba/pl330.h | 3 +++
>> 3 files changed, 28 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index
>> eb3316a..7a582f5 100644
>> --- a/drivers/acpi/acpi_apd.c
>> +++ b/drivers/acpi/acpi_apd.c
>> @@ -21,6 +21,7 @@
>> #include <linux/amba/bus.h>
>> #include <linux/kernel.h>
>> #include <linux/sizes.h>
>> +#include <linux/amba/pl330.h>
>> #include <linux/interrupt.h>
>>
>> #include "internal.h"
>> @@ -35,6 +36,16 @@ struct apd_private_data;
>> #define ACPI_APD_SYSFS BIT(0)
>> #define ACPI_APD_PM BIT(1)
>>
>> +static u8 peri_id[2] = { 0, 1 };
>> +
>> +static struct dma_pl330_platdata amd_pl330 = {
>> + .nr_valid_peri = 2,
>> + .peri_id = peri_id,
>> + .has_no_cap_mask = true,
>> + .mcbuf_sz = 0,
>> + .flags = IRQF_SHARED,
>> +};
>
>Why not DT or ACPI for this?
>
>--
>~Vinod
We choose to use private data, as pl330 already has struct dma_pl330_platdata.
Physically DMA share ACPI device with UART, however, BIOS believes DMA and UART is one device.
We can't get irq share info from ACPI. And we don't use DT.
Regards,
Annie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| Date | 2015-12-11 10:30 +0100 |
| Message-ID | <qEsbw-2gC-11@gated-at.bofh.it> |
| In reply to | #1288228 |
On Thu, Dec 10, 2015 at 06:38:09AM +0000, Wang, Annie wrote: > > > >Why not DT or ACPI for this? > > > We choose to use private data, as pl330 already has struct dma_pl330_platdata. > Physically DMA share ACPI device with UART, however, BIOS believes DMA and UART is one device. > We can't get irq share info from ACPI. And we don't use DT. > That should be then a MFD device -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2015-12-11 15:00 +0100 |
| Subject | Re: [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data |
| Message-ID | <qEwoP-5c5-21@gated-at.bofh.it> |
| In reply to | #1289356 |
On Fri, Dec 11, 2015 at 11:29 AM, Vinod Koul <vinod.koul@intel.com> wrote: > On Thu, Dec 10, 2015 at 06:38:09AM +0000, Wang, Annie wrote: >> > >> >Why not DT or ACPI for this? >> > >> We choose to use private data, as pl330 already has struct dma_pl330_platdata. >> Physically DMA share ACPI device with UART, however, BIOS believes DMA and UART is one device. >> We can't get irq share info from ACPI. And we don't use DT. >> > That should be then a MFD device And for me seems like acpi_amba and drivers shall utilize unified device property API. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web