Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1285230 > unrolled thread
| Started by | Lee Jones <lee.jones@linaro.org> |
|---|---|
| First post | 2015-12-07 13:00 +0100 |
| Last post | 2015-12-08 16:50 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 09/19] mfd: arizona-core: msleep() is unreliable for anything <20ms use usleep_range() instead Lee Jones <lee.jones@linaro.org> - 2015-12-07 13:00 +0100
Re: [PATCH 09/19] mfd: arizona-core: msleep() is unreliable for anything <20ms use usleep_range() instead Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-12-08 15:40 +0100
Re: [PATCH 09/19] mfd: arizona-core: msleep() is unreliable for anything <20ms use usleep_range() instead Lee Jones <lee.jones@linaro.org> - 2015-12-08 16:50 +0100
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-12-07 13:00 +0100 |
| Subject | [PATCH 09/19] mfd: arizona-core: msleep() is unreliable for anything <20ms use usleep_range() instead |
| Message-ID | <qD2Cu-3Yl-9@gated-at.bofh.it> |
WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt + msleep(1); WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt + msleep(5); WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt + msleep(1); WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt + msleep(1); total: 0 errors, 4 warnings, 1407 lines checked Cc: patches@opensource.wolfsonmicro.com Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/mfd/arizona-core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 44cfdbb..ceba17ca 100644 --- a/drivers/mfd/arizona-core.c +++ b/drivers/mfd/arizona-core.c @@ -239,7 +239,7 @@ static int arizona_poll_reg(struct arizona *arizona, if ((val & mask) == target) return 0; - msleep(1); + usleep_range(1000, 5000); } dev_err(arizona->dev, "Polling reg %u timed out: %x\n", reg, val); @@ -280,14 +280,14 @@ static void arizona_disable_reset(struct arizona *arizona) case WM5110: case WM8280: /* Meet requirements for minimum reset duration */ - msleep(5); + usleep_range(5000, 10000); break; default: break; } gpio_set_value_cansleep(arizona->pdata.reset, 1); - msleep(1); + usleep_range(1000, 5000); } } @@ -1045,7 +1045,7 @@ int arizona_dev_init(struct arizona *arizona) goto err_reset; } - msleep(1); + usleep_range(1000, 5000); } /* Ensure device startup is complete */ -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> |
|---|---|
| Date | 2015-12-08 15:40 +0100 |
| Subject | Re: [PATCH 09/19] mfd: arizona-core: msleep() is unreliable for anything <20ms use usleep_range() instead |
| Message-ID | <qDrAS-3yq-41@gated-at.bofh.it> |
| In reply to | #1285230 |
On Mon, Dec 07, 2015 at 11:50:22AM +0000, Lee Jones wrote: > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt > + msleep(1); > > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt > + msleep(5); > > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt > + msleep(1); > > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt > + msleep(1); > > total: 0 errors, 4 warnings, 1407 lines checked > > Cc: patches@opensource.wolfsonmicro.com > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- This doesn't actually appear to cc patches. But all looks good: Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-12-08 16:50 +0100 |
| Subject | Re: [PATCH 09/19] mfd: arizona-core: msleep() is unreliable for anything <20ms use usleep_range() instead |
| Message-ID | <qDsGB-4bA-11@gated-at.bofh.it> |
| In reply to | #1286547 |
On Tue, 08 Dec 2015, Charles Keepax wrote: > On Mon, Dec 07, 2015 at 11:50:22AM +0000, Lee Jones wrote: > > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt > > + msleep(1); > > > > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt > > + msleep(5); > > > > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt > > + msleep(1); > > > > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt > > + msleep(1); > > > > total: 0 errors, 4 warnings, 1407 lines checked > > > > Cc: patches@opensource.wolfsonmicro.com > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > This doesn't actually appear to cc patches. But all looks good: That's odd. I have no overrides in place and --[no-]signed-off-by-cc should default to --signed-off-by-cc. > > Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Ta -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web