Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1280263 > unrolled thread

[PATCH 1/5] dma: do not use 0x in front of %pad

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 1/5] dma: do not use 0x in front of %pad "Dmitry V. Krivenok" <krivenok.dmitry@gmail.com> - 2015-11-30 21:50 +0100
    Re: [PATCH 1/5] dma: do not use 0x in front of %pad Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-12-01 10:10 +0100
      Re: [PATCH 1/5] dma: do not use 0x in front of %pad Thierry Reding <thierry.reding@gmail.com> - 2015-12-08 15:50 +0100
        Re: [PATCH 1/5] dma: do not use 0x in front of %pad Vinod Koul <vinod.koul@intel.com> - 2015-12-08 17:50 +0100
    Re: [PATCH 1/5] dma: do not use 0x in front of %pad Vinod Koul <vinod.koul@intel.com> - 2015-12-05 12:00 +0100

#1280263 — [PATCH 1/5] dma: do not use 0x in front of %pad

Signed-off-by: Dmitry V. Krivenok <krivenok.dmitry@gmail.com>
---
 drivers/dma/at_hdmac_regs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
index 7f58f06..0474e4a 100644
--- a/drivers/dma/at_hdmac_regs.h
+++ b/drivers/dma/at_hdmac_regs.h
@@ -385,7 +385,7 @@ static void vdbg_dump_regs(struct at_dma_chan *atchan) {}
 static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
 {
 	dev_crit(chan2dev(&atchan->chan_common),
-		 "  desc: s%pad d%pad ctrl0x%x:0x%x l0x%pad\n",
+		 "  desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
 		 &lli->saddr, &lli->daddr,
 		 lli->ctrla, lli->ctrlb, &lli->dscr);
 }
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1280663

Le 30/11/2015 21:45, Dmitry V. Krivenok a écrit :
> Signed-off-by: Dmitry V. Krivenok <krivenok.dmitry@gmail.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
>  drivers/dma/at_hdmac_regs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> index 7f58f06..0474e4a 100644
> --- a/drivers/dma/at_hdmac_regs.h
> +++ b/drivers/dma/at_hdmac_regs.h
> @@ -385,7 +385,7 @@ static void vdbg_dump_regs(struct at_dma_chan *atchan) {}
>  static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
>  {
>  	dev_crit(chan2dev(&atchan->chan_common),
> -		 "  desc: s%pad d%pad ctrl0x%x:0x%x l0x%pad\n",
> +		 "  desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
>  		 &lli->saddr, &lli->daddr,
>  		 lli->ctrla, lli->ctrlb, &lli->dscr);
>  }
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1286556

[Multipart message — attachments visible in raw view] — view raw

On Tue, Dec 01, 2015 at 10:01:52AM +0100, Nicolas Ferre wrote:
> Le 30/11/2015 21:45, Dmitry V. Krivenok a écrit :
> > Signed-off-by: Dmitry V. Krivenok <krivenok.dmitry@gmail.com>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> 
> > ---
> >  drivers/dma/at_hdmac_regs.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> > index 7f58f06..0474e4a 100644
> > --- a/drivers/dma/at_hdmac_regs.h
> > +++ b/drivers/dma/at_hdmac_regs.h
> > @@ -385,7 +385,7 @@ static void vdbg_dump_regs(struct at_dma_chan *atchan) {}
> >  static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
> >  {
> >  	dev_crit(chan2dev(&atchan->chan_common),
> > -		 "  desc: s%pad d%pad ctrl0x%x:0x%x l0x%pad\n",
> > +		 "  desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
> >  		 &lli->saddr, &lli->daddr,
> >  		 lli->ctrla, lli->ctrlb, &lli->dscr);

Hi Vinod,

I think this ended up being misapplied, possibly because the patch
doesn't seem to have been based on something upstream. I got build
warnings during sanity builds of linux-next today and applied this
patch to fix them. Feel free to squash it into the original patch.

Thierry

--->8---
diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
index 610907dbc11a..0474e4a0f02a 100644
--- a/drivers/dma/at_hdmac_regs.h
+++ b/drivers/dma/at_hdmac_regs.h
@@ -386,8 +386,8 @@ static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
 {
 	dev_crit(chan2dev(&atchan->chan_common),
 		 "  desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
-		 lli->saddr, lli->daddr,
-		 lli->ctrla, lli->ctrlb, lli->dscr);
+		 &lli->saddr, &lli->daddr,
+		 lli->ctrla, lli->ctrlb, &lli->dscr);
 }

[toc] | [prev] | [next] | [standalone]

#1286682

[Multipart message — attachments visible in raw view] — view raw

On Tue, Dec 08, 2015 at 03:48:39PM +0100, Thierry Reding wrote:
> On Tue, Dec 01, 2015 at 10:01:52AM +0100, Nicolas Ferre wrote:
> > Le 30/11/2015 21:45, Dmitry V. Krivenok a écrit :
> > > Signed-off-by: Dmitry V. Krivenok <krivenok.dmitry@gmail.com>
> > 
> > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> > 
> > > ---
> > >  drivers/dma/at_hdmac_regs.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> > > index 7f58f06..0474e4a 100644
> > > --- a/drivers/dma/at_hdmac_regs.h
> > > +++ b/drivers/dma/at_hdmac_regs.h
> > > @@ -385,7 +385,7 @@ static void vdbg_dump_regs(struct at_dma_chan *atchan) {}
> > >  static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
> > >  {
> > >  	dev_crit(chan2dev(&atchan->chan_common),
> > > -		 "  desc: s%pad d%pad ctrl0x%x:0x%x l0x%pad\n",
> > > +		 "  desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
> > >  		 &lli->saddr, &lli->daddr,
> > >  		 lli->ctrla, lli->ctrlb, &lli->dscr);
> 
> Hi Vinod,
> 
> I think this ended up being misapplied, possibly because the patch
> doesn't seem to have been based on something upstream. I got build
> warnings during sanity builds of linux-next today and applied this
> patch to fix them. Feel free to squash it into the original patch.

I have dropped that one and pushed updated tree few moments back !

-- 
~Vinod

> 
> Thierry
> 
> --->8---
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> index 610907dbc11a..0474e4a0f02a 100644
> --- a/drivers/dma/at_hdmac_regs.h
> +++ b/drivers/dma/at_hdmac_regs.h
> @@ -386,8 +386,8 @@ static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
>  {
>  	dev_crit(chan2dev(&atchan->chan_common),
>  		 "  desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
> -		 lli->saddr, lli->daddr,
> -		 lli->ctrla, lli->ctrlb, lli->dscr);
> +		 &lli->saddr, &lli->daddr,
> +		 lli->ctrla, lli->ctrlb, &lli->dscr);
>  }

[toc] | [prev] | [next] | [standalone]

#1284522

On Mon, Nov 30, 2015 at 11:45:45PM +0300, Dmitry V. Krivenok wrote:

Applied, after fixing susystem name

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web