Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1284516 > unrolled thread
| Started by | Tomer Barletz <barletz@gmail.com> |
|---|---|
| First post | 2015-12-05 11:20 +0100 |
| Last post | 2015-12-09 15:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] netfilter: Initialize local variables to NULL, to prevent using them when uninitialized. Tomer Barletz <barletz@gmail.com> - 2015-12-05 11:20 +0100
Re: [PATCH] netfilter: Initialize local variables to NULL, to prevent using them when uninitialized. Pablo Neira Ayuso <pablo@netfilter.org> - 2015-12-09 15:00 +0100
| From | Tomer Barletz <barletz@gmail.com> |
|---|---|
| Date | 2015-12-05 11:20 +0100 |
| Subject | [PATCH] netfilter: Initialize local variables to NULL, to prevent using them when uninitialized. |
| Message-ID | <qCi6C-8bX-17@gated-at.bofh.it> |
Signed-off-by: Tomer Barletz <barletz@gmail.com> --- net/netfilter/nfnetlink_queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c index 7d81d28..e8be660 100644 --- a/net/netfilter/nfnetlink_queue.c +++ b/net/netfilter/nfnetlink_queue.c @@ -313,7 +313,7 @@ nfqnl_build_packet_message(struct net *net, struct nfqnl_instance *queue, struct net_device *outdev; struct nf_conn *ct = NULL; enum ip_conntrack_info uninitialized_var(ctinfo); - struct nfnl_ct_hook *nfnl_ct; + struct nfnl_ct_hook *nfnl_ct = NULL; bool csum_verify; char *secdata = NULL; u32 seclen = 0; @@ -1041,7 +1041,7 @@ nfqnl_recv_verdict(struct sock *ctnl, struct sk_buff *skb, unsigned int verdict; struct nf_queue_entry *entry; enum ip_conntrack_info uninitialized_var(ctinfo); - struct nfnl_ct_hook *nfnl_ct; + struct nfnl_ct_hook *nfnl_ct = NULL; struct nf_conn *ct = NULL; struct net *net = sock_net(ctnl); -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Pablo Neira Ayuso <pablo@netfilter.org> |
|---|---|
| Date | 2015-12-09 15:00 +0100 |
| Subject | Re: [PATCH] netfilter: Initialize local variables to NULL, to prevent using them when uninitialized. |
| Message-ID | <qDNrI-EN-13@gated-at.bofh.it> |
| In reply to | #1284516 |
We already have this: http://git.kernel.org/cgit/linux/kernel/git/pablo/nf.git/commit/?id=8e662164abb4a8fde701a46e1431980f9e325742 We'll be sending this today to David to avoid this annoyance. Thanks for you patch anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web