Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1287476 > unrolled thread

Fwd: [PATCH] char:misc minor is overflowing

Started byNitin Gupta <nitin.gupta@samsung.com>
First post2015-12-09 14:00 +0100
Last post2015-12-09 14:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

Contents

  Fwd: [PATCH] char:misc minor is overflowing Nitin Gupta <nitin.gupta@samsung.com> - 2015-12-09 14:00 +0100
    Re: [PATCH] char:misc minor is overflowing One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2015-12-09 14:40 +0100

#1287476 — Fwd: [PATCH] char:misc minor is overflowing

FromNitin Gupta <nitin.gupta@samsung.com>
Date2015-12-09 14:00 +0100
SubjectFwd: [PATCH] char:misc minor is overflowing
Message-ID<qDMvE-51-25@gated-at.bofh.it>
SGksDQoNCklzIHRoZXJlIGFueSBtb2RpZmljYXRpb24gLyBpbXByb3ZlbWVudCBuZWVkZWQgaW4g
dGhpcyBwYXRjaCA/DQoNCi0tLS0tLS0gT3JpZ2luYWwgTWVzc2FnZSAtLS0tLS0tDQpTZW5kZXIg
OiBTaGl2bmFuZGFuIEt1bWFyPHNoaXZuYW5kYW4ua0BzYW1zdW5nLmNvbT4gRW5naW5lZXIvU1JJ
LU5vaWRhLUFkdmFuY2UgU29sdXRpb25zIC0gU3lzdGVtIDEgUiZEIEdyb3VwL1NhbXN1bmcgRWxl
Y3Ryb25pY3MNCkRhdGUgOiBOb3YgMjAsIDIwMTUgMTU6MzUgKEdNVCswNTozMCkNClRpdGxlIDog
W1BBVENIXSBjaGFyOm1pc2MgbWlub3IgaXMgb3ZlcmZsb3dpbmcNCg0KV2hlbiBhIGRyaXZlciBy
ZWdpc3RlciBhcyBhIG1pc2MgZHJpdmVyIGFuZCANCml0IHRyaWVzIHRvIGFsbG9jYXRlICBtaW5v
ciBudW1iZXIgZHluYW1pY2FsbHkuDQpUaGVuIHRoZXJlIGlzIGEgY2hhbmNlIG9mIG1pbm9yIG51
bWJlciBvdmVyZmxvdy4NClRoZSBwcm9ibGVtIGlzIHRoYXQgNjQoRFlOQU1JQ19NSU5PUlMpIGlz
IG5vdCBlbm91Z2ggDQpmb3IgZHluYW1pYyBtaW5vciBudW1iZXIgYW5kIGlmIGtlcm5lbCBkZWZp
bmVzIDAtNjMNCmZvciBkeW5hbWljIG1pbm9yIG51bWJlciwgaXQgc2hvdWxkIGJlIHJlc2VydmVk
LiBCdXQsMC0xMA0Kd2FzIHVzZWQgZm9yIG90aGVyIGRldmljZXMsICBmb3IgZXhhbXBsZSAxIGlz
IHJlc2VydmVkIGZvciANClBTTU9VU0UuIEkgZ290IHRoZSBpc3N1ZSB0aGF0IG1pc2NfbWlub3Jz
IGlzIDB4M0ZGRkZGRkZGRkZGRkZGRiANCmFuZCBzbywgdmFsdWUgb2YgdmFyaWFibGUgJ2knIGlu
IGZ1bmN0aW9uIG1pc2NfcmVnaXN0ZXIgYmVjb21lcyANCjYyIGFuZCBzbyBtaXNjX21pbm9ycyBi
ZWNvbWUgMS4oV2hpY2ggd2FzIGFscmVhZHkgcmVzZXJ2ZWQNCmZvciBQU01PVVNFKS4gVGhpcyBw
YXRjaCBoZWxwIHRvIGF2b2lkIHRoZSANCmFib3ZlIHByb2JsZW0uDQoNClNpZ25lZC1vZmYtYnk6
IHNoaXZuYW5kYW4ga3VtYXIgDQotLS0NCmRyaXZlcnMvY2hhci9taXNjLmMgICAgICAgIHwgICAg
NSArKy0tLQ0KaW5jbHVkZS9saW51eC9taXNjZGV2aWNlLmggfCAgICAxICsNCjIgZmlsZXMgY2hh
bmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvZHJp
dmVycy9jaGFyL21pc2MuYyBiL2RyaXZlcnMvY2hhci9taXNjLmMNCmluZGV4IDgwNjliMzYuLjFh
NmE2NDAgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL2NoYXIvbWlzYy5jDQorKysgYi9kcml2ZXJzL2No
YXIvbWlzYy5jDQpAQCAtMTk4LDcgKzE5OCw3IEBAIGludCBtaXNjX3JlZ2lzdGVyKHN0cnVjdCBt
aXNjZGV2aWNlICogbWlzYykNCmVyciA9IC1FQlVTWTsNCmdvdG8gb3V0Ow0KfQ0KLSBtaXNjLT5t
aW5vciA9IERZTkFNSUNfTUlOT1JTIC0gaSAtIDE7DQorIG1pc2MtPm1pbm9yID0gRFlOQU1JQ19N
SU5PUlMgLSBpIC0gMSArIERZTkFNSUNfTUlOT1JfU1RBUlQ7DQpzZXRfYml0KGksIG1pc2NfbWlu
b3JzKTsNCn0gZWxzZSB7DQpzdHJ1Y3QgbWlzY2RldmljZSAqYzsNCkBAIC0yMTgsOCArMjE4LDcg
QEAgaW50IG1pc2NfcmVnaXN0ZXIoc3RydWN0IG1pc2NkZXZpY2UgKiBtaXNjKQ0KICBtaXNjLCBt
aXNjLT5ncm91cHMsICIlcyIsIG1pc2MtPm5hbWUpOw0KaWYgKElTX0VSUihtaXNjLT50aGlzX2Rl
dmljZSkpIHsNCmlmIChpc19keW5hbWljKSB7DQotIGludCBpID0gRFlOQU1JQ19NSU5PUlMgLSBt
aXNjLT5taW5vciAtIDE7DQorIGludCBpID0gRFlOQU1JQ19NSU5PUlMgLSBtaXNjLT5taW5vciAt
IDEgKyBEWU5BTUlDX01JTk9SX1NUQVJUOw0KaWYgKGkgPCBEWU5BTUlDX01JTk9SUyAmJiBpID49
IDApDQpjbGVhcl9iaXQoaSwgbWlzY19taW5vcnMpOw0KbWlzYy0+bWlub3IgPSBNSVNDX0RZTkFN
SUNfTUlOT1I7DQpkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9taXNjZGV2aWNlLmggYi9pbmNs
dWRlL2xpbnV4L21pc2NkZXZpY2UuaA0KaW5kZXggODFmNmU0Mi4uN2FhOTMxZSAxMDA2NDQNCi0t
LSBhL2luY2x1ZGUvbGludXgvbWlzY2RldmljZS5oDQorKysgYi9pbmNsdWRlL2xpbnV4L21pc2Nk
ZXZpY2UuaA0KQEAgLTE5LDYgKzE5LDcgQEANCiNkZWZpbmUgQVBPTExPX01PVVNFX01JTk9SIDcg
LyogdW51c2VkICovDQojZGVmaW5lIFBDMTEwUEFEX01JTk9SIDkgLyogdW51c2VkICovDQovKiNk
ZWZpbmUgQURCX01PVVNFX01JTk9SIDEwIEZJWE1FIE9CU09MRVRFICovDQorI2RlZmluZSBEWU5B
TUlDX01JTk9SX1NUQVJUIDExDQojZGVmaW5lIFdBVENIRE9HX01JTk9SIDEzMCAvKiBXYXRjaGRv
ZyB0aW1lciAgICAgKi8NCiNkZWZpbmUgVEVNUF9NSU5PUiAxMzEgLyogVGVtcGVyYXR1cmUgU2Vu
c29yICovDQojZGVmaW5lIFJUQ19NSU5PUiAxMzUNCi0tIA0KMS43LjkuNQ0KDQoNCg0KIE5pdGlu
IEd1cHRhDQogDQpMb2dpeCBDeWJlciBQYXJrIJUgUGxvdCBOby4gQyAyOC0yOSwgVG93ZXIgRCAt
IEdyb3VuZCB0byAxMHRoIEZsb29yLCBUb3dlciBDIC0gOHRoIHRvICAxMHRoIEZsb29yLCBTZWN0
b3IgNjIglSBOb2lkYShVLlAuKSAgMjAxMzAxIJUgSU5ESUEgDQoNCiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA=


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1287502

FromOne Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Date2015-12-09 14:40 +0100
Message-ID<qDN8n-xe-37@gated-at.bofh.it>
In reply to#1287476
On Wed, 09 Dec 2015 12:51:33 +0000 (GMT)
Nitin Gupta <nitin.gupta@samsung.com> wrote:

> Hi,
> 
> Is there any modification / improvement needed in this patch ?
> 
> ------- Original Message -------
> Sender : Shivnandan Kumar<shivnandan.k@samsung.com> Engineer/SRI-Noida-Advance Solutions - System 1 R&D Group/Samsung Electronics
> Date : Nov 20, 2015 15:35 (GMT+05:30)
> Title : [PATCH] char:misc minor is overflowing
> 
> When a driver register as a misc driver and 
> it tries to allocate  minor number dynamically.
> Then there is a chance of minor number overflow.
> The problem is that 64(DYNAMIC_MINORS) is not enough 

If you are allocating more than the odd minor number you shouldn't be
using misc devices in the first place but should be using
cdev_init/cdev_add/register_chrdev_region and friends.

So 64 really should never be "not enough". miscdevice is more historical
than useful and really goes back to the days long before all the region
allocators existed.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web