Groups > linux.kernel > #1286940 > unrolled thread

Re: Failed to build on 4.2.6

Started by	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
First post	2015-12-09 01:50 +0100
Last post	2015-12-09 12:00 +0100
Articles	2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

  Re: Failed to build on 4.2.6 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-09 01:50 +0100
    Re: Failed to build on 4.2.6 Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-12-09 12:00 +0100

#1286940 — Re: Failed to build on 4.2.6

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date	2015-12-09 01:50 +0100
Subject	Re: Failed to build on 4.2.6
Message-ID	<qDB7c-14l-9@gated-at.bofh.it>

On Mon, Dec 07, 2015 at 10:25:19AM -0500, Steven Rostedt wrote:
> Hi,
> 
> The attached config doesn't build on 4.2.6, but changing it to the
> following:
> 
>  VIDEO_V4L2_SUBDEV_API n -> y
> +V4L2_FLASH_LED_CLASS n
> 
> does build.

Did this work on older kernels (4.2.5?  .4?  older?)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1287415

From	Luis de Bethencourt <luisbg@osg.samsung.com>
Date	2015-12-09 12:00 +0100
Message-ID	<qDKDw-7j2-11@gated-at.bofh.it>
In reply to	#1286940

Greg Kroah-Hartman writes:

> On Mon, Dec 07, 2015 at 10:25:19AM -0500, Steven Rostedt wrote:
>> Hi,
>>
>> The attached config doesn't build on 4.2.6, but changing it to the
>> following:
>>
>>  VIDEO_V4L2_SUBDEV_API n -> y
>> +V4L2_FLASH_LED_CLASS n
>>
>> does build.
>
> Did this work on older kernels (4.2.5?  .4?  older?)
>
> thanks,
>
> greg k-h

Hi all,

The problem was:

drivers/media/i2c/adv7604.c: In function ‘adv76xx_get_format’:
drivers/media/i2c/adv7604.c:1861:3: error: implicit declaration of function ‘v4l2_subdev_get_try_format’ [-Werror=implicit-function-declaration]
   fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);

As Randy mentioned, this if fixed by commit
fc88dd16a0e430f57458e6bd9b62a631c6ea53a1

I backported it locally to test this and build worked fine.

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

csiph-web

Re: Failed to build on 4.2.6

Contents

#1286940 — Re: Failed to build on 4.2.6

#1287415