Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1282857 > unrolled thread

[PATCH 1/3] regmap: cache: Tidy up the code to suppress style check warnings

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 1/3] regmap: cache: Tidy up the code to suppress style check warnings Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-03 10:50 +0100
    Re: [PATCH 1/3] regmap: cache: Tidy up the code to suppress style  check warnings Mark Brown <broonie@kernel.org> - 2015-12-08 18:20 +0100
      Re: [PATCH 1/3] regmap: cache: Tidy up the code to suppress stylecheck  warnings Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-09 04:40 +0100

#1282857 — [PATCH 1/3] regmap: cache: Tidy up the code to suppress style check warnings

There will be some warning like the following when checking new
patches near this code:
    "WARNING: Missing a blank line after declarations"
This patch will suppress this warning.

Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
---
 drivers/base/regmap/regcache.c | 36 ++++++++++++------------------------
 1 file changed, 12 insertions(+), 24 deletions(-)

diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index 4c07802..0905562 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -533,21 +533,15 @@ bool regcache_set_val(struct regmap *map, void *base, unsigned int idx,
 	}
 
 	switch (map->cache_word_size) {
-	case 1: {
-		u8 *cache = base;
-		cache[idx] = val;
+	case 1:
+		((u8 *)base)[idx] = val;
 		break;
-	}
-	case 2: {
-		u16 *cache = base;
-		cache[idx] = val;
+	case 2:
+		((u16 *)base)[idx] = val;
 		break;
-	}
-	case 4: {
-		u32 *cache = base;
-		cache[idx] = val;
+	case 4:
+		((u32 *)base)[idx] = val;
 		break;
-	}
 	default:
 		BUG();
 	}
@@ -566,18 +560,12 @@ unsigned int regcache_get_val(struct regmap *map, const void *base,
 								   idx));
 
 	switch (map->cache_word_size) {
-	case 1: {
-		const u8 *cache = base;
-		return cache[idx];
-	}
-	case 2: {
-		const u16 *cache = base;
-		return cache[idx];
-	}
-	case 4: {
-		const u32 *cache = base;
-		return cache[idx];
-	}
+	case 1:
+		return ((u8 *)base)[idx];
+	case 2:
+		return ((u16 *)base)[idx];
+	case 4:
+		return ((u32 *)base)[idx];
 	default:
 		BUG();
 	}
-- 
1.8.3.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1286708 — Re: [PATCH 1/3] regmap: cache: Tidy up the code to suppress style check warnings

[Multipart message — attachments visible in raw view] — view raw

On Thu, Dec 03, 2015 at 05:31:51PM +0800, Xiubo Li wrote:

> There will be some warning like the following when checking new
> patches near this code:
>     "WARNING: Missing a blank line after declarations"
> This patch will suppress this warning.

>  	switch (map->cache_word_size) {
> -	case 1: {
> -		u8 *cache = base;
> -		cache[idx] = val;
> +	case 1:
> +		((u8 *)base)[idx] = val;
>  		break;
> -	}

If there's a change to shut checkpatch up I'd rather just add the blank
line it's asking for - the code is the way it is currently to avoid the
casts since they're hard for people to read.

[toc] | [prev] | [next] | [standalone]

#1287064 — Re: [PATCH 1/3] regmap: cache: Tidy up the code to suppress stylecheck warnings

On 09/12/2015 01:12, Mark Brown wrote:
> On Thu, Dec 03, 2015 at 05:31:51PM +0800, Xiubo Li wrote:
>
>> There will be some warning like the following when checking new
>> patches near this code:
>>      "WARNING: Missing a blank line after declarations"
>> This patch will suppress this warning.
>>   	switch (map->cache_word_size) {
>> -	case 1: {
>> -		u8 *cache = base;
>> -		cache[idx] = val;
>> +	case 1:
>> +		((u8 *)base)[idx] = val;
>>   		break;
>> -	}
> If there's a change to shut checkpatch up I'd rather just add the blank
> line it's asking for - the code is the way it is currently to avoid the
> casts since they're hard for people to read.
Both of them are okay for me.

I will send the v2 for these just adding one blank line.

Thanks,

BRs

Xiubo





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web