Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1287002 > unrolled thread

[PATCH perf/core 15/22] perf: Fix map_groups__clone to put cloned map

Started byMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
First post2015-12-09 03:30 +0100
Last post2015-12-10 09:20 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH perf/core 15/22] perf: Fix map_groups__clone to put cloned  map Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> - 2015-12-09 03:30 +0100
    Re: [PATCH perf/core 15/22] perf: Fix map_groups__clone to put  cloned map Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-09 15:30 +0100
    [tip:perf/core] perf tools:   Fix map_groups__clone to put cloned map tip-bot for Masami Hiramatsu <tipbot@zytor.com> - 2015-12-10 09:20 +0100

#1287002 — [PATCH perf/core 15/22] perf: Fix map_groups__clone to put cloned map

FromMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Date2015-12-09 03:30 +0100
Subject[PATCH perf/core 15/22] perf: Fix map_groups__clone to put cloned map
Message-ID<qDCFY-295-3@gated-at.bofh.it>
Fix map_groups__clone to put cloned map after
inserting it to the map_groups.

Refcnt debugger shows:
  ----
  ==== [0] ====
  Unreclaimed map: 0x2a27ee0
  Refcount +1 => 1 at
    ./perf(map_groups__clone+0x8d) [0x4bb7ed]
    ./perf(thread__fork+0xbe) [0x4c1f9e]
    ./perf(machine__process_fork_event+0x216) [0x4b79a6]
    ./perf(perf_event__synthesize_threads+0x38b) [0x48135b]
    ./perf(cmd_top+0xdc6) [0x43cb76]
    ./perf() [0x477223]
    ./perf(main+0x617) [0x422077]
    /lib64/libc.so.6(__libc_start_main+0xf0) [0x7ff806af8fe0]
    ./perf() [0x4221ed]
  Refcount +1 => 2 at
    ./perf(map_groups__clone+0x128) [0x4bb888]
    ./perf(thread__fork+0xbe) [0x4c1f9e]
    ./perf(machine__process_fork_event+0x216) [0x4b79a6]
    ./perf(perf_event__synthesize_threads+0x38b) [0x48135b]
    ./perf(cmd_top+0xdc6) [0x43cb76]
    ./perf() [0x477223]
    ./perf(main+0x617) [0x422077]
    /lib64/libc.so.6(__libc_start_main+0xf0) [0x7ff806af8fe0]
    ./perf() [0x4221ed]
  Refcount -1 => 1 at
    ./perf(map_groups__exit+0x87) [0x4ba757]
    ./perf(map_groups__put+0x68) [0x4ba9a8]
    ./perf(thread__put+0x8b) [0x4c1aeb]
    ./perf(machine__delete_threads+0x81) [0x4b48f1]
    ./perf(perf_session__delete+0x4f) [0x4be63f]
    ./perf(cmd_top+0x1094) [0x43ce44]
    ./perf() [0x477223]
    ./perf(main+0x617) [0x422077]
    /lib64/libc.so.6(__libc_start_main+0xf0) [0x7ff806af8fe0]
    ./perf() [0x4221ed]
  ----

This shows map_groups__clone get the map twice
and put it when map_groups__exit.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
---
 tools/perf/util/map.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index 7859216..03b7297 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -744,6 +744,7 @@ int map_groups__clone(struct map_groups *mg,
 		if (new == NULL)
 			goto out_unlock;
 		map_groups__insert(mg, new);
+		map__put(new);
 	}
 
 	err = 0;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1287524 — Re: [PATCH perf/core 15/22] perf: Fix map_groups__clone to put cloned map

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2015-12-09 15:30 +0100
SubjectRe: [PATCH perf/core 15/22] perf: Fix map_groups__clone to put cloned map
Message-ID<qDNUJ-15S-9@gated-at.bofh.it>
In reply to#1287002
Em Wed, Dec 09, 2015 at 11:11:20AM +0900, Masami Hiramatsu escreveu:
> Fix map_groups__clone to put cloned map after
> inserting it to the map_groups.

Thanks, applied!

- Arnaldo
 
> Refcnt debugger shows:
>   ----
>   ==== [0] ====
>   Unreclaimed map: 0x2a27ee0
>   Refcount +1 => 1 at
>     ./perf(map_groups__clone+0x8d) [0x4bb7ed]
>     ./perf(thread__fork+0xbe) [0x4c1f9e]
>     ./perf(machine__process_fork_event+0x216) [0x4b79a6]
>     ./perf(perf_event__synthesize_threads+0x38b) [0x48135b]
>     ./perf(cmd_top+0xdc6) [0x43cb76]
>     ./perf() [0x477223]
>     ./perf(main+0x617) [0x422077]
>     /lib64/libc.so.6(__libc_start_main+0xf0) [0x7ff806af8fe0]
>     ./perf() [0x4221ed]
>   Refcount +1 => 2 at
>     ./perf(map_groups__clone+0x128) [0x4bb888]
>     ./perf(thread__fork+0xbe) [0x4c1f9e]
>     ./perf(machine__process_fork_event+0x216) [0x4b79a6]
>     ./perf(perf_event__synthesize_threads+0x38b) [0x48135b]
>     ./perf(cmd_top+0xdc6) [0x43cb76]
>     ./perf() [0x477223]
>     ./perf(main+0x617) [0x422077]
>     /lib64/libc.so.6(__libc_start_main+0xf0) [0x7ff806af8fe0]
>     ./perf() [0x4221ed]
>   Refcount -1 => 1 at
>     ./perf(map_groups__exit+0x87) [0x4ba757]
>     ./perf(map_groups__put+0x68) [0x4ba9a8]
>     ./perf(thread__put+0x8b) [0x4c1aeb]
>     ./perf(machine__delete_threads+0x81) [0x4b48f1]
>     ./perf(perf_session__delete+0x4f) [0x4be63f]
>     ./perf(cmd_top+0x1094) [0x43ce44]
>     ./perf() [0x477223]
>     ./perf(main+0x617) [0x422077]
>     /lib64/libc.so.6(__libc_start_main+0xf0) [0x7ff806af8fe0]
>     ./perf() [0x4221ed]
>   ----
> 
> This shows map_groups__clone get the map twice
> and put it when map_groups__exit.
> 
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> ---
>  tools/perf/util/map.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
> index 7859216..03b7297 100644
> --- a/tools/perf/util/map.c
> +++ b/tools/perf/util/map.c
> @@ -744,6 +744,7 @@ int map_groups__clone(struct map_groups *mg,
>  		if (new == NULL)
>  			goto out_unlock;
>  		map_groups__insert(mg, new);
> +		map__put(new);
>  	}
>  
>  	err = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1288333 — [tip:perf/core] perf tools: Fix map_groups__clone to put cloned map

Fromtip-bot for Masami Hiramatsu <tipbot@zytor.com>
Date2015-12-10 09:20 +0100
Subject[tip:perf/core] perf tools: Fix map_groups__clone to put cloned map
Message-ID<qE4Ce-3wi-15@gated-at.bofh.it>
In reply to#1287002
Commit-ID:  bae32b50ea96ca0f8702ea55e62095e8cc4745e2
Gitweb:     http://git.kernel.org/tip/bae32b50ea96ca0f8702ea55e62095e8cc4745e2
Author:     Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
AuthorDate: Wed, 9 Dec 2015 11:11:20 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 9 Dec 2015 13:41:58 -0300

perf tools: Fix map_groups__clone to put cloned map

Fix map_groups__clone to put cloned map after inserting it to the
map_groups.

Refcnt debugger shows:
  ----
  ==== [0] ====
  Unreclaimed map: 0x2a27ee0
  Refcount +1 => 1 at
    ./perf(map_groups__clone+0x8d) [0x4bb7ed]
    ./perf(thread__fork+0xbe) [0x4c1f9e]
    ./perf(machine__process_fork_event+0x216) [0x4b79a6]
    ./perf(perf_event__synthesize_threads+0x38b) [0x48135b]
    ./perf(cmd_top+0xdc6) [0x43cb76]
    ./perf() [0x477223]
    ./perf(main+0x617) [0x422077]
    /lib64/libc.so.6(__libc_start_main+0xf0) [0x7ff806af8fe0]
    ./perf() [0x4221ed]
  Refcount +1 => 2 at
    ./perf(map_groups__clone+0x128) [0x4bb888]
    ./perf(thread__fork+0xbe) [0x4c1f9e]
    ./perf(machine__process_fork_event+0x216) [0x4b79a6]
    ./perf(perf_event__synthesize_threads+0x38b) [0x48135b]
    ./perf(cmd_top+0xdc6) [0x43cb76]
    ./perf() [0x477223]
    ./perf(main+0x617) [0x422077]
    /lib64/libc.so.6(__libc_start_main+0xf0) [0x7ff806af8fe0]
    ./perf() [0x4221ed]
  Refcount -1 => 1 at
    ./perf(map_groups__exit+0x87) [0x4ba757]
    ./perf(map_groups__put+0x68) [0x4ba9a8]
    ./perf(thread__put+0x8b) [0x4c1aeb]
    ./perf(machine__delete_threads+0x81) [0x4b48f1]
    ./perf(perf_session__delete+0x4f) [0x4be63f]
    ./perf(cmd_top+0x1094) [0x43ce44]
    ./perf() [0x477223]
    ./perf(main+0x617) [0x422077]
    /lib64/libc.so.6(__libc_start_main+0xf0) [0x7ff806af8fe0]
    ./perf() [0x4221ed]
  ----

This shows map_groups__clone get the map twice and put it when
map_groups__exit.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20151209021120.10245.95388.stgit@localhost.localdomain
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/map.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index 93d9f1c..7b1c720 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -742,6 +742,7 @@ int map_groups__clone(struct map_groups *mg,
 		if (new == NULL)
 			goto out_unlock;
 		map_groups__insert(mg, new);
+		map__put(new);
 	}
 
 	err = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web