Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1286862 > unrolled thread

[GIT PULL] UML fixes for 4.4-rc5

Back to article view | Back to linux.kernel

Contents

  [GIT PULL] UML fixes for 4.4-rc5 Richard Weinberger <richard@nod.at> - 2015-12-08 22:40 +0100
    Re: [GIT PULL] UML fixes for 4.4-rc5 Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-09 02:40 +0100
      Re: [GIT PULL] UML fixes for 4.4-rc5 Richard Weinberger <richard@nod.at> - 2015-12-09 09:50 +0100

#1286862 — [GIT PULL] UML fixes for 4.4-rc5

[Multipart message — attachments visible in raw view] — view raw

Linus,

The following changes since commit 527e9316f8ec44bd53d90fb9f611fa7ffff52bb9:

  Linux 4.4-rc4 (2015-12-06 15:43:12 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git for-linus-4.4-rc5

for you to fetch changes up to 887a9853092c09e20598f4a7f91ac1cfb762be50:

  um: fix returns without va_end (2015-12-08 22:26:00 +0100)

----------------------------------------------------------------
This pull request contains various bug fixes, most of them are
fall out from the merge window.

----------------------------------------------------------------
Geyslan G. Bem (1):
      um: fix returns without va_end

Lorenzo Colitti (1):
      arch: um: fix error when linking vmlinux.

Richard Weinberger (2):
      um: Fix get_signal() usage
      um: Fix fpstate handling

 arch/um/Makefile           |  2 +-
 arch/um/drivers/net_user.c | 10 ++++++----
 arch/um/kernel/signal.c    |  2 +-
 arch/x86/um/signal.c       | 18 ++++++++++--------
 scripts/link-vmlinux.sh    |  2 +-
 5 files changed, 19 insertions(+), 15 deletions(-)

[toc] | [next] | [standalone]

#1286969

On Tue, Dec 8, 2015 at 1:39 PM, Richard Weinberger <richard@nod.at> wrote:
>
> This pull request contains various bug fixes, most of them are
> fall out from the merge window.
>
> Richard Weinberger (2):
>       um: Fix fpstate handling

Ugh. This is very ugly. It's apparently the result of commit
530e5c827182 ("x86/headers: Make sigcontext pointers bit independent")
and apparently nobody noticed the uml fallout.

I've pulled, but I wanted the x86 people involved to be aware of this
ugly corner. I wonder if there might be some way for uml to continue
to use that fpstate entry as a pointer, at least when the wordsize
matches (which it will)?

                   Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1287194

Linus,

Am 09.12.2015 um 02:35 schrieb Linus Torvalds:
> On Tue, Dec 8, 2015 at 1:39 PM, Richard Weinberger <richard@nod.at> wrote:
>>
>> This pull request contains various bug fixes, most of them are
>> fall out from the merge window.
>>
>> Richard Weinberger (2):
>>       um: Fix fpstate handling
> 
> Ugh. This is very ugly. It's apparently the result of commit
> 530e5c827182 ("x86/headers: Make sigcontext pointers bit independent")
> and apparently nobody noticed the uml fallout.
> 
> I've pulled, but I wanted the x86 people involved to be aware of this
> ugly corner. I wonder if there might be some way for uml to continue
> to use that fpstate entry as a pointer, at least when the wordsize
> matches (which it will)?

I agree. One way to get rid of the ugliness would be rewriting UML's
FP code. The code is very old and doing it like x86 does would be a
good thing anyway. But that's nothing I'll do at this stage of development.
That's material for the next merge window.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web