Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1286632 > unrolled thread

[PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

Started byMasahiro Yamada <yamada.masahiro@socionext.com>
First post2015-12-08 17:10 +0100
Last post2015-12-10 07:30 +0100
Articles 3 on this page of 23 — 7 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] of/address: replace printk() with pr_debug() / pr_err() Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-12-08 17:10 +0100
    Re: [PATCH v2] of/address: replace printk() with pr_debug() /  pr_err() Joe Perches <joe@perches.com> - 2015-12-08 17:20 +0100
      Re: [PATCH v2] of/address: replace printk() with pr_debug() /  pr_err() Joe Perches <joe@perches.com> - 2015-12-08 18:10 +0100
        Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err() Rob Herring <robh+dt@kernel.org> - 2015-12-08 22:30 +0100
          Re: [PATCH v2] of/address: replace printk() with pr_debug() /  pr_err() Joe Perches <joe@perches.com> - 2015-12-09 01:10 +0100
            Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-09 13:10 +0100
              Re: [PATCH v2] of/address: replace printk() with pr_debug() /  pr_err() Joe Perches <joe@perches.com> - 2015-12-09 20:30 +0100
                Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-09 21:10 +0100
                  Re: [PATCH v2] of/address: replace printk() with pr_debug() /  pr_err() Joe Perches <joe@perches.com> - 2015-12-09 21:20 +0100
                  Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-12-09 21:20 +0100
                    Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-09 21:40 +0100
                      Re: [PATCH v2] of/address: replace printk() with pr_debug() /  pr_err() Joe Perches <joe@perches.com> - 2015-12-09 21:50 +0100
          [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions Joe Perches <joe@perches.com> - 2015-12-09 23:00 +0100
            Re: [PATCH] hexdump: Add ability to do endian conversions in  print_hex_dump functions Andrew Morton <akpm@linux-foundation.org> - 2015-12-09 23:10 +0100
              Re: [PATCH] hexdump: Add ability to do endian conversions in  print_hex_dump functions Joe Perches <joe@perches.com> - 2015-12-09 23:20 +0100
                Re: [PATCH] hexdump: Add ability to do endian conversions in  print_hex_dump functions Andrew Morton <akpm@linux-foundation.org> - 2015-12-09 23:50 +0100
                  Re: [PATCH] hexdump: Add ability to do endian conversions in  print_hex_dump functions Joe Perches <joe@perches.com> - 2015-12-10 00:10 +0100
            Re: [PATCH] hexdump: Add ability to do endian conversions in  print_hex_dump functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-09 23:20 +0100
              Re: [PATCH] hexdump: Add ability to do endian conversions in  print_hex_dump functions Joe Perches <joe@perches.com> - 2015-12-09 23:30 +0100
              Re: [PATCH] hexdump: Add ability to do endian conversions in  print_hex_dump functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-10 00:10 +0100
                Re: [PATCH] hexdump: Add ability to do endian conversions in  print_hex_dump functions Joe Perches <joe@perches.com> - 2015-12-10 00:20 +0100
            Re: [PATCH] hexdump: Add ability to do endian conversions in  print_hex_dump functions kbuild test robot <lkp@intel.com> - 2015-12-10 07:00 +0100
              Re: [PATCH] hexdump: Add ability to do endian conversions in  print_hex_dump functions Joe Perches <joe@perches.com> - 2015-12-10 07:30 +0100

Page 2 of 2 — ← Prev page 1 [2]

#1288024 — Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

FromJoe Perches <joe@perches.com>
Date2015-12-10 00:20 +0100
SubjectRe: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions
Message-ID<qDWbG-6rH-63@gated-at.bofh.it>
In reply to#1287995
On Thu, 2015-12-10 at 01:09 +0200, Andy Shevchenko wrote:
> On Thu, Dec 10, 2015 at 12:11 AM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches <joe@perches.com> wrote:
> > > There are use cases for dumping buffers with specific endian types
> > > for 2, 4, and 8 byte variables in arrays.
> > > 
> > > Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such.
> > > 
> > > Rename groupsize to groupflags in the functions and add documentation
> > > to the kernel-doc to describe the use of the DUMP_TYPE_ enum.
> > 
> > One comment below and my tag
> > Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> Couple of additional notes. (Tag still in power)
> 
> 1. There is similar to print_hex_dump() function in seq_file. Separate patch?

Let's see if anyone wants this one first.

> 2. What to do with ASCII part? Shall we print it as byte stream?

It's still emitted as a byte stream.

> And one more style comment below.

That one's a nit I don't care about.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1288218 — Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

Fromkbuild test robot <lkp@intel.com>
Date2015-12-10 07:00 +0100
SubjectRe: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions
Message-ID<qE2qL-1W9-11@gated-at.bofh.it>
In reply to#1287908
Hi Joe,

[auto build test WARNING on v4.4-rc4]
[also build test WARNING on next-20151209]

url:    https://github.com/0day-ci/linux/commits/Joe-Perches/hexdump-Add-ability-to-do-endian-conversions-in-print_hex_dump-functions/20151210-060244
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   include/linux/compiler.h:228:8: sparse: attribute 'no_sanitize_address': unknown attribute
   include/linux/printk.h:430:24: sparse: undefined identifier 'BIT'
>> include/linux/printk.h:430:27: sparse: bad constant expression type
   include/linux/printk.h:431:24: sparse: undefined identifier 'BIT'
   include/linux/printk.h:431:27: sparse: bad constant expression type
   In file included from lib/decompress.c:19:0:
   include/linux/printk.h:430:17: error: implicit declaration of function 'BIT' [-Werror=implicit-function-declaration]
     DUMP_TYPE_LE = BIT(30),
                    ^
   include/linux/printk.h:430:2: error: enumerator value for 'DUMP_TYPE_LE' is not an integer constant
     DUMP_TYPE_LE = BIT(30),
     ^
   include/linux/printk.h:432:1: error: enumerator value for 'DUMP_TYPE_BE' is not an integer constant
    };
    ^
   cc1: some warnings being treated as errors

vim +430 include/linux/printk.h

   414		printk_ratelimited(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
   415	#else
   416	#define pr_debug_ratelimited(fmt, ...) \
   417		no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
   418	#endif
   419	
   420	extern const struct file_operations kmsg_fops;
   421	
   422	enum {
   423		DUMP_PREFIX_NONE,
   424		DUMP_PREFIX_ADDRESS,
   425		DUMP_PREFIX_OFFSET
   426	};
   427	
   428	enum {
   429		DUMP_TYPE_CPU = 0,
 > 430		DUMP_TYPE_LE = BIT(30),
   431		DUMP_TYPE_BE = BIT(31)
   432	};
   433	
   434	extern int hex_dump_to_buffer(const void *buf, size_t len, int rowsize,
   435				      int groupflags, char *linebuf, size_t linebuflen,
   436				      bool ascii);
   437	#ifdef CONFIG_PRINTK
   438	extern void print_hex_dump(const char *level, const char *prefix_str,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1288225 — Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

FromJoe Perches <joe@perches.com>
Date2015-12-10 07:30 +0100
SubjectRe: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions
Message-ID<qE2TM-2lp-3@gated-at.bofh.it>
In reply to#1288218
On Thu, 2015-12-10 at 13:55 +0800, kbuild test robot wrote:
> Hi Joe,

Hello Fengguang.

Thanks for the report.  I'll fix and resubmit.

> > > include/linux/printk.h:430:24: sparse: undefined identifier 'BIT'
> > > include/linux/printk.h:430:27: sparse: bad constant expression type

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web