Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1284578 > unrolled thread

Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header

Started bykbuild test robot <lkp@intel.com>
First post2015-12-05 17:50 +0100
Last post2015-12-07 15:20 +0100
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header kbuild test robot <lkp@intel.com> - 2015-12-05 17:50 +0100
    Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to  header Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-06 08:30 +0100
      Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-07 07:10 +0100
        Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to  header Sanidhya Solanki <jpage.lkml@gmail.com> - 2015-12-07 15:20 +0100

#1284578 — Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header

Fromkbuild test robot <lkp@intel.com>
Date2015-12-05 17:50 +0100
SubjectRe: [PATCH] Staging: Skein: Moved macros from skein_block.c to header
Message-ID<qCoc1-3ts-1@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

Hi Sanidhya,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.4-rc3 next-20151203]

url:    https://github.com/0day-ci/linux/commits/Sanidhya-Solanki/Staging-Skein-Moved-macros-from-skein_block-c-to-header/20151205-233922
config: x86_64-randconfig-s4-12052352 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/staging/skein/skein_block.o: In function `skein_256_process_block':
>> skein_block.c:(.text+0x0): multiple definition of `skein_256_process_block'
   drivers/staging/skein/skein_base.o:skein_base.c:(.text+0x0): first defined here

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [next] | [standalone]


#1284811 — Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header

FromSanidhya Solanki <jpage.lkml@gmail.com>
Date2015-12-06 08:30 +0100
SubjectRe: [PATCH] Staging: Skein: Moved macros from skein_block.c to header
Message-ID<qCBVE-3UW-3@gated-at.bofh.it>
In reply to#1284578
I disagree with the output of the automaton. Included below are my
compile checks before and after the patch.
The output has been scrubbed to remove information about my file layout.

------------------------------------------------------------------
[~ linux]$ git branch -v
  master 31ade3b Linux 4.4-rc3
* pat    31ade3b Linux 4.4-rc3
[~ linux]$ make -j5 drivers/staging/skein/skein_block.o
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/bounds.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  CC      drivers/staging/skein/skein_block.o
[~ linux]$ pwd
~/linux
[~ linux]$ git branch -v
  master 31ade3b Linux 4.4-rc3
* pat    31ade3b Linux 4.4-rc3
[~ linux]$ git branch -v
  master 31ade3b Linux 4.4-rc3
* pat    4d2271c Staging: Skein: Moved macros from skein_block.c to
header file. 
[~ linux]$ pwd
~/linux
[~ linux]$ make -j5 drivers/staging/skein/skein_block.o
  CHK     include/config/kernel.release
  UPD     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  UPD     include/generated/utsrelease.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/bounds.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  CC      drivers/staging/skein/skein_block.o
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1285015

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2015-12-07 07:10 +0100
Message-ID<qCX9L-HX-1@gated-at.bofh.it>
In reply to#1284811
On Sat, Dec 05, 2015 at 10:25:16PM -0500, Sanidhya Solanki wrote:
> I disagree with the output of the automaton. Included below are my
> compile checks before and after the patch.


Build fails with:
skein_block.c: multiple definition of 'skein_256_process_block'

And you moved skein_256_process_block() from skein_block.c to a header
file. Is skein_256_process_block() a macro?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1285359 — Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header

FromSanidhya Solanki <jpage.lkml@gmail.com>
Date2015-12-07 15:20 +0100
SubjectRe: [PATCH] Staging: Skein: Moved macros from skein_block.c to header
Message-ID<qD4NY-5Bp-9@gated-at.bofh.it>
In reply to#1285015
On Mon, 7 Dec 2015 11:37:31 +0530
Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:

> And you moved skein_256_process_block() from skein_block.c to a header
> file. Is skein_256_process_block() a macro?

No, it is not a macro, it is a conditional. But as other conditionals
was already included in the header file, I felt that it was
appropriate to move other conditionals as well. However, I will undo
that and test a patch, which I can send to you after making sure it
does not get mangled.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web