Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1284523 > unrolled thread
| Started by | "Matwey V. Kornilov" <matwey@sai.msu.ru> |
|---|---|
| First post | 2015-12-05 12:00 +0100 |
| Last post | 2015-12-11 09:50 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v4 1/3] tty: Move serial8250_stop_rx in front of serial8250_start_tx "Matwey V. Kornilov" <matwey@sai.msu.ru> - 2015-12-05 12:00 +0100
Re: [PATCH v4 1/3] tty: Move serial8250_stop_rx in front of serial8250_start_tx Greg KH <gregkh@linuxfoundation.org> - 2015-12-05 17:10 +0100
Re: [PATCH v4 1/3] tty: Move serial8250_stop_rx in front of serial8250_start_tx "Matwey V. Kornilov" <matwey@sai.msu.ru> - 2015-12-11 09:50 +0100
| From | "Matwey V. Kornilov" <matwey@sai.msu.ru> |
|---|---|
| Date | 2015-12-05 12:00 +0100 |
| Subject | [PATCH v4 1/3] tty: Move serial8250_stop_rx in front of serial8250_start_tx |
| Message-ID | <qCiJk-8qB-3@gated-at.bofh.it> |
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
---
drivers/tty/serial/8250/8250_port.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index 0bbf340..8ad0b2d 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -1280,6 +1280,19 @@ static void autoconfig_irq(struct uart_8250_port *up)
port->irq = (irq > 0) ? irq : 0;
}
+static void serial8250_stop_rx(struct uart_port *port)
+{
+ struct uart_8250_port *up = up_to_u8250p(port);
+
+ serial8250_rpm_get(up);
+
+ up->ier &= ~(UART_IER_RLSI | UART_IER_RDI);
+ up->port.read_status_mask &= ~UART_LSR_DR;
+ serial_port_out(port, UART_IER, up->ier);
+
+ serial8250_rpm_put(up);
+}
+
static inline void __stop_tx(struct uart_8250_port *p)
{
if (p->ier & UART_IER_THRI) {
@@ -1347,19 +1360,6 @@ static void serial8250_unthrottle(struct uart_port *port)
port->unthrottle(port);
}
-static void serial8250_stop_rx(struct uart_port *port)
-{
- struct uart_8250_port *up = up_to_u8250p(port);
-
- serial8250_rpm_get(up);
-
- up->ier &= ~(UART_IER_RLSI | UART_IER_RDI);
- up->port.read_status_mask &= ~UART_LSR_DR;
- serial_port_out(port, UART_IER, up->ier);
-
- serial8250_rpm_put(up);
-}
-
static void serial8250_disable_ms(struct uart_port *port)
{
struct uart_8250_port *up =
--
2.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-12-05 17:10 +0100 |
| Subject | Re: [PATCH v4 1/3] tty: Move serial8250_stop_rx in front of serial8250_start_tx |
| Message-ID | <qCnzk-3fv-7@gated-at.bofh.it> |
| In reply to | #1284523 |
On Sat, Dec 05, 2015 at 01:54:49PM +0300, Matwey V. Kornilov wrote: > Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru> Why? Please say so in the changelog. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Matwey V. Kornilov" <matwey@sai.msu.ru> |
|---|---|
| Date | 2015-12-11 09:50 +0100 |
| Message-ID | <qEryO-1NQ-23@gated-at.bofh.it> |
| In reply to | #1284568 |
Are there any other issues except empty changelog that I have to fix before v5? 2015-12-05 19:06 GMT+03:00 Greg KH <gregkh@linuxfoundation.org>: > On Sat, Dec 05, 2015 at 01:54:49PM +0300, Matwey V. Kornilov wrote: >> Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru> > > Why? > > Please say so in the changelog. > > thanks, > > greg k-h > -- With best regards, Matwey V. Kornilov. Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia 119991, Moscow, Universitetsky pr-k 13, +7 (495) 9392382 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web