Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1285082 > unrolled thread
| Started by | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| First post | 2015-12-07 09:40 +0100 |
| Last post | 2015-12-07 10:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/2] input: gt801_2plus1 - Add initial support for Goodix GT801 2+1 Julia Lawall <julia.lawall@lip6.fr> - 2015-12-07 09:40 +0100
Re: [PATCH 2/2] input: gt801_2plus1 - Add initial support for Goodix GT801 2+1 Priit Laes <plaes@plaes.org> - 2015-12-07 10:20 +0100
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2015-12-07 09:40 +0100 |
| Subject | Re: [PATCH 2/2] input: gt801_2plus1 - Add initial support for Goodix GT801 2+1 |
| Message-ID | <qCZuV-24d-3@gated-at.bofh.it> |
It looks like braces may be mising. Please check.
julia
On Mon, 7 Dec 2015, kbuild test robot wrote:
> Hi Priit,
>
> [auto build test WARNING on mripard/sunxi/for-next]
> [also build test WARNING on next-20151203]
> [cannot apply to input/next v4.4-rc4]
>
> url: https://github.com/0day-ci/linux/commits/Priit-Laes/input-Driver-for-Goodix-GT801-2-1-touchscreen/20151207-152831
> base: https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git sunxi/for-next
> :::::: branch date: 46 minutes ago
> :::::: commit date: 46 minutes ago
>
> >> drivers/input/touchscreen/gt801_2plus1.c:119:3-30: code aligned with following code on line 120
>
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout d66df313f96e04572821e49cada65cb5c1bea9e2
> vim +119 drivers/input/touchscreen/gt801_2plus1.c
>
> d66df313 Priit Laes 2015-12-07 113 return;
> d66df313 Priit Laes 2015-12-07 114
> d66df313 Priit Laes 2015-12-07 115 /* Build touch map */
> d66df313 Priit Laes 2015-12-07 116 touch_num = 0;
> d66df313 Priit Laes 2015-12-07 117 for (i = 0; (touch_raw != 0) && (i < ts->max_touch_num); i++) {
> d66df313 Priit Laes 2015-12-07 118 if (touch_raw & 1)
> d66df313 Priit Laes 2015-12-07 @119 touch_map[touch_num++] = i;
> d66df313 Priit Laes 2015-12-07 @120 touch_raw >>= 1;
> d66df313 Priit Laes 2015-12-07 121 }
> d66df313 Priit Laes 2015-12-07 122
> d66df313 Priit Laes 2015-12-07 123 /* Calculate checksum */
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Priit Laes <plaes@plaes.org> |
|---|---|
| Date | 2015-12-07 10:20 +0100 |
| Subject | Re: [PATCH 2/2] input: gt801_2plus1 - Add initial support for Goodix GT801 2+1 |
| Message-ID | <qD07D-2A3-7@gated-at.bofh.it> |
| In reply to | #1285082 |
On Mon, 2015-12-07 at 09:34 +0100, Julia Lawall wrote:
> It looks like braces may be mising. Please check.
Thanks, nice catch!
It's actually messed up indenting. Code works as intended.
>
> julia
>
> On Mon, 7 Dec 2015, kbuild test robot wrote:
>
> > Hi Priit,
> >
> > [auto build test WARNING on mripard/sunxi/for-next]
> > [also build test WARNING on next-20151203]
> > [cannot apply to input/next v4.4-rc4]
> >
> > url: https://github.com/0day-ci/linux/commits/Priit-Laes/input-D
> river-for-Goodix-GT801-2-1-touchscreen/20151207-152831
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/mripard/lin
> ux.git sunxi/for-next
> > :::::: branch date: 46 minutes ago
> > :::::: commit date: 46 minutes ago
> >
> > >> drivers/input/touchscreen/gt801_2plus1.c:119:3-30: code aligned
> with following code on line 120
> >
> > git remote add linux-review https://github.com/0day-ci/linux
> > git remote update linux-review
> > git checkout d66df313f96e04572821e49cada65cb5c1bea9e2
> > vim +119 drivers/input/touchscreen/gt801_2plus1.c
> >
> > d66df313 Priit Laes 2015-12-07 113 return;
> > d66df313 Priit Laes 2015-12-07 114
> > d66df313 Priit Laes 2015-12-07 115 /* Build touch map */
> > d66df313 Priit Laes 2015-12-07 116 touch_num = 0;
> > d66df313 Priit Laes 2015-12-07 117 for (i = 0; (touch_raw != 0)
> && (i < ts->max_touch_num); i++) {
> > d66df313 Priit Laes 2015-12-07 118 if (touch_raw & 1)
> > d66df313 Priit Laes 2015-12-07
> @119 touch_map[touch_num++] = i;
> > d66df313 Priit Laes 2015-12-07 @120 touch_raw >>=
> 1;
> > d66df313 Priit Laes 2015-12-07 121 }
> > d66df313 Priit Laes 2015-12-07 122
> > d66df313 Priit Laes 2015-12-07 123 /* Calculate checksum */
> >
> > ---
> > 0-DAY kernel test infrastructure Open Source
> Technology Center
> > https://lists.01.org/pipermail/kbuild-all ; Intel
> Corporation
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web