Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1284883 > unrolled thread
| Started by | Remi Pommarel <repk@triplefau.lt> |
|---|---|
| First post | 2015-12-06 17:30 +0100 |
| Last post | 2015-12-08 05:10 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v3 4/4] clk: bcm2835: Add PWM clock support to the device tree Remi Pommarel <repk@triplefau.lt> - 2015-12-06 17:30 +0100
Re: [PATCH v3 4/4] clk: bcm2835: Add PWM clock support to the device tree Stefan Wahren <info@lategoodbye.de> - 2015-12-06 22:20 +0100
Re: [PATCH v3 4/4] clk: bcm2835: Add PWM clock support to the device tree Remi Pommarel <repk@triplefau.lt> - 2015-12-07 19:20 +0100
Re: [PATCH v3 4/4] clk: bcm2835: Add PWM clock support to the device tree Stefan Wahren <info@lategoodbye.de> - 2015-12-07 19:50 +0100
Re: [PATCH v3 4/4] clk: bcm2835: Add PWM clock support to the device tree Eric Anholt <eric@anholt.net> - 2015-12-08 05:10 +0100
| From | Remi Pommarel <repk@triplefau.lt> |
|---|---|
| Date | 2015-12-06 17:30 +0100 |
| Subject | [PATCH v3 4/4] clk: bcm2835: Add PWM clock support to the device tree |
| Message-ID | <qCKmd-NF-5@gated-at.bofh.it> |
Signed-off-by: Remi Pommarel <repk@triplefau.lt>
---
arch/arm/boot/dts/bcm2835-rpi.dtsi | 4 ++++
arch/arm/boot/dts/bcm2835.dtsi | 9 +++++++++
2 files changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
index 3572f03..55801e0 100644
--- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
+++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
@@ -60,3 +60,7 @@
status = "okay";
bus-width = <4>;
};
+
+&pwm {
+ status = "okay";
+};
diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
index aef64de..641f7f4 100644
--- a/arch/arm/boot/dts/bcm2835.dtsi
+++ b/arch/arm/boot/dts/bcm2835.dtsi
@@ -149,6 +149,15 @@
status = "disabled";
};
+ pwm: pwm@7e20c000 {
+ compatible = "brcm,bcm2835-pwm";
+ reg = <0x7e20c000 0x28>;
+ clocks = <&clocks BCM2835_CLOCK_PWM>;
+ assigned-clocks = <&clocks BCM2835_CLOCK_PWM>;
+ assigned-clock-rates = <10000000>;
+ status = "disabled";
+ };
+
sdhci: sdhci@7e300000 {
compatible = "brcm,bcm2835-sdhci";
reg = <0x7e300000 0x100>;
--
2.0.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Stefan Wahren <info@lategoodbye.de> |
|---|---|
| Date | 2015-12-06 22:20 +0100 |
| Subject | Re: [PATCH v3 4/4] clk: bcm2835: Add PWM clock support to the device tree |
| Message-ID | <qCOSS-3MT-15@gated-at.bofh.it> |
| In reply to | #1284883 |
Hi Remi,
please send this patch to devicetree@vger.kernel.org.
Am 06.12.2015 um 17:22 schrieb Remi Pommarel:
> Signed-off-by: Remi Pommarel <repk@triplefau.lt>
> ---
> arch/arm/boot/dts/bcm2835-rpi.dtsi | 4 ++++
> arch/arm/boot/dts/bcm2835.dtsi | 9 +++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> index 3572f03..55801e0 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
> +++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> @@ -60,3 +60,7 @@
> status = "okay";
> bus-width = <4>;
> };
> +
> +&pwm {
> + status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> index aef64de..641f7f4 100644
> --- a/arch/arm/boot/dts/bcm2835.dtsi
> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> @@ -149,6 +149,15 @@
> status = "disabled";
> };
>
> + pwm: pwm@7e20c000 {
> + compatible = "brcm,bcm2835-pwm";
> + reg = <0x7e20c000 0x28>;
> + clocks = <&clocks BCM2835_CLOCK_PWM>;
Looks like #pwm-cells is missing.
Regards
Stefan
> + assigned-clocks = <&clocks BCM2835_CLOCK_PWM>;
> + assigned-clock-rates = <10000000>;
> + status = "disabled";
> + };
> +
> sdhci: sdhci@7e300000 {
> compatible = "brcm,bcm2835-sdhci";
> reg = <0x7e300000 0x100>;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Remi Pommarel <repk@triplefau.lt> |
|---|---|
| Date | 2015-12-07 19:20 +0100 |
| Subject | Re: [PATCH v3 4/4] clk: bcm2835: Add PWM clock support to the device tree |
| Message-ID | <qD8ye-85F-11@gated-at.bofh.it> |
| In reply to | #1284919 |
Hi Stefan,
On Sun, Dec 06, 2015 at 10:16:25PM +0100, Stefan Wahren wrote:
> Hi Remi,
>
> please send this patch to devicetree@vger.kernel.org.
Ok, just to be sure I understand the process here. I should resend a new
version of the whole patchset including the devicetree mailing list as
recipent. Then the first 3 patches will eventually get pushed by a clock
subsystem maintainer. And finally this last patch will be pushed by a
devicetree maintainer.
Am I right here ?
>
> Am 06.12.2015 um 17:22 schrieb Remi Pommarel:
> >Signed-off-by: Remi Pommarel <repk@triplefau.lt>
> >---
> > arch/arm/boot/dts/bcm2835-rpi.dtsi | 4 ++++
> > arch/arm/boot/dts/bcm2835.dtsi | 9 +++++++++
> > 2 files changed, 13 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> >index 3572f03..55801e0 100644
> >--- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
> >+++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> >@@ -60,3 +60,7 @@
> > status = "okay";
> > bus-width = <4>;
> > };
> >+
> >+&pwm {
> >+ status = "okay";
> >+};
> >diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> >index aef64de..641f7f4 100644
> >--- a/arch/arm/boot/dts/bcm2835.dtsi
> >+++ b/arch/arm/boot/dts/bcm2835.dtsi
> >@@ -149,6 +149,15 @@
> > status = "disabled";
> > };
> >
> >+ pwm: pwm@7e20c000 {
> >+ compatible = "brcm,bcm2835-pwm";
> >+ reg = <0x7e20c000 0x28>;
> >+ clocks = <&clocks BCM2835_CLOCK_PWM>;
>
> Looks like #pwm-cells is missing.
>
Yes will do. Thank you.
Regards
--
Remi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Stefan Wahren <info@lategoodbye.de> |
|---|---|
| Date | 2015-12-07 19:50 +0100 |
| Subject | Re: [PATCH v3 4/4] clk: bcm2835: Add PWM clock support to the device tree |
| Message-ID | <qD91g-8hb-17@gated-at.bofh.it> |
| In reply to | #1285838 |
Hi Remi, Am 07.12.2015 um 19:17 schrieb Remi Pommarel: > Hi Stefan, > > On Sun, Dec 06, 2015 at 10:16:25PM +0100, Stefan Wahren wrote: >> Hi Remi, >> >> please send this patch to devicetree@vger.kernel.org. > > Ok, just to be sure I understand the process here. I should resend a new > version of the whole patchset including the devicetree mailing list as > recipent. Then the first 3 patches will eventually get pushed by a clock > subsystem maintainer. And finally this last patch will be pushed by a > devicetree maintainer. > > Am I right here ? sorry for the confusion. I mean that you send a copy to devicetree@vger.kernel.org so subscribers have a chance to review. I'm not sure but according to your subject you suggest that this dts patch should go through clock subsystem which isn't optimal. This should be better applied by Stephen or Eric. Best regards Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Eric Anholt <eric@anholt.net> |
|---|---|
| Date | 2015-12-08 05:10 +0100 |
| Message-ID | <qDhLc-5Ko-15@gated-at.bofh.it> |
| In reply to | #1285856 |
[Multipart message — attachments visible in raw view] — view raw
Stefan Wahren <info@lategoodbye.de> writes: > Hi Remi, > > Am 07.12.2015 um 19:17 schrieb Remi Pommarel: >> Hi Stefan, >> >> On Sun, Dec 06, 2015 at 10:16:25PM +0100, Stefan Wahren wrote: >>> Hi Remi, >>> >>> please send this patch to devicetree@vger.kernel.org. >> >> Ok, just to be sure I understand the process here. I should resend a new >> version of the whole patchset including the devicetree mailing list as >> recipent. Then the first 3 patches will eventually get pushed by a clock >> subsystem maintainer. And finally this last patch will be pushed by a >> devicetree maintainer. >> >> Am I right here ? > > sorry for the confusion. I mean that you send a copy to > devicetree@vger.kernel.org so subscribers have a chance to review. > > I'm not sure but according to your subject you suggest that this dts > patch should go through clock subsystem which isn't optimal. This should > be better applied by Stephen or Eric. It would be applied by me, but that's for me to worry about, not the patch submitter. The subject prefix would be "ARM: bcm2835: ", but that's trivial for me to fix when applying, not the kind of thing worth asking for a respin for.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web