Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1284316 > unrolled thread
| Started by | Ashok Raj <ashok.raj@intel.com> |
|---|---|
| First post | 2015-12-05 00:00 +0100 |
| Last post | 2015-12-05 00:20 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[Patch V1] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. Ashok Raj <ashok.raj@intel.com> - 2015-12-05 00:00 +0100
Re: [Patch V1] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. Borislav Petkov <bp@suse.de> - 2015-12-05 00:10 +0100
RE: [Patch V1] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. "Luck, Tony" <tony.luck@intel.com> - 2015-12-05 00:20 +0100
Re: [Patch V1] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. Borislav Petkov <bp@suse.de> - 2015-12-05 00:20 +0100
| From | Ashok Raj <ashok.raj@intel.com> |
|---|---|
| Date | 2015-12-05 00:00 +0100 |
| Subject | [Patch V1] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. |
| Message-ID | <qC7uy-ox-9@gated-at.bofh.it> |
Linux has logical cpu offline capability. That can be triggered by:
# echo 0 > /sys/devices/system/cpu/cpuX/online
In Intel Architecture, MCE's are broadcasted to all CPUs in the system.
This includes the CPUs marked offline by Linux. Unless the CPU's were removed
via an ACPI notification, in which case the cpu's are removed from the
cpu_present_map.
This patch ensures offline CPU's don't participate in MCE rendezvous, but
simply perform clearing some status bits to ensure a second MCE wont cause
automatic shutdown.
Without the patch, mce_start will increment mce_callin, but mce_start would
only wait for all online_cpus. So offline cpu's should avoid participating
in the rendezvous process.
Reviewed-by: Tony Luck <tony.luck@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
---
arch/x86/kernel/cpu/mcheck/mce.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index c5b0d56..72ea044 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -998,7 +998,20 @@ void do_machine_check(struct pt_regs *regs, long error_code)
u64 recover_paddr = ~0ull;
int flags = MF_ACTION_REQUIRED;
int lmce = 0;
+ unsigned int cpu = smp_processor_id();
+ /*
+ * if this cpu is offline, just bail out.
+ */
+ if (cpu_is_offline(cpu)) {
+ u64 mcgstatus;
+
+ mcgstatus = mce_rdmsrl(MSR_IA32_MCG_STATUS);
+ if (mcgstatus & MCG_STATUS_RIPV) {
+ mce_wrmsrl(MSR_IA32_MCG_STATUS, 0);
+ return;
+ }
+ }
ist_enter(regs);
this_cpu_inc(mce_exception_count);
@@ -1142,8 +1155,8 @@ void do_machine_check(struct pt_regs *regs, long error_code)
if (worst > 0)
mce_report_event(regs);
- mce_wrmsrl(MSR_IA32_MCG_STATUS, 0);
out:
+ mce_wrmsrl(MSR_IA32_MCG_STATUS, 0);
sync_core();
if (recover_paddr == ~0ull)
--
2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Borislav Petkov <bp@suse.de> |
|---|---|
| Date | 2015-12-05 00:10 +0100 |
| Subject | Re: [Patch V1] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. |
| Message-ID | <qC7Ee-I7-3@gated-at.bofh.it> |
| In reply to | #1284316 |
On Fri, Dec 04, 2015 at 06:57:31PM -0500, Ashok Raj wrote:
> Linux has logical cpu offline capability. That can be triggered by:
>
> # echo 0 > /sys/devices/system/cpu/cpuX/online
>
> In Intel Architecture, MCE's are broadcasted to all CPUs in the system.
>
> This includes the CPUs marked offline by Linux. Unless the CPU's were removed
> via an ACPI notification, in which case the cpu's are removed from the
> cpu_present_map.
>
> This patch ensures offline CPU's don't participate in MCE rendezvous, but
> simply perform clearing some status bits to ensure a second MCE wont cause
> automatic shutdown.
>
> Without the patch, mce_start will increment mce_callin, but mce_start would
> only wait for all online_cpus. So offline cpu's should avoid participating
> in the rendezvous process.
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Ashok Raj <ashok.raj@intel.com>
> ---
> arch/x86/kernel/cpu/mcheck/mce.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
> index c5b0d56..72ea044 100644
> --- a/arch/x86/kernel/cpu/mcheck/mce.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce.c
> @@ -998,7 +998,20 @@ void do_machine_check(struct pt_regs *regs, long error_code)
> u64 recover_paddr = ~0ull;
> int flags = MF_ACTION_REQUIRED;
> int lmce = 0;
> + unsigned int cpu = smp_processor_id();
>
> + /*
> + * if this cpu is offline, just bail out.
> + */
> + if (cpu_is_offline(cpu)) {
> + u64 mcgstatus;
> +
> + mcgstatus = mce_rdmsrl(MSR_IA32_MCG_STATUS);
> + if (mcgstatus & MCG_STATUS_RIPV) {
> + mce_wrmsrl(MSR_IA32_MCG_STATUS, 0);
> + return;
> + }
> + }
> ist_enter(regs);
>
> this_cpu_inc(mce_exception_count);
> @@ -1142,8 +1155,8 @@ void do_machine_check(struct pt_regs *regs, long error_code)
>
> if (worst > 0)
> mce_report_event(regs);
> - mce_wrmsrl(MSR_IA32_MCG_STATUS, 0);
> out:
> + mce_wrmsrl(MSR_IA32_MCG_STATUS, 0);
> sync_core();
>
> if (recover_paddr == ~0ull)
> --
With that hunk here you want to clear MSR_IA32_MCG_STATUS in the
!cfg->banks case, right?
If so, this should be a separate patch. Also, CC: stable with an
explanation why.
Thanks.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Luck, Tony" <tony.luck@intel.com> |
|---|---|
| Date | 2015-12-05 00:20 +0100 |
| Subject | RE: [Patch V1] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. |
| Message-ID | <qC7NT-MQ-5@gated-at.bofh.it> |
| In reply to | #1284318 |
PiBXaXRoIHRoYXQgaHVuayBoZXJlIHlvdSB3YW50IHRvIGNsZWFyIE1TUl9JQTMyX01DR19TVEFU VVMgaW4gdGhlDQo+ICFjZmctPmJhbmtzIGNhc2UsIHJpZ2h0Pw0KDQpJIGNhbid0IGltYWdpbmUg aG93IHdlJ2QgZ2V0IGludG8gZG9fbWFjaGluZV9jaGVjayB3aXRob3V0IGFueSBiYW5rcy4NCg0K V291bGQgaW5kZWVkIGJlIGEgc2VwYXJhdGUgcGF0Y2ggLi4uIGJ1dCB2YWx1ZSBzZWVtcyBsaW1p dGVkLg0KDQotVG9ueQ0KIA0K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Borislav Petkov <bp@suse.de> |
|---|---|
| Date | 2015-12-05 00:20 +0100 |
| Subject | Re: [Patch V1] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process. |
| Message-ID | <qC7NU-MQ-29@gated-at.bofh.it> |
| In reply to | #1284323 |
On Fri, Dec 04, 2015 at 11:11:12PM +0000, Luck, Tony wrote:
> > With that hunk here you want to clear MSR_IA32_MCG_STATUS in the
> > !cfg->banks case, right?
>
> I can't imagine how we'd get into do_machine_check without any banks.
>
> Would indeed be a separate patch ... but value seems limited.
Then we should kill that hunk. I'm all for not covering improbable
cases.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web