Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1282751 > unrolled thread

[PATCH v3 5/7] mm/compaction: respect compaction order when updating defer counter

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v3 5/7] mm/compaction: respect compaction order when updating defer counter Joonsoo Kim <js1304@gmail.com> - 2015-12-03 08:20 +0100
    Re: [PATCH v3 5/7] mm/compaction: respect compaction order when  updating defer counter Vlastimil Babka <vbabka@suse.cz> - 2015-12-04 18:20 +0100
      Re: [PATCH v3 5/7] mm/compaction: respect compaction order when  updating defer counter Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-12-07 09:10 +0100

#1282751 — [PATCH v3 5/7] mm/compaction: respect compaction order when updating defer counter

It doesn't make sense that we reset defer counter
in compaction_defer_reset() when compaction request under the order of
compact_order_failed succeed. Fix it.

And, it does make sense that giving enough chance for updated failed
order compaction before deferring. Change it.

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
 mm/compaction.c | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 67b8d90..1a75a6e 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -126,11 +126,14 @@ static struct page *pageblock_pfn_to_page(unsigned long start_pfn,
  */
 static void defer_compaction(struct zone *zone, int order)
 {
-	zone->compact_considered = 0;
-	zone->compact_defer_shift++;
-
-	if (order < zone->compact_order_failed)
+	if (order < zone->compact_order_failed) {
+		zone->compact_considered = 0;
+		zone->compact_defer_shift = 0;
 		zone->compact_order_failed = order;
+	} else {
+		zone->compact_considered = 0;
+		zone->compact_defer_shift++;
+	}
 
 	if (zone->compact_defer_shift > COMPACT_MAX_DEFER_SHIFT)
 		zone->compact_defer_shift = COMPACT_MAX_DEFER_SHIFT;
@@ -161,11 +164,11 @@ bool compaction_deferred(struct zone *zone, int order)
 /* Update defer tracking counters after successful compaction of given order */
 static void compaction_defer_reset(struct zone *zone, int order)
 {
-	zone->compact_considered = 0;
-	zone->compact_defer_shift = 0;
-
-	if (order >= zone->compact_order_failed)
+	if (order >= zone->compact_order_failed) {
+		zone->compact_considered = 0;
+		zone->compact_defer_shift = 0;
 		zone->compact_order_failed = order + 1;
+	}
 
 	trace_mm_compaction_defer_reset(zone, order);
 }
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1284068 — Re: [PATCH v3 5/7] mm/compaction: respect compaction order when updating defer counter

On 12/03/2015 08:11 AM, Joonsoo Kim wrote:
> It doesn't make sense that we reset defer counter
> in compaction_defer_reset() when compaction request under the order of
> compact_order_failed succeed. Fix it.

Right.

> And, it does make sense that giving enough chance for updated failed
> order compaction before deferring. Change it.

Sorry, can't understand the meaning here. From the code it seems that 
you want to reset defer_shift to 0 instead of increasing it, when the 
current order is lower than the failed one? That makes sense, yeah.
How about this?

"On the other hand, when deferring compaction for an order lower than 
the current compact_order_failed, we can assume the lower order will 
recover more quickly, so we should reset the progress made previously on 
compact_defer_shift with the higher order."

> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
>   mm/compaction.c | 19 +++++++++++--------
>   1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 67b8d90..1a75a6e 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -126,11 +126,14 @@ static struct page *pageblock_pfn_to_page(unsigned long start_pfn,
>    */
>   static void defer_compaction(struct zone *zone, int order)
>   {
> -	zone->compact_considered = 0;
> -	zone->compact_defer_shift++;
> -
> -	if (order < zone->compact_order_failed)
> +	if (order < zone->compact_order_failed) {
> +		zone->compact_considered = 0;
> +		zone->compact_defer_shift = 0;
>   		zone->compact_order_failed = order;
> +	} else {
> +		zone->compact_considered = 0;
> +		zone->compact_defer_shift++;
> +	}
>
>   	if (zone->compact_defer_shift > COMPACT_MAX_DEFER_SHIFT)
>   		zone->compact_defer_shift = COMPACT_MAX_DEFER_SHIFT;
> @@ -161,11 +164,11 @@ bool compaction_deferred(struct zone *zone, int order)
>   /* Update defer tracking counters after successful compaction of given order */
>   static void compaction_defer_reset(struct zone *zone, int order)
>   {
> -	zone->compact_considered = 0;
> -	zone->compact_defer_shift = 0;
> -
> -	if (order >= zone->compact_order_failed)
> +	if (order >= zone->compact_order_failed) {
> +		zone->compact_considered = 0;
> +		zone->compact_defer_shift = 0;
>   		zone->compact_order_failed = order + 1;
> +	}
>
>   	trace_mm_compaction_defer_reset(zone, order);
>   }
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1285067 — Re: [PATCH v3 5/7] mm/compaction: respect compaction order when updating defer counter

On Fri, Dec 04, 2015 at 06:15:02PM +0100, Vlastimil Babka wrote:
> On 12/03/2015 08:11 AM, Joonsoo Kim wrote:
> >It doesn't make sense that we reset defer counter
> >in compaction_defer_reset() when compaction request under the order of
> >compact_order_failed succeed. Fix it.
> 
> Right.
> 
> >And, it does make sense that giving enough chance for updated failed
> >order compaction before deferring. Change it.
> 
> Sorry, can't understand the meaning here. From the code it seems
> that you want to reset defer_shift to 0 instead of increasing it,
> when the current order is lower than the failed one? That makes
> sense, yeah.

You correctly understand my intention. :)

> How about this?
> 
> "On the other hand, when deferring compaction for an order lower
> than the current compact_order_failed, we can assume the lower order
> will recover more quickly, so we should reset the progress made
> previously on compact_defer_shift with the higher order."

Will add it.

> 
> >Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> 
> Acked-by: Vlastimil Babka <vbabka@suse.cz>

Thanks.
> 
> >---
> >  mm/compaction.c | 19 +++++++++++--------
> >  1 file changed, 11 insertions(+), 8 deletions(-)
> >
> >diff --git a/mm/compaction.c b/mm/compaction.c
> >index 67b8d90..1a75a6e 100644
> >--- a/mm/compaction.c
> >+++ b/mm/compaction.c
> >@@ -126,11 +126,14 @@ static struct page *pageblock_pfn_to_page(unsigned long start_pfn,
> >   */
> >  static void defer_compaction(struct zone *zone, int order)
> >  {
> >-	zone->compact_considered = 0;
> >-	zone->compact_defer_shift++;
> >-
> >-	if (order < zone->compact_order_failed)
> >+	if (order < zone->compact_order_failed) {
> >+		zone->compact_considered = 0;
> >+		zone->compact_defer_shift = 0;
> >  		zone->compact_order_failed = order;
> >+	} else {
> >+		zone->compact_considered = 0;
> >+		zone->compact_defer_shift++;
> >+	}
> >
> >  	if (zone->compact_defer_shift > COMPACT_MAX_DEFER_SHIFT)
> >  		zone->compact_defer_shift = COMPACT_MAX_DEFER_SHIFT;
> >@@ -161,11 +164,11 @@ bool compaction_deferred(struct zone *zone, int order)
> >  /* Update defer tracking counters after successful compaction of given order */
> >  static void compaction_defer_reset(struct zone *zone, int order)
> >  {
> >-	zone->compact_considered = 0;
> >-	zone->compact_defer_shift = 0;
> >-
> >-	if (order >= zone->compact_order_failed)
> >+	if (order >= zone->compact_order_failed) {
> >+		zone->compact_considered = 0;
> >+		zone->compact_defer_shift = 0;
> >  		zone->compact_order_failed = order + 1;
> >+	}
> >
> >  	trace_mm_compaction_defer_reset(zone, order);
> >  }
> >
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web