Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1280813 > unrolled thread

[PATCH] mmc: mediatek: change some dev_err to dev_dbg

Back to article view | Back to linux.kernel

Contents

  [PATCH] mmc: mediatek: change some dev_err to dev_dbg Chaotian Jing <chaotian.jing@mediatek.com> - 2015-12-01 13:20 +0100
    Re: [PATCH] mmc: mediatek: change some dev_err to dev_dbg Ulf Hansson <ulf.hansson@linaro.org> - 2015-12-04 16:00 +0100

#1280813 — [PATCH] mmc: mediatek: change some dev_err to dev_dbg

there are too many error logs shown when use CMD21/CMD19 to do tune,
and it will appear at each resume time, print out so many logs to the
uart console cost too mush time. so change it to dev_dbg.

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 drivers/mmc/host/mtk-sd.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 39568cc..34d23b8 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -972,7 +972,7 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
 		if ((events & MSDC_INT_XFER_COMPL) && (!stop || !stop->error)) {
 			data->bytes_xfered = data->blocks * data->blksz;
 		} else {
-			dev_err(host->dev, "interrupt events: %x\n", events);
+			dev_dbg(host->dev, "interrupt events: %x\n", events);
 			msdc_reset_hw(host);
 			host->error |= REQ_DAT_ERR;
 			data->bytes_xfered = 0;
@@ -982,10 +982,10 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
 			else if (events & MSDC_INT_DATCRCERR)
 				data->error = -EILSEQ;
 
-			dev_err(host->dev, "%s: cmd=%d; blocks=%d",
+			dev_dbg(host->dev, "%s: cmd=%d; blocks=%d",
 				__func__, mrq->cmd->opcode, data->blocks);
-			dev_err(host->dev, "data_error=%d xfer_size=%d\n",
-					(int)data->error, data->bytes_xfered);
+			dev_dbg(host->dev, "data_error=%d xfer_size=%d\n",
+				(int)data->error, data->bytes_xfered);
 		}
 
 		msdc_data_xfer_next(host, mrq, data);
-- 
1.8.1.1.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1283888

On 1 December 2015 at 13:12, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> there are too many error logs shown when use CMD21/CMD19 to do tune,
> and it will appear at each resume time, print out so many logs to the
> uart console cost too mush time. so change it to dev_dbg.
>
> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>

This one didn't apply to my next branch. Can you please rebase.

Kind regards
Uffe

> ---
>  drivers/mmc/host/mtk-sd.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 39568cc..34d23b8 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -972,7 +972,7 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
>                 if ((events & MSDC_INT_XFER_COMPL) && (!stop || !stop->error)) {
>                         data->bytes_xfered = data->blocks * data->blksz;
>                 } else {
> -                       dev_err(host->dev, "interrupt events: %x\n", events);
> +                       dev_dbg(host->dev, "interrupt events: %x\n", events);
>                         msdc_reset_hw(host);
>                         host->error |= REQ_DAT_ERR;
>                         data->bytes_xfered = 0;
> @@ -982,10 +982,10 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
>                         else if (events & MSDC_INT_DATCRCERR)
>                                 data->error = -EILSEQ;
>
> -                       dev_err(host->dev, "%s: cmd=%d; blocks=%d",
> +                       dev_dbg(host->dev, "%s: cmd=%d; blocks=%d",
>                                 __func__, mrq->cmd->opcode, data->blocks);
> -                       dev_err(host->dev, "data_error=%d xfer_size=%d\n",
> -                                       (int)data->error, data->bytes_xfered);
> +                       dev_dbg(host->dev, "data_error=%d xfer_size=%d\n",
> +                               (int)data->error, data->bytes_xfered);
>                 }
>
>                 msdc_data_xfer_next(host, mrq, data);
> --
> 1.8.1.1.dirty
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web