Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1282885 > unrolled thread
| Started by | Ley Foon Tan <lftan@altera.com> |
|---|---|
| First post | 2015-12-03 11:00 +0100 |
| Last post | 2015-12-03 11:50 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/3] fixes to support multi-functions device Ley Foon Tan <lftan@altera.com> - 2015-12-03 11:00 +0100
[PATCH 3/3] PCI: altera: fix error when INTX is 4 Ley Foon Tan <lftan@altera.com> - 2015-12-03 11:20 +0100
Re: [PATCH 0/3] fixes to support multi-functions device Ley Foon Tan <lftan.linux@gmail.com> - 2015-12-03 11:50 +0100
| From | Ley Foon Tan <lftan@altera.com> |
|---|---|
| Date | 2015-12-03 11:00 +0100 |
| Subject | [PATCH 0/3] fixes to support multi-functions device |
| Message-ID | <qByQa-3g4-11@gated-at.bofh.it> |
This series of patch fixes the issues when work with multi-functions PCIe devices. Host controller can't access to endpoint with non-zero devfn, due to incorrect rootport devfn. It also add checking for TLP status and fix issue in interrupt probing. Tested on Ethernet adapter card with multi-functions enabled. Ley Foon Tan (3): PCI: altera: fix incorrect devfn for requester ID PCI: altera: check TLP completion status PCI: altera: fix error when INTX is 4 drivers/pci/host/pcie-altera.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) -- 1.8.2.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Ley Foon Tan <lftan@altera.com> |
|---|---|
| Date | 2015-12-03 11:20 +0100 |
| Subject | [PATCH 3/3] PCI: altera: fix error when INTX is 4 |
| Message-ID | <qBz9v-3CM-7@gated-at.bofh.it> |
| In reply to | #1282885 |
PCI interrupt lines start at 1, not at 0. So, change INTX_NUM to 5. Error when PCIe devices have 4 INTX: WARNING: CPU: 1 PID: 1 at kernel/irq/irqdomain.c:280 irq_domain_associate+0x17c/0x1cc() error: hwirq 0x4 is too large for dummy Tested on Ethernet adapter card with multi-functions. Signed-off-by: Ley Foon Tan <lftan@altera.com> --- drivers/pci/host/pcie-altera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c index e4176b3..8b30d4a 100644 --- a/drivers/pci/host/pcie-altera.c +++ b/drivers/pci/host/pcie-altera.c @@ -60,7 +60,7 @@ #define TLP_LOOP 500 #define RP_DEVFN 0 -#define INTX_NUM 4 +#define INTX_NUM 5 #define DWORD_MASK 3 -- 1.8.2.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ley Foon Tan <lftan.linux@gmail.com> |
|---|---|
| Date | 2015-12-03 11:50 +0100 |
| Message-ID | <qBzCy-3N9-3@gated-at.bofh.it> |
| In reply to | #1282885 |
On Thu, Dec 3, 2015 at 5:54 PM, Ley Foon Tan <lftan@altera.com> wrote: > This series of patch fixes the issues when work with multi-functions PCIe > devices. Host controller can't access to endpoint with non-zero devfn, due to > incorrect rootport devfn. It also add checking for TLP status and fix issue in > interrupt probing. > > Tested on Ethernet adapter card with multi-functions enabled. > > Ley Foon Tan (3): > PCI: altera: fix incorrect devfn for requester ID > PCI: altera: check TLP completion status > PCI: altera: fix error when INTX is 4 > > drivers/pci/host/pcie-altera.c | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-) > Hi Sorry, please ignore this patchset, Will resend again. Thanks. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web