Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1282350 > unrolled thread

Re: [PATCH 0/4] dm verity: add support for error correction

Started byMike Snitzer <snitzer@redhat.com>
First post2015-12-02 21:30 +0100
Last post2015-12-03 10:20 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 0/4] dm verity: add support for error correction Mike Snitzer <snitzer@redhat.com> - 2015-12-02 21:30 +0100
    Re: [PATCH 0/4] dm verity: add support for error correction Sami Tolvanen <samitolvanen@google.com> - 2015-12-03 10:20 +0100

#1282350 — Re: [PATCH 0/4] dm verity: add support for error correction

FromMike Snitzer <snitzer@redhat.com>
Date2015-12-02 21:30 +0100
SubjectRe: [PATCH 0/4] dm verity: add support for error correction
Message-ID<qBmci-3CV-11@gated-at.bofh.it>
On Mon, Nov 09 2015 at  2:19P -0500,
Sami Tolvanen <samitolvanen@google.com> wrote:

> On Mon, Nov 09, 2015 at 11:37:35AM -0500, Mike Snitzer wrote:
> > I'm left wondering: can the new error correction code be made an
> > optional feature that is off by default? -- so as to preserve some
> > isolation of this new code from the old dm-verity behaviour.
> 
> It's optional in the sense that you must specify error correction
> parameters in the table to turn it on. Otherwise, verity_dec_decode
> returns -1 and dm-verity handles errors as before.
> 
> > might be good to add a wrapper like verity_fec_is_enabled().
> 
> Sure. I can do this in v2 and address the other feedback and build
> issues as well.

Hi Sami,

Any progress on v2 that takes into account previous review feedback?

Note I've staged the first 2 patches in this series for Linux 4.5
inclusion, see:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-4.5

Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1282829

FromSami Tolvanen <samitolvanen@google.com>
Date2015-12-03 10:20 +0100
Message-ID<qBydr-30n-1@gated-at.bofh.it>
In reply to#1282350
On Wed, Dec 02, 2015 at 03:22:03PM -0500, Mike Snitzer wrote:
> Any progress on v2 that takes into account previous review feedback?

Yes. Sorry for the delay, the changes have gone through a couple of rounds
of internal reviews and testing first.

> Note I've staged the first 2 patches in this series for Linux 4.5
> inclusion

Great, thanks. I'll send v2 rebased on top of these today.

Sami
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web