Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1280147 > unrolled thread
| Started by | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> |
|---|---|
| First post | 2015-11-30 19:10 +0100 |
| Last post | 2015-12-03 01:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Input: arizona-haptic: Correct disable of haptics device Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-11-30 19:10 +0100
Re: [PATCH] Input: arizona-haptic: Correct disable of haptics device Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-12-03 01:20 +0100
| From | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> |
|---|---|
| Date | 2015-11-30 19:10 +0100 |
| Subject | [PATCH] Input: arizona-haptic: Correct disable of haptics device |
| Message-ID | <qAB3I-739-15@gated-at.bofh.it> |
A small copy and paste error was preventing the haptics device being
disabled. This patch corrects the value written on disable.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/input/misc/arizona-haptics.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/input/misc/arizona-haptics.c b/drivers/input/misc/arizona-haptics.c
index 4bf6785..d5994a7 100644
--- a/drivers/input/misc/arizona-haptics.c
+++ b/drivers/input/misc/arizona-haptics.c
@@ -97,8 +97,7 @@ static void arizona_haptics_work(struct work_struct *work)
ret = regmap_update_bits(arizona->regmap,
ARIZONA_HAPTICS_CONTROL_1,
- ARIZONA_HAP_CTRL_MASK,
- 1 << ARIZONA_HAP_CTRL_SHIFT);
+ ARIZONA_HAP_CTRL_MASK, 0);
if (ret != 0) {
dev_err(arizona->dev, "Failed to stop haptics: %d\n",
ret);
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2015-12-03 01:20 +0100 |
| Message-ID | <qBpMR-5Y5-5@gated-at.bofh.it> |
| In reply to | #1280147 |
On Mon, Nov 30, 2015 at 06:02:20PM +0000, Charles Keepax wrote:
> A small copy and paste error was preventing the haptics device being
> disabled. This patch corrects the value written on disable.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Applied, thank you.
> ---
> drivers/input/misc/arizona-haptics.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/arizona-haptics.c b/drivers/input/misc/arizona-haptics.c
> index 4bf6785..d5994a7 100644
> --- a/drivers/input/misc/arizona-haptics.c
> +++ b/drivers/input/misc/arizona-haptics.c
> @@ -97,8 +97,7 @@ static void arizona_haptics_work(struct work_struct *work)
>
> ret = regmap_update_bits(arizona->regmap,
> ARIZONA_HAPTICS_CONTROL_1,
> - ARIZONA_HAP_CTRL_MASK,
> - 1 << ARIZONA_HAP_CTRL_SHIFT);
> + ARIZONA_HAP_CTRL_MASK, 0);
> if (ret != 0) {
> dev_err(arizona->dev, "Failed to stop haptics: %d\n",
> ret);
> --
> 2.1.4
>
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web