Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1282453 > unrolled thread
| Started by | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| First post | 2015-12-02 23:00 +0100 |
| Last post | 2015-12-02 23:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] usb: ehci: ohci: use true/false for bool Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-02 23:00 +0100
Re: [PATCH] usb: ehci: ohci: use true/false for bool "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-02 23:10 +0100
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-12-02 23:00 +0100 |
| Subject | Re: [PATCH] usb: ehci: ohci: use true/false for bool |
| Message-ID | <qBnBo-4pb-3@gated-at.bofh.it> |
On Wed, Dec 02, 2015 at 06:50:41PM -0300, Geyslan G. Bem wrote: > When bool use true or false instead of 1 or 0. > > Caught by coccinelle. > > Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> > --- > drivers/usb/host/ehci-hcd.c | 2 +- > drivers/usb/host/ohci-hcd.c | 4 ++-- > drivers/usb/host/u132-hcd.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > index 48c92bf..1b01967 100644 > --- a/drivers/usb/host/ehci-hcd.c > +++ b/drivers/usb/host/ehci-hcd.c > @@ -98,7 +98,7 @@ module_param (park, uint, S_IRUGO); > MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets"); > > /* for flakey hardware, ignore overcurrent indicators */ > -static bool ignore_oc = 0; > +static bool ignore_oc = false; No need to set this to "0/false" as that's what the default is. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Geyslan G. Bem" <geyslan@gmail.com> |
|---|---|
| Date | 2015-12-02 23:10 +0100 |
| Message-ID | <qBnL4-4Iv-19@gated-at.bofh.it> |
| In reply to | #1282453 |
2015-12-02 18:58 GMT-03:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>: > On Wed, Dec 02, 2015 at 06:50:41PM -0300, Geyslan G. Bem wrote: >> When bool use true or false instead of 1 or 0. >> >> Caught by coccinelle. >> >> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> >> --- >> drivers/usb/host/ehci-hcd.c | 2 +- >> drivers/usb/host/ohci-hcd.c | 4 ++-- >> drivers/usb/host/u132-hcd.c | 2 +- >> 3 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c >> index 48c92bf..1b01967 100644 >> --- a/drivers/usb/host/ehci-hcd.c >> +++ b/drivers/usb/host/ehci-hcd.c >> @@ -98,7 +98,7 @@ module_param (park, uint, S_IRUGO); >> MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets"); >> >> /* for flakey hardware, ignore overcurrent indicators */ >> -static bool ignore_oc = 0; >> +static bool ignore_oc = false; > > No need to set this to "0/false" as that's what the default is. > > thanks, > > greg k-h Thanks Greg, sending v2. -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web