Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281118 > unrolled thread
| Started by | Jason Gunthorpe <jgunthorpe@obsidianresearch.com> |
|---|---|
| First post | 2015-12-01 20:00 +0100 |
| Last post | 2015-12-02 19:20 +0100 |
| Articles | 7 on this page of 47 — 7 participants |
Back to article view | Back to linux.kernel
[PATCH v2 0/3] tpm_tis: Clean up force module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 20:00 +0100
[PATCH v2 3/3] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 20:00 +0100
Re: [PATCH v2 3/3] tpm_tis: Clean up the force=1 module parameter Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-12-01 20:40 +0100
Re: [PATCH v2 3/3] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 21:00 +0100
[PATCH v2 1/3] tpm_tis: Disable interrupt auto probing on a per-device basis Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 20:00 +0100
Re: [PATCH v2 1/3] tpm_tis: Disable interrupt auto probing on a per-device basis Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-12-01 20:20 +0100
Re: [PATCH v2 1/3] tpm_tis: Disable interrupt auto probing on a per-device basis Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 20:40 +0100
[PATCH v2 2/3] tpm_tis: Use devm_ioremap_resource Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 20:00 +0100
Re: [PATCH v2 2/3] tpm_tis: Use devm_ioremap_resource Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-12-01 20:30 +0100
Re: [PATCH v2 2/3] tpm_tis: Use devm_ioremap_resource Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 20:50 +0100
Re: [PATCH v2 2/3] tpm_tis: Use devm_ioremap_resource Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-12-01 21:00 +0100
Re: [PATCH v2 2/3] tpm_tis: Use devm_ioremap_resource Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-01 22:00 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-01 22:20 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-01 22:40 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-02 00:10 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Peter Huewe <peterhuewe@gmx.de> - 2015-12-02 02:20 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-02 09:20 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Peter Huewe <peterhuewe@gmx.de> - 2015-12-02 10:20 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-02 09:20 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-12-02 09:30 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-02 18:00 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-12-02 18:10 +0100
[PATCH v3] base/platform: fix binding for drivers without probe callback martin.wilck@ts.fujitsu.com - 2015-12-03 10:00 +0100
Re: [PATCH v3] base/platform: fix binding for drivers without probe callback Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-12-03 10:10 +0100
Re: [tpmdd-devel] [PATCH v3] base/platform: fix binding for drivers without probe callback Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-03 10:40 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-02 19:30 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-02 20:20 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-03 07:10 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-03 19:20 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-06 05:10 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-06 05:20 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-06 05:30 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-07 07:20 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter "Wilck, Martin" <martin.wilck@ts.fujitsu.com> - 2015-12-07 09:10 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-07 10:00 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter "Wilck, Martin" <martin.wilck@ts.fujitsu.com> - 2015-12-07 11:00 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-07 11:20 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter "Wilck, Martin" <martin.wilck@ts.fujitsu.com> - 2015-12-03 09:40 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-03 18:10 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter "Wilck, Martin" <martin.wilck@ts.fujitsu.com> - 2015-12-04 09:40 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter "Wilck, Martin" <martin.wilck@ts.fujitsu.com> - 2015-12-04 10:20 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-04 19:10 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter "Wilck, Martin" <martin.wilck@ts.fujitsu.com> - 2015-12-07 11:00 +0100
Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-07 18:40 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-12-03 07:00 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter "Wilck, Martin" <martin.wilck@ts.fujitsu.com> - 2015-12-02 13:40 +0100
Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-12-02 19:20 +0100
Page 3 of 3 — ← Prev page 1 2 [3]
| From | "Wilck, Martin" <martin.wilck@ts.fujitsu.com> |
|---|---|
| Date | 2015-12-04 10:20 +0100 |
| Subject | Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter |
| Message-ID | <qBUH1-Lu-19@gated-at.bofh.it> |
| In reply to | #1283196 |
PiA+IEFDUEkgZGVmaW5lcyBhIG1lbSByZXNvdXJjZSBjb3JyZXNwb25kaW5nIHRvIHRoZSBzdGFu ZGFyZCBUSVMgbWVtb3J5Cj4gPiBhcmVhIG9uIG15IHN5c3RlbSwgYW5kIGl0IHVzZWQgdG8gYmUg ZGV0ZWN0ZWQgZmluZSB3aXRoIEphcmtrbydzIHBhdGNoLgo+ID4gU29tZWhvdyB5b3VyIGxhdGVz dCBjaGFuZ2VzIGJyb2tlIGl0LCBub3Qgc3VyZSB3aHkuCj4gCj4gQXJlIHlvdSBjZXJ0YWluPyBC YXNlZCBvbiB3aGF0IHlvdSBzZW50IG1lLCB0aGF0IG91dHB1dCBpcyBvbmx5Cj4gcG9zc2libGUg aWYgdGhlcmUgaXMgbm8gbWVtIHJlc291cmNlLgo+IAo+IFdpdGggdGhlIHByaW9yIGFycmFuZ2Vt ZW50IG5vIG1lbSByZXNvdXJjZSBtZWFucyB0aGUgeDg2IGRlZmF1bHQKPiBhZGRyZXNzIGlzIHVz ZWQsIHdoaWNoIGlzIHRoZSBvbmx5IHdheSBJIGNhbiBzZWUgaG93IHlvdXIgc3lzdGVtCj4gd29y a3MuCgpUaGUgZm9sbG93aW5nIHNpbXBsZSBjaGFuZ2UgZml4ZXMgdGhlIEFDUEkgcHJvYmluZyBh ZnRlciBhcHBseWluZyB5b3VyCmxhdGVzdCBzZXJpZXMuIFRoZSBtdXN0IGhhdmUgYmVlbiBhbm90 aGVyIEFDUEkgcmVzb3VyY2UgdGhhdCB5b3Ugd2VyZQplcnJvbmVvdXNseSB1c2luZyBhcyBtZW0g cmVzb3VyY2UuIAoKVGhlIElTX0VSUiBjaGFuZ2UoKSBkaWRuJ3QgZml4IGl0LiBJIHRoaW5rIGl0 J3Mgbm90IG5lZWRlZCwgYWx0aG91Z2ggaXQKcHJvYmFibHkgY2FuJ3QgaHVydC4KCmRpZmYgLS1n aXQgYS9kcml2ZXJzL2NoYXIvdHBtL3RwbV90aXMuYyBiL2RyaXZlcnMvY2hhci90cG0vdHBtX3Rp cy5jCmluZGV4IGExODk4YzguLjRjNjVhN2QgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvY2hhci90cG0v dHBtX3Rpcy5jCisrKyBiL2RyaXZlcnMvY2hhci90cG0vdHBtX3Rpcy5jCkBAIC05NTQsNyArOTU0 LDggQEAgc3RhdGljIGludCB0cG1fY2hlY2tfcmVzb3VyY2Uoc3RydWN0IGFjcGlfcmVzb3VyY2Ug KmFyZXMsIHZvaWQgKmRhdGEpCiAKIAlpZiAoYWNwaV9kZXZfcmVzb3VyY2VfaW50ZXJydXB0KGFy ZXMsIDAsICZyZXMpKQogCQl0cG1faW5mby0+aXJxID0gcmVzLnN0YXJ0OwotCWFjcGlfZGV2X3Jl c291cmNlX21lbW9yeShhcmVzLCAmdHBtX2luZm8tPnJlcyk7CisJZWxzZSBpZiAoYWNwaV9kZXZf cmVzb3VyY2VfbWVtb3J5KGFyZXMsICZyZXMpKQorCQltZW1jcHkoJnRwbV9pbmZvLT5yZXMsICZy ZXMsIHNpemVvZihyZXMpKTsKIAogCXJldHVybiAxOwogfQoK -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jason Gunthorpe <jgunthorpe@obsidianresearch.com> |
|---|---|
| Date | 2015-12-04 19:10 +0100 |
| Subject | Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter |
| Message-ID | <qC2XU-6b1-19@gated-at.bofh.it> |
| In reply to | #1283668 |
On Fri, Dec 04, 2015 at 10:10:15AM +0100, Wilck, Martin wrote: > The following simple change fixes the ACPI probing after applying your > latest series. The must have been another ACPI resource that you were > erroneously using as mem resource. Close, acpi_dev_resource_memory destroys it's output parameter when it fails :( Should be: if (acpi_dev_resource_interrupt(ares, 0, &res)) tpm_info->irq = res.start; else if (acpi_dev_resource_memory(ares, &res)) tpm_info->res = res; > The IS_ERR change() didn't fix it. I think it's not needed, although it > probably can't hurt. IS_ERR should address the oops though?? I've put all the revised patches here: https://github.com/jgunthorpe/linux/commits/for-jarkko If you are OK with them now I'll post the series. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Wilck, Martin" <martin.wilck@ts.fujitsu.com> |
|---|---|
| Date | 2015-12-07 11:00 +0100 |
| Subject | Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter |
| Message-ID | <qD0Km-2NJ-17@gated-at.bofh.it> |
| In reply to | #1284133 |
PiBJU19FUlIgc2hvdWxkIGFkZHJlc3MgdGhlIG9vcHMgdGhvdWdoPz8KCk5vLCBzZWUgbXkgYW5z d2VyIHRvIEphcmtrbyBpbiB0aGUgb3RoZXIgcGFydCBvZiB0aGUgdGhyZWFkLgoKPiBJJ3ZlIHB1 dCBhbGwgdGhlIHJldmlzZWQgcGF0Y2hlcyBoZXJlOgo+IAo+IGh0dHBzOi8vZ2l0aHViLmNvbS9q Z3VudGhvcnBlL2xpbnV4L2NvbW1pdHMvZm9yLWphcmtrbwo+IAo+IElmIHlvdSBhcmUgT0sgd2l0 aCB0aGVtIG5vdyBJJ2xsIHBvc3QgdGhlIHNlcmllcy4KCkkgaGF2ZW4ndCByZS1yZXZpZXdlZCBp dCwgYnV0IHRoZSB0ZXN0IHdlbnQgYWxyaWdodC4gCgpBcyByZXBvcnRlZCBiZWZvcmUsIHdpdGgg ImZvcmNlPTEiLCBJIGdldCB0aGUgZXJyb3IgbWVzc2FnZToKClsgMTM1MS42Nzc4MDhdIHRwbV90 aXMgTVNGVDAxMDE6MDA6IGNhbid0IHJlcXVlc3QgcmVnaW9uIGZvciByZXNvdXJjZQpbbWVtIDB4 ZmVkNDAwMDAtMHhmZWQ0NGZmZl0KWyAxMzUxLjY4NzQzMV0gdHBtX3RpczogcHJvYmUgb2YgTVNG VDAxMDE6MDAgZmFpbGVkIHdpdGggZXJyb3IgLTE2CgpUaGlzIGlzIGtpbmQgb2YgbWlzbGVhZGlu ZyBiZWNhdXNlIHRoZSBUUE0gaXMgYWN0dWFsbHkgd29ya2luZyBhcyBhCnBsYXRmb3JtIGRldmlj ZS4gQnV0IEkgY2FuIGZvbGxvdyB5b3VyIHByZXZpb3VzIGFyZ3VtZW50IHRoYXQgdGhpcyBpcwph Y2NlcHRhYmxlIGJlY2F1c2UgcGVvcGxlIHdobyB1c2UgImZvcmNlPTEiIHNob3VsZCBrbm93IHdo YXQgdGhleSBhcmUKZG9pbmcsIHNvIEkgZG9uJ3QgcmVnYXJkIHRoaXMgYXMgY3JpdGljYWwuCgpN YXJ0aW4KCg== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jason Gunthorpe <jgunthorpe@obsidianresearch.com> |
|---|---|
| Date | 2015-12-07 18:40 +0100 |
| Subject | Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter |
| Message-ID | <qD7Vv-7B3-5@gated-at.bofh.it> |
| In reply to | #1285163 |
On Mon, Dec 07, 2015 at 10:59:15AM +0100, Wilck, Martin wrote: > > IS_ERR should address the oops though?? > > No, see my answer to Jarkko in the other part of the thread. I'm confused, is there an oops that still need to be fixed? > As reported before, with "force=1", I get the error message: > > [ 1351.677808] tpm_tis MSFT0101:00: can't request region for resource > [mem 0xfed40000-0xfed44fff] > [ 1351.687431] tpm_tis: probe of MSFT0101:00 failed with error -16 Great, that you so much, that is what I expected to see! > This is kind of misleading because the TPM is actually working as a > platform device. But I can follow your previous argument that this is > acceptable because people who use "force=1" should know what they are > doing, so I don't regard this as critical. Right. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Date | 2015-12-03 07:00 +0100 |
| Message-ID | <qBv5U-Qg-5@gated-at.bofh.it> |
| In reply to | #1282255 |
On Wed, Dec 02, 2015 at 11:27:27AM -0700, Jason Gunthorpe wrote: > On Tue, Dec 01, 2015 at 11:33:51PM +0200, Jarkko Sakkinen wrote: > > On Tue, Dec 01, 2015 at 11:58:26AM -0700, Jason Gunthorpe wrote: > > > I went through the patches and didn't see anything that would shock me > > enough not to apply the patches in the current if they also work when > > tested *but* are these release critical for Linux v4.4? > > Jarkko, > > Can you explain how > > commit 399235dc6e95400a1322a9999e92073bc572f0c8 > Author: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > Date: Tue Sep 29 00:32:19 2015 +0300 > > tpm, tpm_tis: fix tpm_tis ACPI detection issue with TPM 2.0 > > Is supposed to work? I get the jist of the idea, but I'm not seeing > how it can work reliably.. The idea is that circulate the problem that pnp driver infra can pass at most 7 character device IDs and MSFT0101 (used for TPM2 devices) has 8 characters. They have disjoint sets of device IDs so both cannot ever attach. I don't know who was idiot enough to invent 8 character device ID for TPM2 devices but that's the reality. It's not a perfect fix but I couldn't figure out anything more clever at that time. And nobody else was paying attention to the issue so I had to do something and people who reported bug tested the patch and were happy so I'm confident I did the right thing in the situation. > The idea is to pass off TPM2_START_FIFO to tpm_tis? > > I'm guessing that if the driver probe order is tpm_crb,tpm_tis then > things work because tpm_crb will claim the device first? Otherwise > tpm_tis claims these things unconditionally? If the probe order is > reversed things become broken? > > What is the address tpm_tis should be using? I see two things, it > either uses the x86 default address or it expects the ACPI to have a > MEM resource. AFAIK ACPI should never rely on hard wired addresses, so > I removed that code in this series. Perhaps tpm_tis should be using > control_area_pa ? Will ACPI ever present a struct resource? (if yes, > why isn't tpm_crb using one?) Doesn't also PNP driver do this assumption when the backend is ACPI? > There is also something wrong with the endianness in the acpi > stuff. I don't see endianness conversions in other acpi places, so I > wonder if the ones in tpm_crb are correct. If they are correct then > the struct needs le/be notations and there are some missing > conversions. /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Wilck, Martin" <martin.wilck@ts.fujitsu.com> |
|---|---|
| Date | 2015-12-02 13:40 +0100 |
| Message-ID | <qBeRs-79R-21@gated-at.bofh.it> |
| In reply to | #1281118 |
T24gRGksIDIwMTUtMTItMDEgYXQgMTE6NTggLTA3MDAsIEphc29uIEd1bnRob3JwZSB3cm90ZToK Cj4gTWFydGluLCB0aGlzIHNob3VsZCBmaXggdGhlIGRvdWJsZSBsb2FkaW5nIHlvdSBub3RpY2Vk LCBwbGVhc2UgY29uZmlybS4gIFRoZXJlCj4gaXMgYSBwb3NzaWJpbGl0eSB0aGUgZm9yY2UgcGF0 aCBuZWVkcyBhIGJpdCBtb3JlIGNvZGUgdG8gYmUgY29tcGF0aWJsZSB3aXRoCj4gZGV2bV9pb3Jl bWFwX3Jlc291cmNlLCBJJ20gbm90IHN1cmUsIGhvcGluZyBub3QuCgpOb3BlLCB0aGlzIG9uZSBv b3BzZXMgaW4gdGhlIEFDUEkgcHJvYmluZyBwYXRoLgoKWyAgIDEyLjI4NzM1MF0gdHBtX3RpcyBN U0ZUMDEwMTowMDogaW52YWxpZCByZXNvdXJjZQpbICAgMTIuMjkyNjI1XSBCVUc6IHVuYWJsZSB0 byBoYW5kbGUga2VybmVsIHBhZ2luZyByZXF1ZXN0IGF0IGZmZmZmZmZmZmZmZmZmZWEKWyAgIDEy LjMwMDQyN10gSVA6IFs8ZmZmZmZmZmY4MTMzNzQ4MT5dIGlvcmVhZDgrMHgzMS8weDQwClsgICAx Mi4zMDYxODhdIFBHRCAxYTE5MDY3IFBVRCAxYTFiMDY3IFBNRCAwIApbICAgMTIuMzEwNzkzXSBP b3BzOiAwMDAwIFsjMV0gU01QIApbICAgMTIuMzE0NDE2XSBNb2R1bGVzIGxpbmtlZCBpbjogdHBt X3RpcygrKSBuZnNkIGF1dGhfcnBjZ3NzIG5mc19hY2wgbG9ja2QgZ3JhY2Ugc3VucnBjIHNjaF9m cV9jb2RlbCBpcF90YWJsZXMgeGZzIGxpYmNyYzMyYyBzcl9tb2QgY2Ryb20gc2RfbW9kIG1nYWcy MDAgaTJjX2FsZ29fYml0IGRybV9rbXNfaGVscGVyIHN5c2NvcHlhcmVhIHN5c2ZpbGxyZWN0IHN5 c2ltZ2JsdCBmYl9zeXNfZm9wcyBhaGNpIHR0bSBsaWJhaGNpIGRybSBiZTJuZXQgdnhsYW4gbGli YXRhIGlwNl91ZHBfdHVubmVsIHVkcF90dW5uZWwKWyAgIDEyLjM0MzQ4M10gQ1BVOiAxNCBQSUQ6 IDgyNiBDb21tOiBzeXN0ZW1kLXVkZXZkIE5vdCB0YWludGVkIDQuNC4wLXJjMisgIzE1ClsgICAx Mi4zNTEyNjNdIEhhcmR3YXJlIG5hbWU6IEZVSklUU1UgUFJJTUVSR1kgUlgyNTMwIE0xL0QzMjc5 LUIxLCBCSU9TIFY1LjAuMC4xMSBSMC43NC4wIGZvciBEMzI3OS1CMXggICAgICAgICAgICAgICAg ICAgIDA5LzIxLzIwMTUKWyAgIDEyLjM2NDM2N10gdGFzazogZmZmZjg4MDQ2YmQ1MmE4MCB0aTog ZmZmZjg4MDQ2YmM5NDAwMCB0YXNrLnRpOiBmZmZmODgwNDZiYzk0MDAwClsgICAxMi4zNzI3MjBd IFJJUDogMDAxMDpbPGZmZmZmZmZmODEzMzc0ODE+XSAgWzxmZmZmZmZmZjgxMzM3NDgxPl0gaW9y ZWFkOCsweDMxLzB4NDAKWyAgIDEyLjM4MTIwNV0gUlNQOiAwMDE4OmZmZmY4ODA0NmJjOTdhNjAg IEVGTEFHUzogMDAwMTAyOTYKWyAgIDEyLjM4NzE0Ml0gUkFYOiBmZmZmZmZmZmZmZmZmZmVhIFJC WDogZmZmZjg4MDg2Y2UyNzgwMCBSQ1g6IDAwMDAwMDAwMDAwMDAwMDAKWyAgIDEyLjM5NTExM10g UkRYOiAwMDAwMDAwMDAwMDAwMDAxIFJTSTogZmZmZjg4MDg2ZjEwZGZmOCBSREk6IGZmZmZmZmZm ZmZmZmZmZWEKWyAgIDEyLjQwMzA3N10gUkJQOiBmZmZmODgwNDZiYzk3YWIwIFIwODogMDAwMDAw MDAwMDAwMDAwYSBSMDk6IDAwMDAwMDAwMDAwMDAwMDAKWyAgIDEyLjQxMTA0Ml0gUjEwOiAwMDAw MDAwMDAwMDAwMDAwIFIxMTogMDAwMDAwMDAwMDAwMDNlYSBSMTI6IDAwMDAwMDAwZmZmYjlkMDEK WyAgIDEyLjQxOTAwNl0gUjEzOiBmZmZmODgwODZjNmUwYTY4IFIxNDogZmZmZjg4MDQ2YmM5N2Fk MCBSMTU6IGZmZmY4ODA0NmY0ZjgxMTgKWyAgIDEyLjQyNjk3Ml0gRlM6ICAwMDAwN2ZhNGFmMzQ4 ODgwKDAwMDApIEdTOmZmZmY4ODA4NmYxMDAwMDAoMDAwMCkga25sR1M6MDAwMDAwMDAwMDAwMDAw MApbICAgMTIuNDM2MDAyXSBDUzogIDAwMTAgRFM6IDAwMDAgRVM6IDAwMDAgQ1IwOiAwMDAwMDAw MDgwMDUwMDMzClsgICAxMi40NDI0MTRdIENSMjogZmZmZmZmZmZmZmZmZmZlYSBDUjM6IDAwMDAw MDA0NmJkN2IwMDAgQ1I0OiAwMDAwMDAwMDAwMTQwNmUwClsgICAxMi40NTAzNzhdIFN0YWNrOgpb ICAgMTIuNDUyNjIyXSAgZmZmZmZmZmZhMDEyMWYyMSBmZmZmODgwNDZiYzk3YWMwIGZmZmZmZmZm YTAxMjE2MDAgZmZmZjg4MDQ2YmM5N2FkMApbICAgMTIuNDYwOTIyXSAgMDAwMDAwMDA3MTg4M2Ex NCBmZmZmODgwODZjNmUwODAwIGZmZmY4ODA0NmJjOTdhZDAgZmZmZjg4MDQ2YmM5N2FjMApbICAg MTIuNDY5MjIxXSAgMDAwMDAwMDAwMDAwMDAwOSBmZmZmODgwNDZhNDRmNTQwIGZmZmY4ODA0NmJj OTdiMzAgZmZmZmZmZmZhMDEyMjc3MgpbICAgMTIuNDc3NTE4XSBDYWxsIFRyYWNlOgpbICAgMTIu NDgwMjUyXSAgWzxmZmZmZmZmZmEwMTIxZjIxPl0gPyB0cG1fdGlzX2luaXQrMHhmMS8weDc1MCBb dHBtX3Rpc10KWyAgIDEyLjQ4NzQ1MV0gIFs8ZmZmZmZmZmZhMDEyMTYwMD5dID8gdHBtX3Rpc19w cm9iZV9pcnFfc2luZ2xlKzB4MTYwLzB4MTYwIFt0cG1fdGlzXQpbICAgMTIuNDk1ODk0XSAgWzxm ZmZmZmZmZmEwMTIyNzcyPl0gdHBtX3Rpc19hY3BpX2luaXQrMHhiMi8weDEyMCBbdHBtX3Rpc10K WyAgIDEyLjUwMzM4N10gIFs8ZmZmZmZmZmY4MTM5NmU0YT5dIGFjcGlfZGV2aWNlX3Byb2JlKzB4 NGEvMHhmNwpbICAgMTIuNTA5ODA5XSAgWzxmZmZmZmZmZjgxNDU2NGI5Pl0gZHJpdmVyX3Byb2Jl X2RldmljZSsweDE2OS8weDQ1MApbICAgMTIuNTE2NjIwXSAgWzxmZmZmZmZmZjgxNDU2ODI1Pl0g X19kcml2ZXJfYXR0YWNoKzB4ODUvMHg5MApbICAgMTIuNTIyODM5XSAgWzxmZmZmZmZmZjgxNDU2 N2EwPl0gPyBkcml2ZXJfcHJvYmVfZGV2aWNlKzB4NDUwLzB4NDUwClsgICAxMi41Mjk4MzddICBb PGZmZmZmZmZmODE0NTQyN2M+XSBidXNfZm9yX2VhY2hfZGV2KzB4NmMvMHhjMApbICAgMTIuNTM2 MTYxXSAgWzxmZmZmZmZmZjgxNDU1ZWNlPl0gZHJpdmVyX2F0dGFjaCsweDFlLzB4MjAKWyAgIDEy LjU0MjE4OF0gIFs8ZmZmZmZmZmY4MTQ1NTllMD5dIGJ1c19hZGRfZHJpdmVyKzB4MWQwLzB4Mjkw ClsgICAxMi41NDg1MTBdICBbPGZmZmZmZmZmYTAxM2QwMDA+XSA/IDB4ZmZmZmZmZmZhMDEzZDAw MApbICAgMTIuNTU0MjQ0XSAgWzxmZmZmZmZmZjgxNDU3MWQwPl0gZHJpdmVyX3JlZ2lzdGVyKzB4 NjAvMHhlMApbICAgMTIuNTYwNDYzXSAgWzxmZmZmZmZmZjgxMzk2ZDFlPl0gYWNwaV9idXNfcmVn aXN0ZXJfZHJpdmVyKzB4M2IvMHg0MwpbICAgMTIuNTY3NTY0XSAgWzxmZmZmZmZmZmEwMTNkMDhm Pl0gaW5pdF90aXMrMHg4Zi8weDEwMDAgW3RwbV90aXNdClsgICAxMi41NzQyNzldICBbPGZmZmZm ZmZmODEzMmQ4YmU+XSA/IGthc3ByaW50ZisweDRlLzB4NzAKWyAgIDEyLjU4MDExNl0gIFs8ZmZm ZmZmZmZhMDEzZDAwMD5dID8gMHhmZmZmZmZmZmEwMTNkMDAwClsgICAxMi41ODU4NTNdICBbPGZm ZmZmZmZmODEwMDIxM2Q+XSBkb19vbmVfaW5pdGNhbGwrMHhjZC8weDFmMApbICAgMTIuNTkyMTcx XSAgWzxmZmZmZmZmZjgxMWQ2MTliPl0gPyBrbWVtX2NhY2hlX2FsbG9jX3RyYWNlKzB4MTdiLzB4 MWUwClsgICAxMi41OTk0NjhdICBbPGZmZmZmZmZmODExNzk4MDg+XSA/IGRvX2luaXRfbW9kdWxl KzB4MjcvMHgxZTgKWyAgIDEyLjYwNTg5MF0gIFs8ZmZmZmZmZmY4MTE3OTg0MT5dIGRvX2luaXRf bW9kdWxlKzB4NjAvMHgxZTgKWyAgIDEyLjYxMjExMV0gIFs8ZmZmZmZmZmY4MTEwMDJhZT5dIGxv YWRfbW9kdWxlKzB4MWMyZS8weDI0YzAKWyAgIDEyLjYxODMzMF0gIFs8ZmZmZmZmZmY4MTBmY2Fi MD5dID8gX19zeW1ib2xfcHV0KzB4NjAvMHg2MApbICAgMTIuNjI0NDUzXSAgWzxmZmZmZmZmZjgx MGZjZTMwPl0gPyBjb3B5X21vZHVsZV9mcm9tX2ZkLmlzcmEuNTQrMHgxMTAvMHgxNjAKWyAgIDEy LjYzMjIyOV0gIFs8ZmZmZmZmZmY4MTEwMGQ0Zj5dIFN5U19maW5pdF9tb2R1bGUrMHg5Zi8weGQw ClsgICAxMi42Mzg1NDldICBbPGZmZmZmZmZmODE2YmRiNmU+XSBlbnRyeV9TWVNDQUxMXzY0X2Zh c3RwYXRoKzB4MTIvMHg3MQpbICAgMTIuNjQ1NzQ1XSBDb2RlOiAwMCA3NyAyOCA0OCA4MSBmZiAw MCAwMCAwMSAwMCA3NiAwOCAwZiBiNyBkNyBlYyAwZiBiNiBjMCBjMyA1NSA0OCBjNyBjNiAxMCBm YyA5NCA4MSA0OCA4OSBlNSBlOCA5NiBmZiBmZiBmZiBiOCBmZiAwMCAwMCAwMCA1ZCBjMyA8OGE+ IDA3IDBmIGI2IGMwIGMzIDY2IDBmIDFmIDg0IDAwIDAwIDAwIDAwIDAwIDQ4IDgxIGZmIGZmIGZm IDAzIApbICAgMTIuNjY3NTEwXSBSSVAgIFs8ZmZmZmZmZmY4MTMzNzQ4MT5dIGlvcmVhZDgrMHgz MS8weDQwClsgICAxMi42NzMzNTNdICBSU1AgPGZmZmY4ODA0NmJjOTdhNjA+ClsgICAxMi42Nzcy NDRdIENSMjogZmZmZmZmZmZmZmZmZmZlYQpbICAgMTIuNjgwOTQzXSAtLS1bIGVuZCB0cmFjZSA1 ODU0NTMzNTM2ZmQ1MTAxIF0tLS0KWyAgIDEyLjY4NzQ2NV0gS2VybmVsIHBhbmljIC0gbm90IHN5 bmNpbmc6IEZhdGFsIGV4Y2VwdGlvbgpbICAgMTIuNjkzMzM4XSBLZXJuZWwgT2Zmc2V0OiBkaXNh YmxlZApbICAgMTIuNzAxMTQ1XSAtLS1bIGVuZCBLZXJuZWwgcGFuaWMgLSBub3Qgc3luY2luZzog RmF0YWwgZXhjZXB0aW9uCgoK -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jason Gunthorpe <jgunthorpe@obsidianresearch.com> |
|---|---|
| Date | 2015-12-02 19:20 +0100 |
| Message-ID | <qBkav-2mS-17@gated-at.bofh.it> |
| In reply to | #1281746 |
On Wed, Dec 02, 2015 at 01:34:38PM +0100, Wilck, Martin wrote:
> On Di, 2015-12-01 at 11:58 -0700, Jason Gunthorpe wrote:
>
> > Martin, this should fix the double loading you noticed, please confirm. There
> > is a possibility the force path needs a bit more code to be compatible with
> > devm_ioremap_resource, I'm not sure, hoping not.
>
> Nope, this one oopses in the ACPI probing path.
This fixes this oops:
chip->vendor.iobase = devm_ioremap_resource(dev, &tpm_info->res);
- if (!chip->vendor.iobase)
- return -EIO;
+ if (IS_ERR(chip->vendor.iobase))
+ return PTR_ERR(chip->vendor.iobase);
And I see that the ACPI stuff needs other work :(
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Page 3 of 3 — ← Prev page 1 2 [3]
Back to top | Article view | linux.kernel
csiph-web