Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281457 > unrolled thread
| Started by | Namhyung Kim <namhyung@kernel.org> |
|---|---|
| First post | 2015-12-02 06:50 +0100 |
| Last post | 2015-12-06 04:40 +0100 |
| Articles | 9 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v2] perf tools: Introduce perf_thread for backtrace Namhyung Kim <namhyung@kernel.org> - 2015-12-02 06:50 +0100
Re: [PATCH v2] perf tools: Introduce perf_thread for backtrace Jiri Olsa <jolsa@redhat.com> - 2015-12-02 09:20 +0100
[PATCH v3] perf tools: Introduce perf_thread for backtrace Namhyung Kim <namhyung@kernel.org> - 2015-12-02 16:40 +0100
Re: [PATCH v3] perf tools: Introduce perf_thread for backtrace Jiri Olsa <jolsa@redhat.com> - 2015-12-02 17:30 +0100
RE: [PATCH v3] perf tools: Introduce perf_thread for backtrace 平松雅巳 / HIRAMATU，MASAMI <masami.hiramatsu.pt@hitachi.com> - 2015-12-03 01:20 +0100
Re: [PATCH v3] perf tools: Introduce perf_thread for backtrace Namhyung Kim <namhyung@kernel.org> - 2015-12-03 02:30 +0100
RE: [PATCH v3] perf tools: Introduce perf_thread for backtrace 平松雅巳 / HIRAMATU，MASAMI <masami.hiramatsu.pt@hitachi.com> - 2015-12-03 08:20 +0100
Re: [PATCH v3] perf tools: Introduce perf_thread for backtrace Namhyung Kim <namhyung@kernel.org> - 2015-12-04 14:20 +0100
RE: [PATCH v3] perf tools: Introduce perf_thread for backtrace 平松雅巳 / HIRAMATU，MASAMI <masami.hiramatsu.pt@hitachi.com> - 2015-12-06 04:40 +0100
| From | Namhyung Kim <namhyung@kernel.org> |
|---|---|
| Date | 2015-12-02 06:50 +0100 |
| Subject | [PATCH v2] perf tools: Introduce perf_thread for backtrace |
| Message-ID | <qB8sF-31B-7@gated-at.bofh.it> |
Backtrace is a crucial info for debugging. And upcoming refcnt
tracking facility also wants to use it.
So instead of relying on glibc's backtrace_symbols[_fd] which misses
some (static) functions , use our own symbol searching mechanism. To
do that, add perf_thread global variable to keep its maps and symbols.
The backtrace output from TUI is changed like below. (I made a key
action to generate a segfault):
Before:
perf: Segmentation fault
-------- backtrace --------
perf[0x544a8b]
/usr/lib/libc.so.6(+0x33680)[0x7fc46420b680]
perf[0x54041b]
perf(perf_evlist__tui_browse_hists+0x91)[0x5432e1]
perf(cmd_report+0x1d20)[0x43cb10]
perf[0x487073]
perf(main+0x62f)[0x42cb1f]
/usr/lib/libc.so.6(__libc_start_main+0xf0)[0x7fc4641f8610]
perf(_start+0x29)[0x42cc39]
After:
perf: Segmentation fault
-------- backtrace --------
perf_evsel__hists_browse(+0x43b) in perf [0x54066b]
perf_evlist__tui_browse_hists(+0x91) in perf [0x543531]
cmd_report(+0x1d20) in perf [0x43cb50]
run_builtin(+0x53) in perf [0x4870b3]
main(+0x634) in perf [0x42cb54]
__libc_start_main(+0xf0) in libc-2.22.so [0x7fea3577c610]
_start(+0x29) in perf [0x42cc79]
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
v2) fallback to glibc's backtrace_symbols_fd() if failed
tools/perf/perf.c | 7 +++++-
tools/perf/ui/tui/setup.c | 31 ++++++++++++++++++++++--
tools/perf/util/util.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++
tools/perf/util/util.h | 5 ++++
4 files changed, 102 insertions(+), 3 deletions(-)
diff --git a/tools/perf/perf.c b/tools/perf/perf.c
index 4bee53c3f796..f77eb440b05c 100644
--- a/tools/perf/perf.c
+++ b/tools/perf/perf.c
@@ -604,6 +604,8 @@ int main(int argc, const char **argv)
*/
pthread__block_sigwinch();
+ create_perf_thread();
+
while (1) {
static int done_help;
int was_alias = run_argv(&argc, &argv);
@@ -615,7 +617,7 @@ int main(int argc, const char **argv)
fprintf(stderr, "Expansion of alias '%s' failed; "
"'%s' is not a perf-command\n",
cmd, argv[0]);
- goto out;
+ goto out_destroy;
}
if (!done_help) {
cmd = argv[0] = help_unknown_cmd(cmd);
@@ -626,6 +628,9 @@ int main(int argc, const char **argv)
fprintf(stderr, "Failed to run command '%s': %s\n",
cmd, strerror_r(errno, sbuf, sizeof(sbuf)));
+
+out_destroy:
+ destroy_perf_thread();
out:
return 1;
}
diff --git a/tools/perf/ui/tui/setup.c b/tools/perf/ui/tui/setup.c
index 7dfeba0a91f3..ba0ff1c4e6b7 100644
--- a/tools/perf/ui/tui/setup.c
+++ b/tools/perf/ui/tui/setup.c
@@ -13,6 +13,8 @@
#include "../libslang.h"
#include "../keysyms.h"
#include "tui.h"
+#include "../../util/symbol.h"
+#include "../../util/thread.h"
static volatile int ui__need_resize;
@@ -96,14 +98,39 @@ int ui__getch(int delay_secs)
static void ui__signal_backtrace(int sig)
{
void *stackdump[32];
- size_t size;
+ size_t size, i;
ui__exit(false);
psignal(sig, "perf");
printf("-------- backtrace --------\n");
size = backtrace(stackdump, ARRAY_SIZE(stackdump));
- backtrace_symbols_fd(stackdump, size, STDOUT_FILENO);
+ /* skip first two stack frame (for this function and signal stack) */
+ for (i = 2; i < size; i++) {
+ struct addr_location al = {
+ .sym = NULL,
+ };
+
+ /* valid callchain ends with 0 address */
+ if (stackdump[i] == NULL && i == (size - 1))
+ continue;
+
+ thread__find_addr_location(perf_thread, PERF_RECORD_MISC_USER,
+ MAP__FUNCTION, (long)stackdump[i], &al);
+
+ if (!al.sym)
+ break;
+
+ printf("%s(+0x%"PRIx64") in %s [0x%lx]\n", al.sym->name,
+ map__map_ip(al.map, (u64)stackdump[i]) - al.sym->start,
+ al.map->dso->short_name, (unsigned long)stackdump[i]);
+ }
+
+ if (i != size) {
+ printf("\nperf backtrace seems broken, try again with glibc\n");
+ printf("-------- backtrace --------\n");
+ backtrace_symbols_fd(stackdump, size, STDOUT_FILENO);
+ }
exit(0);
}
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index 75759aebc7b8..f1a26ea14053 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -16,6 +16,9 @@
#include <linux/kernel.h>
#include <unistd.h>
#include "callchain.h"
+#include "machine.h"
+#include "thread.h"
+#include "thread_map.h"
struct callchain_param callchain_param = {
.mode = CHAIN_GRAPH_ABS,
@@ -696,3 +699,62 @@ fetch_kernel_version(unsigned int *puint, char *str,
*puint = (version << 16) + (patchlevel << 8) + sublevel;
return 0;
}
+
+
+static int process_event(struct perf_tool *tool, union perf_event *event,
+ struct perf_sample *sample, struct machine *machine)
+{
+ switch (event->header.type) {
+ case PERF_RECORD_COMM:
+ return tool->comm(tool, event, sample, machine);
+ case PERF_RECORD_MMAP:
+ return tool->mmap(tool, event, sample, machine);
+ case PERF_RECORD_MMAP2:
+ return tool->mmap2(tool, event, sample, machine);
+ default:
+ break;
+ }
+ return 0;
+}
+
+struct thread *perf_thread;
+
+void create_perf_thread(void)
+{
+ struct perf_tool tool = {
+ .comm = perf_event__process_comm,
+ .mmap = perf_event__process_mmap,
+ .mmap2 = perf_event__process_mmap2,
+ };
+ struct thread_map *tm;
+ struct machine *machine;
+ int pid = getpid();
+
+ machine = machine__new_host();
+ if (machine == NULL)
+ return;
+
+ tm = thread_map__new_dummy();
+ if (tm == NULL) {
+ machine__delete(machine);
+ return;
+ }
+
+ thread_map__set_pid(tm, 0, pid);
+
+ perf_event__synthesize_thread_map(&tool, tm, process_event, machine,
+ false, 500);
+
+ perf_thread = machine__find_thread(machine, pid, pid);
+ BUG_ON(perf_thread == NULL);
+
+ thread_map__put(tm);
+}
+
+void destroy_perf_thread(void)
+{
+ struct machine *machine = perf_thread->mg->machine;
+
+ machine__delete_threads(machine);
+ machine__delete(machine);
+}
diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
index dcc659017976..630e145049aa 100644
--- a/tools/perf/util/util.h
+++ b/tools/perf/util/util.h
@@ -358,4 +358,9 @@ int fetch_kernel_version(unsigned int *puint,
#define KVER_FMT "%d.%d.%d"
#define KVER_PARAM(x) KVER_VERSION(x), KVER_PATCHLEVEL(x), KVER_SUBLEVEL(x)
+extern struct thread *perf_thread;
+
+void create_perf_thread(void);
+void destroy_perf_thread(void);
+
#endif /* GIT_COMPAT_UTIL_H */
--
2.6.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Date | 2015-12-02 09:20 +0100 |
| Message-ID | <qBaNQ-4B0-17@gated-at.bofh.it> |
| In reply to | #1281457 |
On Wed, Dec 02, 2015 at 02:42:21PM +0900, Namhyung Kim wrote: > Backtrace is a crucial info for debugging. And upcoming refcnt > tracking facility also wants to use it. > > So instead of relying on glibc's backtrace_symbols[_fd] which misses > some (static) functions , use our own symbol searching mechanism. To > do that, add perf_thread global variable to keep its maps and symbols. > > The backtrace output from TUI is changed like below. (I made a key > action to generate a segfault): > > Before: > perf: Segmentation fault > -------- backtrace -------- > perf[0x544a8b] > /usr/lib/libc.so.6(+0x33680)[0x7fc46420b680] > perf[0x54041b] > perf(perf_evlist__tui_browse_hists+0x91)[0x5432e1] > perf(cmd_report+0x1d20)[0x43cb10] > perf[0x487073] > perf(main+0x62f)[0x42cb1f] > /usr/lib/libc.so.6(__libc_start_main+0xf0)[0x7fc4641f8610] > perf(_start+0x29)[0x42cc39] > > After: > perf: Segmentation fault > -------- backtrace -------- > perf_evsel__hists_browse(+0x43b) in perf [0x54066b] > perf_evlist__tui_browse_hists(+0x91) in perf [0x543531] > cmd_report(+0x1d20) in perf [0x43cb50] > run_builtin(+0x53) in perf [0x4870b3] > main(+0x634) in perf [0x42cb54] > __libc_start_main(+0xf0) in libc-2.22.so [0x7fea3577c610] > _start(+0x29) in perf [0x42cc79] > > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > v2) fallback to glibc's backtrace_symbols_fd() if failed create_perf_thread still returns void jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Namhyung Kim <namhyung@kernel.org> |
|---|---|
| Date | 2015-12-02 16:40 +0100 |
| Subject | [PATCH v3] perf tools: Introduce perf_thread for backtrace |
| Message-ID | <qBhFE-By-9@gated-at.bofh.it> |
| In reply to | #1281515 |
Backtrace is a crucial info for debugging. And upcoming refcnt
tracking facility also wants to use it.
So instead of relying on glibc's backtrace_symbols[_fd] which misses
some (static) functions , use our own symbol searching mechanism. To
do that, add perf_thread global variable to keep its maps and symbols.
The backtrace output from TUI is changed like below. (I made a key
action to generate a segfault):
Before:
perf: Segmentation fault
-------- backtrace --------
perf[0x544a8b]
/usr/lib/libc.so.6(+0x33680)[0x7fc46420b680]
perf[0x54041b]
perf(perf_evlist__tui_browse_hists+0x91)[0x5432e1]
perf(cmd_report+0x1d20)[0x43cb10]
perf[0x487073]
perf(main+0x62f)[0x42cb1f]
/usr/lib/libc.so.6(__libc_start_main+0xf0)[0x7fc4641f8610]
perf(_start+0x29)[0x42cc39]
After:
perf: Segmentation fault
-------- backtrace --------
perf_evsel__hists_browse(+0x43b) in perf [0x54066b]
perf_evlist__tui_browse_hists(+0x91) in perf [0x543531]
cmd_report(+0x1d20) in perf [0x43cb50]
run_builtin(+0x53) in perf [0x4870b3]
main(+0x634) in perf [0x42cb54]
__libc_start_main(+0xf0) in libc-2.22.so [0x7fea3577c610]
_start(+0x29) in perf [0x42cc79]
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
v3) check return value of create_perf_thread()
v2) fallback to glibc's backtrace_symbols_fd() if failed
tools/perf/perf.c | 10 +++++++-
tools/perf/ui/tui/setup.c | 31 +++++++++++++++++++++--
tools/perf/util/util.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++
tools/perf/util/util.h | 5 ++++
4 files changed, 106 insertions(+), 3 deletions(-)
diff --git a/tools/perf/perf.c b/tools/perf/perf.c
index 4bee53c3f796..f27dc5fa9534 100644
--- a/tools/perf/perf.c
+++ b/tools/perf/perf.c
@@ -604,6 +604,11 @@ int main(int argc, const char **argv)
*/
pthread__block_sigwinch();
+ if (create_perf_thread() < 0) {
+ fprintf(stderr, "Failed to reserve information for backtrace\n");
+ goto out;
+ }
+
while (1) {
static int done_help;
int was_alias = run_argv(&argc, &argv);
@@ -615,7 +620,7 @@ int main(int argc, const char **argv)
fprintf(stderr, "Expansion of alias '%s' failed; "
"'%s' is not a perf-command\n",
cmd, argv[0]);
- goto out;
+ goto out_destroy;
}
if (!done_help) {
cmd = argv[0] = help_unknown_cmd(cmd);
@@ -626,6 +631,9 @@ int main(int argc, const char **argv)
fprintf(stderr, "Failed to run command '%s': %s\n",
cmd, strerror_r(errno, sbuf, sizeof(sbuf)));
+
+out_destroy:
+ destroy_perf_thread();
out:
return 1;
}
diff --git a/tools/perf/ui/tui/setup.c b/tools/perf/ui/tui/setup.c
index 7dfeba0a91f3..ba0ff1c4e6b7 100644
--- a/tools/perf/ui/tui/setup.c
+++ b/tools/perf/ui/tui/setup.c
@@ -13,6 +13,8 @@
#include "../libslang.h"
#include "../keysyms.h"
#include "tui.h"
+#include "../../util/symbol.h"
+#include "../../util/thread.h"
static volatile int ui__need_resize;
@@ -96,14 +98,39 @@ int ui__getch(int delay_secs)
static void ui__signal_backtrace(int sig)
{
void *stackdump[32];
- size_t size;
+ size_t size, i;
ui__exit(false);
psignal(sig, "perf");
printf("-------- backtrace --------\n");
size = backtrace(stackdump, ARRAY_SIZE(stackdump));
- backtrace_symbols_fd(stackdump, size, STDOUT_FILENO);
+ /* skip first two stack frame (for this function and signal stack) */
+ for (i = 2; i < size; i++) {
+ struct addr_location al = {
+ .sym = NULL,
+ };
+
+ /* valid callchain ends with 0 address */
+ if (stackdump[i] == NULL && i == (size - 1))
+ continue;
+
+ thread__find_addr_location(perf_thread, PERF_RECORD_MISC_USER,
+ MAP__FUNCTION, (long)stackdump[i], &al);
+
+ if (!al.sym)
+ break;
+
+ printf("%s(+0x%"PRIx64") in %s [0x%lx]\n", al.sym->name,
+ map__map_ip(al.map, (u64)stackdump[i]) - al.sym->start,
+ al.map->dso->short_name, (unsigned long)stackdump[i]);
+ }
+
+ if (i != size) {
+ printf("\nperf backtrace seems broken, try again with glibc\n");
+ printf("-------- backtrace --------\n");
+ backtrace_symbols_fd(stackdump, size, STDOUT_FILENO);
+ }
exit(0);
}
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index 75759aebc7b8..b1e591b13131 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -16,6 +16,9 @@
#include <linux/kernel.h>
#include <unistd.h>
#include "callchain.h"
+#include "machine.h"
+#include "thread.h"
+#include "thread_map.h"
struct callchain_param callchain_param = {
.mode = CHAIN_GRAPH_ABS,
@@ -696,3 +699,63 @@ fetch_kernel_version(unsigned int *puint, char *str,
*puint = (version << 16) + (patchlevel << 8) + sublevel;
return 0;
}
+
+
+static int process_event(struct perf_tool *tool, union perf_event *event,
+ struct perf_sample *sample, struct machine *machine)
+{
+ switch (event->header.type) {
+ case PERF_RECORD_COMM:
+ return tool->comm(tool, event, sample, machine);
+ case PERF_RECORD_MMAP:
+ return tool->mmap(tool, event, sample, machine);
+ case PERF_RECORD_MMAP2:
+ return tool->mmap2(tool, event, sample, machine);
+ default:
+ break;
+ }
+ return 0;
+}
+
+struct thread *perf_thread;
+
+int create_perf_thread(void)
+{
+ struct perf_tool tool = {
+ .comm = perf_event__process_comm,
+ .mmap = perf_event__process_mmap,
+ .mmap2 = perf_event__process_mmap2,
+ };
+ struct thread_map *tm;
+ struct machine *machine;
+ int pid = getpid();
+
+ machine = machine__new_host();
+ if (machine == NULL)
+ return -1;
+
+ tm = thread_map__new_dummy();
+ if (tm == NULL) {
+ machine__delete(machine);
+ return -1;
+ }
+
+ thread_map__set_pid(tm, 0, pid);
+
+ perf_event__synthesize_thread_map(&tool, tm, process_event, machine,
+ false, 500);
+
+ perf_thread = machine__find_thread(machine, pid, pid);
+ BUG_ON(perf_thread == NULL);
+
+ thread_map__put(tm);
+ return 0;
+}
+
+void destroy_perf_thread(void)
+{
+ struct machine *machine = perf_thread->mg->machine;
+
+ machine__delete_threads(machine);
+ machine__delete(machine);
+}
diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
index dcc659017976..769986044a7a 100644
--- a/tools/perf/util/util.h
+++ b/tools/perf/util/util.h
@@ -358,4 +358,9 @@ int fetch_kernel_version(unsigned int *puint,
#define KVER_FMT "%d.%d.%d"
#define KVER_PARAM(x) KVER_VERSION(x), KVER_PATCHLEVEL(x), KVER_SUBLEVEL(x)
+extern struct thread *perf_thread;
+
+int create_perf_thread(void);
+void destroy_perf_thread(void);
+
#endif /* GIT_COMPAT_UTIL_H */
--
2.6.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Date | 2015-12-02 17:30 +0100 |
| Subject | Re: [PATCH v3] perf tools: Introduce perf_thread for backtrace |
| Message-ID | <qBis2-19N-5@gated-at.bofh.it> |
| In reply to | #1281910 |
On Thu, Dec 03, 2015 at 12:33:40AM +0900, Namhyung Kim wrote: > Backtrace is a crucial info for debugging. And upcoming refcnt > tracking facility also wants to use it. > > So instead of relying on glibc's backtrace_symbols[_fd] which misses > some (static) functions , use our own symbol searching mechanism. To > do that, add perf_thread global variable to keep its maps and symbols. > > The backtrace output from TUI is changed like below. (I made a key > action to generate a segfault): > > Before: > perf: Segmentation fault > -------- backtrace -------- > perf[0x544a8b] > /usr/lib/libc.so.6(+0x33680)[0x7fc46420b680] > perf[0x54041b] > perf(perf_evlist__tui_browse_hists+0x91)[0x5432e1] > perf(cmd_report+0x1d20)[0x43cb10] > perf[0x487073] > perf(main+0x62f)[0x42cb1f] > /usr/lib/libc.so.6(__libc_start_main+0xf0)[0x7fc4641f8610] > perf(_start+0x29)[0x42cc39] > > After: > perf: Segmentation fault > -------- backtrace -------- > perf_evsel__hists_browse(+0x43b) in perf [0x54066b] > perf_evlist__tui_browse_hists(+0x91) in perf [0x543531] > cmd_report(+0x1d20) in perf [0x43cb50] > run_builtin(+0x53) in perf [0x4870b3] > main(+0x634) in perf [0x42cb54] > __libc_start_main(+0xf0) in libc-2.22.so [0x7fea3577c610] > _start(+0x29) in perf [0x42cc79] > > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > v3) check return value of create_perf_thread() Acked-by: Jiri Olsa <jolsa@kernel.org> thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | 平松雅巳 / HIRAMATU，MASAMI <masami.hiramatsu.pt@hitachi.com> |
|---|---|
| Date | 2015-12-03 01:20 +0100 |
| Subject | RE: [PATCH v3] perf tools: Introduce perf_thread for backtrace |
| Message-ID | <qBpMR-5Y5-3@gated-at.bofh.it> |
| In reply to | #1281910 |
PkZyb206IE5hbWh5dW5nIEtpbSBbbWFpbHRvOm5hbWh5dW5nQGdtYWlsLmNvbV0gT24gQmVoYWxm IE9mIE5hbWh5dW5nIEtpbQ0KPg0KPkJhY2t0cmFjZSBpcyBhIGNydWNpYWwgaW5mbyBmb3IgZGVi dWdnaW5nLiAgQW5kIHVwY29taW5nIHJlZmNudA0KPnRyYWNraW5nIGZhY2lsaXR5IGFsc28gd2Fu dHMgdG8gdXNlIGl0Lg0KDQpOb3RlIHRoYXQgdGhlIHJlZmNudCBiYWNrdHJhY2Ugc3ltYm9sIHJl c29sdXRpb24gd2lsbCB3b3JrIGF0DQpleGl0LiBUaGlzIG1lYW5zIHRoYXQgaXQgY2FuIG5vdCBk ZXBlbmQgb24gdGhlIGZlYXR1cmUgaW4gcGVyZg0KdG9vbHMgaXRzZWxmLiAoYW5kIG9mIGNvdXJz ZSwgc2luY2UgdGhlIHJlZmNudCB0cmllcyB0byBmaW5kIHVudXNlZA0Kb2JqZWN0cyBpbiBwZXJm IHRvb2xzIGF0IGV4aXQsIGlmIHdlIHVzZSBwZXJmX3RocmVhZCwgaXQgd2lsbA0KZGV0ZWN0IHRo ZSBvYmplY3RzIHJlbGF0ZWQgdG8gdGhlIHBlcmZfdGhyZWFkIGFyZSBsZWFrZWQpDQoNCj4NCj5T byBpbnN0ZWFkIG9mIHJlbHlpbmcgb24gZ2xpYmMncyBiYWNrdHJhY2Vfc3ltYm9sc1tfZmRdIHdo aWNoIG1pc3Nlcw0KPnNvbWUgKHN0YXRpYykgZnVuY3Rpb25zICwgdXNlIG91ciBvd24gc3ltYm9s IHNlYXJjaGluZyBtZWNoYW5pc20uICBUbw0KPmRvIHRoYXQsIGFkZCBwZXJmX3RocmVhZCBnbG9i YWwgdmFyaWFibGUgdG8ga2VlcCBpdHMgbWFwcyBhbmQgc3ltYm9scy4NCj4NCj5UaGUgYmFja3Ry YWNlIG91dHB1dCBmcm9tIFRVSSBpcyBjaGFuZ2VkIGxpa2UgYmVsb3cuICAoSSBtYWRlIGEga2V5 DQo+YWN0aW9uIHRvIGdlbmVyYXRlIGEgc2VnZmF1bHQpOg0KPg0KPkJlZm9yZToNCj4gIHBlcmY6 IFNlZ21lbnRhdGlvbiBmYXVsdA0KPiAgLS0tLS0tLS0gYmFja3RyYWNlIC0tLS0tLS0tDQo+ICBw ZXJmWzB4NTQ0YThiXQ0KPiAgL3Vzci9saWIvbGliYy5zby42KCsweDMzNjgwKVsweDdmYzQ2NDIw YjY4MF0NCj4gIHBlcmZbMHg1NDA0MWJdDQo+ICBwZXJmKHBlcmZfZXZsaXN0X190dWlfYnJvd3Nl X2hpc3RzKzB4OTEpWzB4NTQzMmUxXQ0KPiAgcGVyZihjbWRfcmVwb3J0KzB4MWQyMClbMHg0M2Ni MTBdDQo+ICBwZXJmWzB4NDg3MDczXQ0KPiAgcGVyZihtYWluKzB4NjJmKVsweDQyY2IxZl0NCj4g IC91c3IvbGliL2xpYmMuc28uNihfX2xpYmNfc3RhcnRfbWFpbisweGYwKVsweDdmYzQ2NDFmODYx MF0NCj4gIHBlcmYoX3N0YXJ0KzB4MjkpWzB4NDJjYzM5XQ0KPg0KPkFmdGVyOg0KPiAgcGVyZjog U2VnbWVudGF0aW9uIGZhdWx0DQo+ICAtLS0tLS0tLSBiYWNrdHJhY2UgLS0tLS0tLS0NCj4gIHBl cmZfZXZzZWxfX2hpc3RzX2Jyb3dzZSgrMHg0M2IpIGluIHBlcmYgWzB4NTQwNjZiXQ0KPiAgcGVy Zl9ldmxpc3RfX3R1aV9icm93c2VfaGlzdHMoKzB4OTEpIGluIHBlcmYgWzB4NTQzNTMxXQ0KPiAg Y21kX3JlcG9ydCgrMHgxZDIwKSBpbiBwZXJmIFsweDQzY2I1MF0NCj4gIHJ1bl9idWlsdGluKCsw eDUzKSBpbiBwZXJmIFsweDQ4NzBiM10NCj4gIG1haW4oKzB4NjM0KSBpbiBwZXJmIFsweDQyY2I1 NF0NCj4gIF9fbGliY19zdGFydF9tYWluKCsweGYwKSBpbiBsaWJjLTIuMjIuc28gWzB4N2ZlYTM1 NzdjNjEwXQ0KPiAgX3N0YXJ0KCsweDI5KSBpbiBwZXJmIFsweDQyY2M3OV0NCj4NCj5DYzogRnJl ZGVyaWMgV2Vpc2JlY2tlciA8ZndlaXNiZWNAZ21haWwuY29tPg0KPkNjOiBNYXNhbWkgSGlyYW1h dHN1IDxtYXNhbWkuaGlyYW1hdHN1LnB0QGhpdGFjaGkuY29tPg0KPlNpZ25lZC1vZmYtYnk6IE5h bWh5dW5nIEtpbSA8bmFtaHl1bmdAa2VybmVsLm9yZz4NCj4tLS0NCj52MykgY2hlY2sgcmV0dXJu IHZhbHVlIG9mIGNyZWF0ZV9wZXJmX3RocmVhZCgpDQo+DQo+djIpIGZhbGxiYWNrIHRvIGdsaWJj J3MgYmFja3RyYWNlX3N5bWJvbHNfZmQoKSBpZiBmYWlsZWQNCj4NCj4gdG9vbHMvcGVyZi9wZXJm LmMgICAgICAgICB8IDEwICsrKysrKystDQo+IHRvb2xzL3BlcmYvdWkvdHVpL3NldHVwLmMgfCAz MSArKysrKysrKysrKysrKysrKysrKystLQ0KPiB0b29scy9wZXJmL3V0aWwvdXRpbC5jICAgIHwg NjMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gdG9v bHMvcGVyZi91dGlsL3V0aWwuaCAgICB8ICA1ICsrKysNCj4gNCBmaWxlcyBjaGFuZ2VkLCAxMDYg aW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkNCj4NCj5kaWZmIC0tZ2l0IGEvdG9vbHMvcGVy Zi9wZXJmLmMgYi90b29scy9wZXJmL3BlcmYuYw0KPmluZGV4IDRiZWU1M2MzZjc5Ni4uZjI3ZGM1 ZmE5NTM0IDEwMDY0NA0KPi0tLSBhL3Rvb2xzL3BlcmYvcGVyZi5jDQo+KysrIGIvdG9vbHMvcGVy Zi9wZXJmLmMNCj5AQCAtNjA0LDYgKzYwNCwxMSBAQCBpbnQgbWFpbihpbnQgYXJnYywgY29uc3Qg Y2hhciAqKmFyZ3YpDQo+IAkgKi8NCj4gCXB0aHJlYWRfX2Jsb2NrX3NpZ3dpbmNoKCk7DQo+DQo+ KwlpZiAoY3JlYXRlX3BlcmZfdGhyZWFkKCkgPCAwKSB7DQo+KwkJZnByaW50ZihzdGRlcnIsICJG YWlsZWQgdG8gcmVzZXJ2ZSBpbmZvcm1hdGlvbiBmb3IgYmFja3RyYWNlXG4iKTsNCj4rCQlnb3Rv IG91dDsNCj4rCX0NCj4rDQo+IAl3aGlsZSAoMSkgew0KPiAJCXN0YXRpYyBpbnQgZG9uZV9oZWxw Ow0KPiAJCWludCB3YXNfYWxpYXMgPSBydW5fYXJndigmYXJnYywgJmFyZ3YpOw0KPkBAIC02MTUs NyArNjIwLDcgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNvbnN0IGNoYXIgKiphcmd2KQ0KPiAJCQlm cHJpbnRmKHN0ZGVyciwgIkV4cGFuc2lvbiBvZiBhbGlhcyAnJXMnIGZhaWxlZDsgIg0KPiAJCQkJ IiclcycgaXMgbm90IGEgcGVyZi1jb21tYW5kXG4iLA0KPiAJCQkJY21kLCBhcmd2WzBdKTsNCj4t CQkJZ290byBvdXQ7DQo+KwkJCWdvdG8gb3V0X2Rlc3Ryb3k7DQo+IAkJfQ0KPiAJCWlmICghZG9u ZV9oZWxwKSB7DQo+IAkJCWNtZCA9IGFyZ3ZbMF0gPSBoZWxwX3Vua25vd25fY21kKGNtZCk7DQo+ QEAgLTYyNiw2ICs2MzEsOSBAQCBpbnQgbWFpbihpbnQgYXJnYywgY29uc3QgY2hhciAqKmFyZ3Yp DQo+DQo+IAlmcHJpbnRmKHN0ZGVyciwgIkZhaWxlZCB0byBydW4gY29tbWFuZCAnJXMnOiAlc1xu IiwNCj4gCQljbWQsIHN0cmVycm9yX3IoZXJybm8sIHNidWYsIHNpemVvZihzYnVmKSkpOw0KPisN Cj4rb3V0X2Rlc3Ryb3k6DQo+KwlkZXN0cm95X3BlcmZfdGhyZWFkKCk7DQo+IG91dDoNCj4gCXJl dHVybiAxOw0KPiB9DQo+ZGlmZiAtLWdpdCBhL3Rvb2xzL3BlcmYvdWkvdHVpL3NldHVwLmMgYi90 b29scy9wZXJmL3VpL3R1aS9zZXR1cC5jDQo+aW5kZXggN2RmZWJhMGE5MWYzLi5iYTBmZjFjNGU2 YjcgMTAwNjQ0DQo+LS0tIGEvdG9vbHMvcGVyZi91aS90dWkvc2V0dXAuYw0KPisrKyBiL3Rvb2xz L3BlcmYvdWkvdHVpL3NldHVwLmMNCj5AQCAtMTMsNiArMTMsOCBAQA0KPiAjaW5jbHVkZSAiLi4v bGlic2xhbmcuaCINCj4gI2luY2x1ZGUgIi4uL2tleXN5bXMuaCINCj4gI2luY2x1ZGUgInR1aS5o Ig0KPisjaW5jbHVkZSAiLi4vLi4vdXRpbC9zeW1ib2wuaCINCj4rI2luY2x1ZGUgIi4uLy4uL3V0 aWwvdGhyZWFkLmgiDQo+DQo+IHN0YXRpYyB2b2xhdGlsZSBpbnQgdWlfX25lZWRfcmVzaXplOw0K Pg0KPkBAIC05NiwxNCArOTgsMzkgQEAgaW50IHVpX19nZXRjaChpbnQgZGVsYXlfc2VjcykNCj4g c3RhdGljIHZvaWQgdWlfX3NpZ25hbF9iYWNrdHJhY2UoaW50IHNpZykNCj4gew0KPiAJdm9pZCAq c3RhY2tkdW1wWzMyXTsNCj4tCXNpemVfdCBzaXplOw0KPisJc2l6ZV90IHNpemUsIGk7DQo+DQo+ IAl1aV9fZXhpdChmYWxzZSk7DQo+IAlwc2lnbmFsKHNpZywgInBlcmYiKTsNCj4NCj4gCXByaW50 ZigiLS0tLS0tLS0gYmFja3RyYWNlIC0tLS0tLS0tXG4iKTsNCj4gCXNpemUgPSBiYWNrdHJhY2Uo c3RhY2tkdW1wLCBBUlJBWV9TSVpFKHN0YWNrZHVtcCkpOw0KPi0JYmFja3RyYWNlX3N5bWJvbHNf ZmQoc3RhY2tkdW1wLCBzaXplLCBTVERPVVRfRklMRU5PKTsNCj4rCS8qIHNraXAgZmlyc3QgdHdv IHN0YWNrIGZyYW1lIChmb3IgdGhpcyBmdW5jdGlvbiBhbmQgc2lnbmFsIHN0YWNrKSAqLw0KPisJ Zm9yIChpID0gMjsgaSA8IHNpemU7IGkrKykgew0KPisJCXN0cnVjdCBhZGRyX2xvY2F0aW9uIGFs ID0gew0KPisJCQkuc3ltID0gTlVMTCwNCj4rCQl9Ow0KPisNCj4rCQkvKiB2YWxpZCBjYWxsY2hh aW4gZW5kcyB3aXRoIDAgYWRkcmVzcyAqLw0KPisJCWlmIChzdGFja2R1bXBbaV0gPT0gTlVMTCAm JiBpID09IChzaXplIC0gMSkpDQo+KwkJCWNvbnRpbnVlOw0KPisNCj4rCQl0aHJlYWRfX2ZpbmRf YWRkcl9sb2NhdGlvbihwZXJmX3RocmVhZCwgUEVSRl9SRUNPUkRfTUlTQ19VU0VSLA0KPisJCQkJ CSAgIE1BUF9fRlVOQ1RJT04sIChsb25nKXN0YWNrZHVtcFtpXSwgJmFsKTsNCj4rDQo+KwkJaWYg KCFhbC5zeW0pDQo+KwkJCWJyZWFrOw0KPisNCj4rCQlwcmludGYoIiVzKCsweCUiUFJJeDY0Iikg aW4gJXMgWzB4JWx4XVxuIiwgYWwuc3ltLT5uYW1lLA0KPisJCSAgICAgICBtYXBfX21hcF9pcChh bC5tYXAsICh1NjQpc3RhY2tkdW1wW2ldKSAtIGFsLnN5bS0+c3RhcnQsDQo+KwkJICAgICAgIGFs Lm1hcC0+ZHNvLT5zaG9ydF9uYW1lLCAodW5zaWduZWQgbG9uZylzdGFja2R1bXBbaV0pOw0KPisJ fQ0KPisNCj4rCWlmIChpICE9IHNpemUpIHsNCj4rCQlwcmludGYoIlxucGVyZiBiYWNrdHJhY2Ug c2VlbXMgYnJva2VuLCB0cnkgYWdhaW4gd2l0aCBnbGliY1xuIik7DQo+KwkJcHJpbnRmKCItLS0t LS0tLSBiYWNrdHJhY2UgLS0tLS0tLS1cbiIpOw0KPisJCWJhY2t0cmFjZV9zeW1ib2xzX2ZkKHN0 YWNrZHVtcCwgc2l6ZSwgU1RET1VUX0ZJTEVOTyk7DQo+Kwl9DQo+DQo+IAlleGl0KDApOw0KPiB9 DQo+ZGlmZiAtLWdpdCBhL3Rvb2xzL3BlcmYvdXRpbC91dGlsLmMgYi90b29scy9wZXJmL3V0aWwv dXRpbC5jDQo+aW5kZXggNzU3NTlhZWJjN2I4Li5iMWU1OTFiMTMxMzEgMTAwNjQ0DQo+LS0tIGEv dG9vbHMvcGVyZi91dGlsL3V0aWwuYw0KPisrKyBiL3Rvb2xzL3BlcmYvdXRpbC91dGlsLmMNCj5A QCAtMTYsNiArMTYsOSBAQA0KPiAjaW5jbHVkZSA8bGludXgva2VybmVsLmg+DQo+ICNpbmNsdWRl IDx1bmlzdGQuaD4NCj4gI2luY2x1ZGUgImNhbGxjaGFpbi5oIg0KPisjaW5jbHVkZSAibWFjaGlu ZS5oIg0KPisjaW5jbHVkZSAidGhyZWFkLmgiDQo+KyNpbmNsdWRlICJ0aHJlYWRfbWFwLmgiDQo+ DQo+IHN0cnVjdCBjYWxsY2hhaW5fcGFyYW0JY2FsbGNoYWluX3BhcmFtID0gew0KPiAJLm1vZGUJ PSBDSEFJTl9HUkFQSF9BQlMsDQo+QEAgLTY5NiwzICs2OTksNjMgQEAgZmV0Y2hfa2VybmVsX3Zl cnNpb24odW5zaWduZWQgaW50ICpwdWludCwgY2hhciAqc3RyLA0KPiAJCSpwdWludCA9ICh2ZXJz aW9uIDw8IDE2KSArIChwYXRjaGxldmVsIDw8IDgpICsgc3VibGV2ZWw7DQo+IAlyZXR1cm4gMDsN Cj4gfQ0KPisNCj4rDQo+K3N0YXRpYyBpbnQgcHJvY2Vzc19ldmVudChzdHJ1Y3QgcGVyZl90b29s ICp0b29sLCB1bmlvbiBwZXJmX2V2ZW50ICpldmVudCwNCj4rCQkJIHN0cnVjdCBwZXJmX3NhbXBs ZSAqc2FtcGxlLCBzdHJ1Y3QgbWFjaGluZSAqbWFjaGluZSkNCj4rew0KPisJc3dpdGNoIChldmVu dC0+aGVhZGVyLnR5cGUpIHsNCj4rCWNhc2UgUEVSRl9SRUNPUkRfQ09NTToNCj4rCQlyZXR1cm4g dG9vbC0+Y29tbSh0b29sLCBldmVudCwgc2FtcGxlLCBtYWNoaW5lKTsNCj4rCWNhc2UgUEVSRl9S RUNPUkRfTU1BUDoNCj4rCQlyZXR1cm4gdG9vbC0+bW1hcCh0b29sLCBldmVudCwgc2FtcGxlLCBt YWNoaW5lKTsNCj4rCWNhc2UgUEVSRl9SRUNPUkRfTU1BUDI6DQo+KwkJcmV0dXJuIHRvb2wtPm1t YXAyKHRvb2wsIGV2ZW50LCBzYW1wbGUsIG1hY2hpbmUpOw0KPisJZGVmYXVsdDoNCj4rCQlicmVh azsNCj4rCX0NCj4rCXJldHVybiAwOw0KPit9DQo+Kw0KPitzdHJ1Y3QgdGhyZWFkICpwZXJmX3Ro cmVhZDsNCj4rDQo+K2ludCBjcmVhdGVfcGVyZl90aHJlYWQodm9pZCkNCj4rew0KPisJc3RydWN0 IHBlcmZfdG9vbCB0b29sID0gew0KPisJCS5jb21tCT0gcGVyZl9ldmVudF9fcHJvY2Vzc19jb21t LA0KPisJCS5tbWFwCT0gcGVyZl9ldmVudF9fcHJvY2Vzc19tbWFwLA0KPisJCS5tbWFwMgk9IHBl cmZfZXZlbnRfX3Byb2Nlc3NfbW1hcDIsDQo+Kwl9Ow0KPisJc3RydWN0IHRocmVhZF9tYXAgKnRt Ow0KPisJc3RydWN0IG1hY2hpbmUgKm1hY2hpbmU7DQo+KwlpbnQgcGlkID0gZ2V0cGlkKCk7DQo+ Kw0KPisJbWFjaGluZSA9IG1hY2hpbmVfX25ld19ob3N0KCk7DQo+KwlpZiAobWFjaGluZSA9PSBO VUxMKQ0KPisJCXJldHVybiAtMTsNCj4rDQo+Kwl0bSA9IHRocmVhZF9tYXBfX25ld19kdW1teSgp Ow0KPisJaWYgKHRtID09IE5VTEwpIHsNCj4rCQltYWNoaW5lX19kZWxldGUobWFjaGluZSk7DQo+ KwkJcmV0dXJuIC0xOw0KPisJfQ0KPisNCj4rCXRocmVhZF9tYXBfX3NldF9waWQodG0sIDAsIHBp ZCk7DQo+Kw0KPisJcGVyZl9ldmVudF9fc3ludGhlc2l6ZV90aHJlYWRfbWFwKCZ0b29sLCB0bSwg cHJvY2Vzc19ldmVudCwgbWFjaGluZSwNCj4rCQkJCQkgIGZhbHNlLCA1MDApOw0KPisNCj4rCXBl cmZfdGhyZWFkID0gbWFjaGluZV9fZmluZF90aHJlYWQobWFjaGluZSwgcGlkLCBwaWQpOw0KPisJ QlVHX09OKHBlcmZfdGhyZWFkID09IE5VTEwpOw0KPisNCj4rCXRocmVhZF9tYXBfX3B1dCh0bSk7 DQo+KwlyZXR1cm4gMDsNCj4rfQ0KPisNCj4rdm9pZCBkZXN0cm95X3BlcmZfdGhyZWFkKHZvaWQp DQo+K3sNCj4rCXN0cnVjdCBtYWNoaW5lICptYWNoaW5lID0gcGVyZl90aHJlYWQtPm1nLT5tYWNo aW5lOw0KPisNCj4rCW1hY2hpbmVfX2RlbGV0ZV90aHJlYWRzKG1hY2hpbmUpOw0KPisJbWFjaGlu ZV9fZGVsZXRlKG1hY2hpbmUpOw0KPit9DQo+ZGlmZiAtLWdpdCBhL3Rvb2xzL3BlcmYvdXRpbC91 dGlsLmggYi90b29scy9wZXJmL3V0aWwvdXRpbC5oDQo+aW5kZXggZGNjNjU5MDE3OTc2Li43Njk5 ODYwNDRhN2EgMTAwNjQ0DQo+LS0tIGEvdG9vbHMvcGVyZi91dGlsL3V0aWwuaA0KPisrKyBiL3Rv b2xzL3BlcmYvdXRpbC91dGlsLmgNCj5AQCAtMzU4LDQgKzM1OCw5IEBAIGludCBmZXRjaF9rZXJu ZWxfdmVyc2lvbih1bnNpZ25lZCBpbnQgKnB1aW50LA0KPiAjZGVmaW5lIEtWRVJfRk1UCSIlZC4l ZC4lZCINCj4gI2RlZmluZSBLVkVSX1BBUkFNKHgpCUtWRVJfVkVSU0lPTih4KSwgS1ZFUl9QQVRD SExFVkVMKHgpLCBLVkVSX1NVQkxFVkVMKHgpDQo+DQo+K2V4dGVybiBzdHJ1Y3QgdGhyZWFkICpw ZXJmX3RocmVhZDsNCj4rDQo+K2ludCBjcmVhdGVfcGVyZl90aHJlYWQodm9pZCk7DQo+K3ZvaWQg ZGVzdHJveV9wZXJmX3RocmVhZCh2b2lkKTsNCj4rDQo+ICNlbmRpZiAvKiBHSVRfQ09NUEFUX1VU SUxfSCAqLw0KPi0tDQo+Mi42LjINCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Namhyung Kim <namhyung@kernel.org> |
|---|---|
| Date | 2015-12-03 02:30 +0100 |
| Subject | Re: [PATCH v3] perf tools: Introduce perf_thread for backtrace |
| Message-ID | <qBqSC-6Bi-3@gated-at.bofh.it> |
| In reply to | #1282617 |
On Thu, Dec 03, 2015 at 12:15:12AM +0000, 平松雅巳 / HIRAMATU，MASAMI wrote:
> >From: Namhyung Kim [mailto:namhyung@gmail.com] On Behalf Of Namhyung Kim
> >
> >Backtrace is a crucial info for debugging. And upcoming refcnt
> >tracking facility also wants to use it.
>
> Note that the refcnt backtrace symbol resolution will work at
> exit. This means that it can not depend on the feature in perf
> tools itself. (and of course, since the refcnt tries to find unused
> objects in perf tools at exit, if we use perf_thread, it will
> detect the objects related to the perf_thread are leaked)
Hmm.. right.
I think we can leave the perf_thread outside of refcnt infrastructure.
IOW it should be created before refcnt debugging is activated and
released after refcnt is done. What do you think?
Thanks,
Namhyung
>
> >
> >So instead of relying on glibc's backtrace_symbols[_fd] which misses
> >some (static) functions , use our own symbol searching mechanism. To
> >do that, add perf_thread global variable to keep its maps and symbols.
> >
> >The backtrace output from TUI is changed like below. (I made a key
> >action to generate a segfault):
> >
> >Before:
> > perf: Segmentation fault
> > -------- backtrace --------
> > perf[0x544a8b]
> > /usr/lib/libc.so.6(+0x33680)[0x7fc46420b680]
> > perf[0x54041b]
> > perf(perf_evlist__tui_browse_hists+0x91)[0x5432e1]
> > perf(cmd_report+0x1d20)[0x43cb10]
> > perf[0x487073]
> > perf(main+0x62f)[0x42cb1f]
> > /usr/lib/libc.so.6(__libc_start_main+0xf0)[0x7fc4641f8610]
> > perf(_start+0x29)[0x42cc39]
> >
> >After:
> > perf: Segmentation fault
> > -------- backtrace --------
> > perf_evsel__hists_browse(+0x43b) in perf [0x54066b]
> > perf_evlist__tui_browse_hists(+0x91) in perf [0x543531]
> > cmd_report(+0x1d20) in perf [0x43cb50]
> > run_builtin(+0x53) in perf [0x4870b3]
> > main(+0x634) in perf [0x42cb54]
> > __libc_start_main(+0xf0) in libc-2.22.so [0x7fea3577c610]
> > _start(+0x29) in perf [0x42cc79]
> >
> >Cc: Frederic Weisbecker <fweisbec@gmail.com>
> >Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> >Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> >---
> >v3) check return value of create_perf_thread()
> >
> >v2) fallback to glibc's backtrace_symbols_fd() if failed
> >
> > tools/perf/perf.c | 10 +++++++-
> > tools/perf/ui/tui/setup.c | 31 +++++++++++++++++++++--
> > tools/perf/util/util.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++
> > tools/perf/util/util.h | 5 ++++
> > 4 files changed, 106 insertions(+), 3 deletions(-)
> >
> >diff --git a/tools/perf/perf.c b/tools/perf/perf.c
> >index 4bee53c3f796..f27dc5fa9534 100644
> >--- a/tools/perf/perf.c
> >+++ b/tools/perf/perf.c
> >@@ -604,6 +604,11 @@ int main(int argc, const char **argv)
> > */
> > pthread__block_sigwinch();
> >
> >+ if (create_perf_thread() < 0) {
> >+ fprintf(stderr, "Failed to reserve information for backtrace\n");
> >+ goto out;
> >+ }
> >+
> > while (1) {
> > static int done_help;
> > int was_alias = run_argv(&argc, &argv);
> >@@ -615,7 +620,7 @@ int main(int argc, const char **argv)
> > fprintf(stderr, "Expansion of alias '%s' failed; "
> > "'%s' is not a perf-command\n",
> > cmd, argv[0]);
> >- goto out;
> >+ goto out_destroy;
> > }
> > if (!done_help) {
> > cmd = argv[0] = help_unknown_cmd(cmd);
> >@@ -626,6 +631,9 @@ int main(int argc, const char **argv)
> >
> > fprintf(stderr, "Failed to run command '%s': %s\n",
> > cmd, strerror_r(errno, sbuf, sizeof(sbuf)));
> >+
> >+out_destroy:
> >+ destroy_perf_thread();
> > out:
> > return 1;
> > }
> >diff --git a/tools/perf/ui/tui/setup.c b/tools/perf/ui/tui/setup.c
> >index 7dfeba0a91f3..ba0ff1c4e6b7 100644
> >--- a/tools/perf/ui/tui/setup.c
> >+++ b/tools/perf/ui/tui/setup.c
> >@@ -13,6 +13,8 @@
> > #include "../libslang.h"
> > #include "../keysyms.h"
> > #include "tui.h"
> >+#include "../../util/symbol.h"
> >+#include "../../util/thread.h"
> >
> > static volatile int ui__need_resize;
> >
> >@@ -96,14 +98,39 @@ int ui__getch(int delay_secs)
> > static void ui__signal_backtrace(int sig)
> > {
> > void *stackdump[32];
> >- size_t size;
> >+ size_t size, i;
> >
> > ui__exit(false);
> > psignal(sig, "perf");
> >
> > printf("-------- backtrace --------\n");
> > size = backtrace(stackdump, ARRAY_SIZE(stackdump));
> >- backtrace_symbols_fd(stackdump, size, STDOUT_FILENO);
> >+ /* skip first two stack frame (for this function and signal stack) */
> >+ for (i = 2; i < size; i++) {
> >+ struct addr_location al = {
> >+ .sym = NULL,
> >+ };
> >+
> >+ /* valid callchain ends with 0 address */
> >+ if (stackdump[i] == NULL && i == (size - 1))
> >+ continue;
> >+
> >+ thread__find_addr_location(perf_thread, PERF_RECORD_MISC_USER,
> >+ MAP__FUNCTION, (long)stackdump[i], &al);
> >+
> >+ if (!al.sym)
> >+ break;
> >+
> >+ printf("%s(+0x%"PRIx64") in %s [0x%lx]\n", al.sym->name,
> >+ map__map_ip(al.map, (u64)stackdump[i]) - al.sym->start,
> >+ al.map->dso->short_name, (unsigned long)stackdump[i]);
> >+ }
> >+
> >+ if (i != size) {
> >+ printf("\nperf backtrace seems broken, try again with glibc\n");
> >+ printf("-------- backtrace --------\n");
> >+ backtrace_symbols_fd(stackdump, size, STDOUT_FILENO);
> >+ }
> >
> > exit(0);
> > }
> >diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> >index 75759aebc7b8..b1e591b13131 100644
> >--- a/tools/perf/util/util.c
> >+++ b/tools/perf/util/util.c
> >@@ -16,6 +16,9 @@
> > #include <linux/kernel.h>
> > #include <unistd.h>
> > #include "callchain.h"
> >+#include "machine.h"
> >+#include "thread.h"
> >+#include "thread_map.h"
> >
> > struct callchain_param callchain_param = {
> > .mode = CHAIN_GRAPH_ABS,
> >@@ -696,3 +699,63 @@ fetch_kernel_version(unsigned int *puint, char *str,
> > *puint = (version << 16) + (patchlevel << 8) + sublevel;
> > return 0;
> > }
> >+
> >+
> >+static int process_event(struct perf_tool *tool, union perf_event *event,
> >+ struct perf_sample *sample, struct machine *machine)
> >+{
> >+ switch (event->header.type) {
> >+ case PERF_RECORD_COMM:
> >+ return tool->comm(tool, event, sample, machine);
> >+ case PERF_RECORD_MMAP:
> >+ return tool->mmap(tool, event, sample, machine);
> >+ case PERF_RECORD_MMAP2:
> >+ return tool->mmap2(tool, event, sample, machine);
> >+ default:
> >+ break;
> >+ }
> >+ return 0;
> >+}
> >+
> >+struct thread *perf_thread;
> >+
> >+int create_perf_thread(void)
> >+{
> >+ struct perf_tool tool = {
> >+ .comm = perf_event__process_comm,
> >+ .mmap = perf_event__process_mmap,
> >+ .mmap2 = perf_event__process_mmap2,
> >+ };
> >+ struct thread_map *tm;
> >+ struct machine *machine;
> >+ int pid = getpid();
> >+
> >+ machine = machine__new_host();
> >+ if (machine == NULL)
> >+ return -1;
> >+
> >+ tm = thread_map__new_dummy();
> >+ if (tm == NULL) {
> >+ machine__delete(machine);
> >+ return -1;
> >+ }
> >+
> >+ thread_map__set_pid(tm, 0, pid);
> >+
> >+ perf_event__synthesize_thread_map(&tool, tm, process_event, machine,
> >+ false, 500);
> >+
> >+ perf_thread = machine__find_thread(machine, pid, pid);
> >+ BUG_ON(perf_thread == NULL);
> >+
> >+ thread_map__put(tm);
> >+ return 0;
> >+}
> >+
> >+void destroy_perf_thread(void)
> >+{
> >+ struct machine *machine = perf_thread->mg->machine;
> >+
> >+ machine__delete_threads(machine);
> >+ machine__delete(machine);
> >+}
> >diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
> >index dcc659017976..769986044a7a 100644
> >--- a/tools/perf/util/util.h
> >+++ b/tools/perf/util/util.h
> >@@ -358,4 +358,9 @@ int fetch_kernel_version(unsigned int *puint,
> > #define KVER_FMT "%d.%d.%d"
> > #define KVER_PARAM(x) KVER_VERSION(x), KVER_PATCHLEVEL(x), KVER_SUBLEVEL(x)
> >
> >+extern struct thread *perf_thread;
> >+
> >+int create_perf_thread(void);
> >+void destroy_perf_thread(void);
> >+
> > #endif /* GIT_COMPAT_UTIL_H */
> >--
> >2.6.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | 平松雅巳 / HIRAMATU，MASAMI <masami.hiramatsu.pt@hitachi.com> |
|---|---|
| Date | 2015-12-03 08:20 +0100 |
| Subject | RE: [PATCH v3] perf tools: Introduce perf_thread for backtrace |
| Message-ID | <qBwlj-1No-3@gated-at.bofh.it> |
| In reply to | #1282635 |
RnJvbTogTmFtaHl1bmcgS2ltIFttYWlsdG86bmFtaHl1bmdAa2VybmVsLm9yZ10NCj4NCj5PbiBU aHUsIERlYyAwMywgMjAxNSBhdCAxMjoxNToxMkFNICswMDAwLCDlubPmnb7pm4Xlt7MgLyBISVJB TUFUVe+8jE1BU0FNSSB3cm90ZToNCj4+ID5Gcm9tOiBOYW1oeXVuZyBLaW0gW21haWx0bzpuYW1o eXVuZ0BnbWFpbC5jb21dIE9uIEJlaGFsZiBPZiBOYW1oeXVuZyBLaW0NCj4+ID4NCj4+ID5CYWNr dHJhY2UgaXMgYSBjcnVjaWFsIGluZm8gZm9yIGRlYnVnZ2luZy4gIEFuZCB1cGNvbWluZyByZWZj bnQNCj4+ID50cmFja2luZyBmYWNpbGl0eSBhbHNvIHdhbnRzIHRvIHVzZSBpdC4NCj4+DQo+PiBO b3RlIHRoYXQgdGhlIHJlZmNudCBiYWNrdHJhY2Ugc3ltYm9sIHJlc29sdXRpb24gd2lsbCB3b3Jr IGF0DQo+PiBleGl0LiBUaGlzIG1lYW5zIHRoYXQgaXQgY2FuIG5vdCBkZXBlbmQgb24gdGhlIGZl YXR1cmUgaW4gcGVyZg0KPj4gdG9vbHMgaXRzZWxmLiAoYW5kIG9mIGNvdXJzZSwgc2luY2UgdGhl IHJlZmNudCB0cmllcyB0byBmaW5kIHVudXNlZA0KPj4gb2JqZWN0cyBpbiBwZXJmIHRvb2xzIGF0 IGV4aXQsIGlmIHdlIHVzZSBwZXJmX3RocmVhZCwgaXQgd2lsbA0KPj4gZGV0ZWN0IHRoZSBvYmpl Y3RzIHJlbGF0ZWQgdG8gdGhlIHBlcmZfdGhyZWFkIGFyZSBsZWFrZWQpDQo+DQo+SG1tLi4gcmln aHQuDQo+DQo+SSB0aGluayB3ZSBjYW4gbGVhdmUgdGhlIHBlcmZfdGhyZWFkIG91dHNpZGUgb2Yg cmVmY250IGluZnJhc3RydWN0dXJlLg0KPklPVyBpdCBzaG91bGQgYmUgY3JlYXRlZCBiZWZvcmUg cmVmY250IGRlYnVnZ2luZyBpcyBhY3RpdmF0ZWQgYW5kDQo+cmVsZWFzZWQgYWZ0ZXIgcmVmY250 IGlzIGRvbmUuICBXaGF0IGRvIHlvdSB0aGluaz8NCg0KV291bGQgeW91IG1lYW4gd2UgZG9uJ3Qg ZGVidWcgdGhlIG9iamVjdHMgcmVsYXRlZCB0byBhIHBlcmZfdGhyZWFkPw0KSXQgd2lsbCBtZWFu IHRoYXQgeW91IGRvbid0IGRlYnVnIGFueXRoaW5nLCBzaW5jZSBwZXJmX3RocmVhZCBpbnZvbHZl cw0KbW9zdCBvZiByZWZjbnQgdXNpbmcgb2JqZWN0cywgbGlrZSBkc28sIG1hcCwgbWFwX2dyb3Vw cyBldGMuIEFuZCBzb21lDQpidWdzIGFyZSBhY3R1YWxseSBmb3VuZCBhdCB3aGVyZSB0aG9zZSBv YmplY3RzIGFyZSBoYW5kbGVkLg0KDQpJIHdvdWxkIG5vdCBsaWtlIHRvIGNhcmUgYWJvdXQgdGhl IG91dHB1dCBxdWFsaXR5IG9mIHRoZSBiYWNrdHJhY2Vfc3ltYm9scy4NCkkgb25seSBuZWVkIHRo ZSB0b3AgMi0zIGFkZHJlc3NlcyBvZiB0aGUgYmFja3RyYWNlIGJ1ZmZlciwgYmVjYXVzZSBJIGhh dmUNCihldS0pYWRkcjJsaW5lIGNvbW1hbmQgdG8gZmluZCB0aGUgYWN0dWFsIHNvdXJjZSBjb2Rl IGxpbmVzIGZyb20gdGhvc2UNCmFkZHJlc3NlcyA6KS4gSWYgeW91IG5lZWQsIEkgY2FuIGFsc28g cHJvdmlkZSBhbiBhZGRyZXNzIGRlY29kZXIgYXdrL3NoZWxsDQpzY3JpcHQgZm9yIHRoYXQuDQoN Ckluc3RlYWQsIEkgcHJlZmVyIHRvIGF2b2lkIGNvbXBsZXhpdHkgb24gdGhlICJkZWJ1Z2dpbmcg ZmVhdHVyZSIoYmVjYXVzZQ0KaXQgY2FuIGludHJvZHVjZSBuZXcgYnVncywpIGFuZCBtYWtlIGl0 IG1vcmUgcm9idXN0IChlLmcuIGlmIHdlIGZhaWxlZCB0bw0KZ2V0IHN5bWJvbCwganVzdCBzaG93 cyB0aGUgcmF3IGFkZHJlc3MpDQoNCkJUVywgdGhlIHJvYnVzdG5lc3MgaXMgYSBrZXkgcG9pbnQg Zm9yIGRlYnVnZ2luZy4gUGxlYXNlIGNvbnNpZGVyIHRoZSBjYXNlDQp0aGF0IHlvdSBoaXQgYW4g ZXJyb3Igb24gdGhlIG9iamVjdHMgaW4gdGhlIHBlcmZfdGhyZWFkLCBpdCBjb3VsZCBjYXVzZQ0K ZG91YmxlIGZhdWx0KHNlZ3YgYWdhaW4pIG9uIHRoZSBzYW1lIG9iamVjdC4gVGhhdCBpcyB3aGF0 IEkgYWN0dWFsbHkgZG9uJ3QNCndhbnQuDQoNClRoYW5rIHlvdSwNCg0KDQo+DQo+VGhhbmtzLA0K Pk5hbWh5dW5nDQo+DQo+DQo+Pg0KPj4gPg0KPj4gPlNvIGluc3RlYWQgb2YgcmVseWluZyBvbiBn bGliYydzIGJhY2t0cmFjZV9zeW1ib2xzW19mZF0gd2hpY2ggbWlzc2VzDQo+PiA+c29tZSAoc3Rh dGljKSBmdW5jdGlvbnMgLCB1c2Ugb3VyIG93biBzeW1ib2wgc2VhcmNoaW5nIG1lY2hhbmlzbS4g IFRvDQo+PiA+ZG8gdGhhdCwgYWRkIHBlcmZfdGhyZWFkIGdsb2JhbCB2YXJpYWJsZSB0byBrZWVw IGl0cyBtYXBzIGFuZCBzeW1ib2xzLg0KPj4gPg0KPj4gPlRoZSBiYWNrdHJhY2Ugb3V0cHV0IGZy b20gVFVJIGlzIGNoYW5nZWQgbGlrZSBiZWxvdy4gIChJIG1hZGUgYSBrZXkNCj4+ID5hY3Rpb24g dG8gZ2VuZXJhdGUgYSBzZWdmYXVsdCk6DQo+PiA+DQo+PiA+QmVmb3JlOg0KPj4gPiAgcGVyZjog U2VnbWVudGF0aW9uIGZhdWx0DQo+PiA+ICAtLS0tLS0tLSBiYWNrdHJhY2UgLS0tLS0tLS0NCj4+ ID4gIHBlcmZbMHg1NDRhOGJdDQo+PiA+ICAvdXNyL2xpYi9saWJjLnNvLjYoKzB4MzM2ODApWzB4 N2ZjNDY0MjBiNjgwXQ0KPj4gPiAgcGVyZlsweDU0MDQxYl0NCj4+ID4gIHBlcmYocGVyZl9ldmxp c3RfX3R1aV9icm93c2VfaGlzdHMrMHg5MSlbMHg1NDMyZTFdDQo+PiA+ICBwZXJmKGNtZF9yZXBv cnQrMHgxZDIwKVsweDQzY2IxMF0NCj4+ID4gIHBlcmZbMHg0ODcwNzNdDQo+PiA+ICBwZXJmKG1h aW4rMHg2MmYpWzB4NDJjYjFmXQ0KPj4gPiAgL3Vzci9saWIvbGliYy5zby42KF9fbGliY19zdGFy dF9tYWluKzB4ZjApWzB4N2ZjNDY0MWY4NjEwXQ0KPj4gPiAgcGVyZihfc3RhcnQrMHgyOSlbMHg0 MmNjMzldDQo+PiA+DQo+PiA+QWZ0ZXI6DQo+PiA+ICBwZXJmOiBTZWdtZW50YXRpb24gZmF1bHQN Cj4+ID4gIC0tLS0tLS0tIGJhY2t0cmFjZSAtLS0tLS0tLQ0KPj4gPiAgcGVyZl9ldnNlbF9faGlz dHNfYnJvd3NlKCsweDQzYikgaW4gcGVyZiBbMHg1NDA2NmJdDQo+PiA+ICBwZXJmX2V2bGlzdF9f dHVpX2Jyb3dzZV9oaXN0cygrMHg5MSkgaW4gcGVyZiBbMHg1NDM1MzFdDQo+PiA+ICBjbWRfcmVw b3J0KCsweDFkMjApIGluIHBlcmYgWzB4NDNjYjUwXQ0KPj4gPiAgcnVuX2J1aWx0aW4oKzB4NTMp IGluIHBlcmYgWzB4NDg3MGIzXQ0KPj4gPiAgbWFpbigrMHg2MzQpIGluIHBlcmYgWzB4NDJjYjU0 XQ0KPj4gPiAgX19saWJjX3N0YXJ0X21haW4oKzB4ZjApIGluIGxpYmMtMi4yMi5zbyBbMHg3ZmVh MzU3N2M2MTBdDQo+PiA+ICBfc3RhcnQoKzB4MjkpIGluIHBlcmYgWzB4NDJjYzc5XQ0KPj4gPg0K Pj4gPkNjOiBGcmVkZXJpYyBXZWlzYmVja2VyIDxmd2Vpc2JlY0BnbWFpbC5jb20+DQo+PiA+Q2M6 IE1hc2FtaSBIaXJhbWF0c3UgPG1hc2FtaS5oaXJhbWF0c3UucHRAaGl0YWNoaS5jb20+DQo+PiA+ U2lnbmVkLW9mZi1ieTogTmFtaHl1bmcgS2ltIDxuYW1oeXVuZ0BrZXJuZWwub3JnPg0KPj4gPi0t LQ0KPj4gPnYzKSBjaGVjayByZXR1cm4gdmFsdWUgb2YgY3JlYXRlX3BlcmZfdGhyZWFkKCkNCj4+ ID4NCj4+ID52MikgZmFsbGJhY2sgdG8gZ2xpYmMncyBiYWNrdHJhY2Vfc3ltYm9sc19mZCgpIGlm IGZhaWxlZA0KPj4gPg0KPj4gPiB0b29scy9wZXJmL3BlcmYuYyAgICAgICAgIHwgMTAgKysrKysr Ky0NCj4+ID4gdG9vbHMvcGVyZi91aS90dWkvc2V0dXAuYyB8IDMxICsrKysrKysrKysrKysrKysr KysrKy0tDQo+PiA+IHRvb2xzL3BlcmYvdXRpbC91dGlsLmMgICAgfCA2MyArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPj4gPiB0b29scy9wZXJmL3V0aWwv dXRpbC5oICAgIHwgIDUgKysrKw0KPj4gPiA0IGZpbGVzIGNoYW5nZWQsIDEwNiBpbnNlcnRpb25z KCspLCAzIGRlbGV0aW9ucygtKQ0KPj4gPg0KPj4gPmRpZmYgLS1naXQgYS90b29scy9wZXJmL3Bl cmYuYyBiL3Rvb2xzL3BlcmYvcGVyZi5jDQo+PiA+aW5kZXggNGJlZTUzYzNmNzk2Li5mMjdkYzVm YTk1MzQgMTAwNjQ0DQo+PiA+LS0tIGEvdG9vbHMvcGVyZi9wZXJmLmMNCj4+ID4rKysgYi90b29s cy9wZXJmL3BlcmYuYw0KPj4gPkBAIC02MDQsNiArNjA0LDExIEBAIGludCBtYWluKGludCBhcmdj LCBjb25zdCBjaGFyICoqYXJndikNCj4+ID4gCSAqLw0KPj4gPiAJcHRocmVhZF9fYmxvY2tfc2ln d2luY2goKTsNCj4+ID4NCj4+ID4rCWlmIChjcmVhdGVfcGVyZl90aHJlYWQoKSA8IDApIHsNCj4+ ID4rCQlmcHJpbnRmKHN0ZGVyciwgIkZhaWxlZCB0byByZXNlcnZlIGluZm9ybWF0aW9uIGZvciBi YWNrdHJhY2VcbiIpOw0KPj4gPisJCWdvdG8gb3V0Ow0KPj4gPisJfQ0KPj4gPisNCj4+ID4gCXdo aWxlICgxKSB7DQo+PiA+IAkJc3RhdGljIGludCBkb25lX2hlbHA7DQo+PiA+IAkJaW50IHdhc19h bGlhcyA9IHJ1bl9hcmd2KCZhcmdjLCAmYXJndik7DQo+PiA+QEAgLTYxNSw3ICs2MjAsNyBAQCBp bnQgbWFpbihpbnQgYXJnYywgY29uc3QgY2hhciAqKmFyZ3YpDQo+PiA+IAkJCWZwcmludGYoc3Rk ZXJyLCAiRXhwYW5zaW9uIG9mIGFsaWFzICclcycgZmFpbGVkOyAiDQo+PiA+IAkJCQkiJyVzJyBp cyBub3QgYSBwZXJmLWNvbW1hbmRcbiIsDQo+PiA+IAkJCQljbWQsIGFyZ3ZbMF0pOw0KPj4gPi0J CQlnb3RvIG91dDsNCj4+ID4rCQkJZ290byBvdXRfZGVzdHJveTsNCj4+ID4gCQl9DQo+PiA+IAkJ aWYgKCFkb25lX2hlbHApIHsNCj4+ID4gCQkJY21kID0gYXJndlswXSA9IGhlbHBfdW5rbm93bl9j bWQoY21kKTsNCj4+ID5AQCAtNjI2LDYgKzYzMSw5IEBAIGludCBtYWluKGludCBhcmdjLCBjb25z dCBjaGFyICoqYXJndikNCj4+ID4NCj4+ID4gCWZwcmludGYoc3RkZXJyLCAiRmFpbGVkIHRvIHJ1 biBjb21tYW5kICclcyc6ICVzXG4iLA0KPj4gPiAJCWNtZCwgc3RyZXJyb3JfcihlcnJubywgc2J1 Ziwgc2l6ZW9mKHNidWYpKSk7DQo+PiA+Kw0KPj4gPitvdXRfZGVzdHJveToNCj4+ID4rCWRlc3Ry b3lfcGVyZl90aHJlYWQoKTsNCj4+ID4gb3V0Og0KPj4gPiAJcmV0dXJuIDE7DQo+PiA+IH0NCj4+ ID5kaWZmIC0tZ2l0IGEvdG9vbHMvcGVyZi91aS90dWkvc2V0dXAuYyBiL3Rvb2xzL3BlcmYvdWkv dHVpL3NldHVwLmMNCj4+ID5pbmRleCA3ZGZlYmEwYTkxZjMuLmJhMGZmMWM0ZTZiNyAxMDA2NDQN Cj4+ID4tLS0gYS90b29scy9wZXJmL3VpL3R1aS9zZXR1cC5jDQo+PiA+KysrIGIvdG9vbHMvcGVy Zi91aS90dWkvc2V0dXAuYw0KPj4gPkBAIC0xMyw2ICsxMyw4IEBADQo+PiA+ICNpbmNsdWRlICIu Li9saWJzbGFuZy5oIg0KPj4gPiAjaW5jbHVkZSAiLi4va2V5c3ltcy5oIg0KPj4gPiAjaW5jbHVk ZSAidHVpLmgiDQo+PiA+KyNpbmNsdWRlICIuLi8uLi91dGlsL3N5bWJvbC5oIg0KPj4gPisjaW5j bHVkZSAiLi4vLi4vdXRpbC90aHJlYWQuaCINCj4+ID4NCj4+ID4gc3RhdGljIHZvbGF0aWxlIGlu dCB1aV9fbmVlZF9yZXNpemU7DQo+PiA+DQo+PiA+QEAgLTk2LDE0ICs5OCwzOSBAQCBpbnQgdWlf X2dldGNoKGludCBkZWxheV9zZWNzKQ0KPj4gPiBzdGF0aWMgdm9pZCB1aV9fc2lnbmFsX2JhY2t0 cmFjZShpbnQgc2lnKQ0KPj4gPiB7DQo+PiA+IAl2b2lkICpzdGFja2R1bXBbMzJdOw0KPj4gPi0J c2l6ZV90IHNpemU7DQo+PiA+KwlzaXplX3Qgc2l6ZSwgaTsNCj4+ID4NCj4+ID4gCXVpX19leGl0 KGZhbHNlKTsNCj4+ID4gCXBzaWduYWwoc2lnLCAicGVyZiIpOw0KPj4gPg0KPj4gPiAJcHJpbnRm KCItLS0tLS0tLSBiYWNrdHJhY2UgLS0tLS0tLS1cbiIpOw0KPj4gPiAJc2l6ZSA9IGJhY2t0cmFj ZShzdGFja2R1bXAsIEFSUkFZX1NJWkUoc3RhY2tkdW1wKSk7DQo+PiA+LQliYWNrdHJhY2Vfc3lt Ym9sc19mZChzdGFja2R1bXAsIHNpemUsIFNURE9VVF9GSUxFTk8pOw0KPj4gPisJLyogc2tpcCBm aXJzdCB0d28gc3RhY2sgZnJhbWUgKGZvciB0aGlzIGZ1bmN0aW9uIGFuZCBzaWduYWwgc3RhY2sp ICovDQo+PiA+Kwlmb3IgKGkgPSAyOyBpIDwgc2l6ZTsgaSsrKSB7DQo+PiA+KwkJc3RydWN0IGFk ZHJfbG9jYXRpb24gYWwgPSB7DQo+PiA+KwkJCS5zeW0gPSBOVUxMLA0KPj4gPisJCX07DQo+PiA+ Kw0KPj4gPisJCS8qIHZhbGlkIGNhbGxjaGFpbiBlbmRzIHdpdGggMCBhZGRyZXNzICovDQo+PiA+ KwkJaWYgKHN0YWNrZHVtcFtpXSA9PSBOVUxMICYmIGkgPT0gKHNpemUgLSAxKSkNCj4+ID4rCQkJ Y29udGludWU7DQo+PiA+Kw0KPj4gPisJCXRocmVhZF9fZmluZF9hZGRyX2xvY2F0aW9uKHBlcmZf dGhyZWFkLCBQRVJGX1JFQ09SRF9NSVNDX1VTRVIsDQo+PiA+KwkJCQkJICAgTUFQX19GVU5DVElP TiwgKGxvbmcpc3RhY2tkdW1wW2ldLCAmYWwpOw0KPj4gPisNCj4+ID4rCQlpZiAoIWFsLnN5bSkN Cj4+ID4rCQkJYnJlYWs7DQo+PiA+Kw0KPj4gPisJCXByaW50ZigiJXMoKzB4JSJQUkl4NjQiKSBp biAlcyBbMHglbHhdXG4iLCBhbC5zeW0tPm5hbWUsDQo+PiA+KwkJICAgICAgIG1hcF9fbWFwX2lw KGFsLm1hcCwgKHU2NClzdGFja2R1bXBbaV0pIC0gYWwuc3ltLT5zdGFydCwNCj4+ID4rCQkgICAg ICAgYWwubWFwLT5kc28tPnNob3J0X25hbWUsICh1bnNpZ25lZCBsb25nKXN0YWNrZHVtcFtpXSk7 DQo+PiA+Kwl9DQo+PiA+Kw0KPj4gPisJaWYgKGkgIT0gc2l6ZSkgew0KPj4gPisJCXByaW50Zigi XG5wZXJmIGJhY2t0cmFjZSBzZWVtcyBicm9rZW4sIHRyeSBhZ2FpbiB3aXRoIGdsaWJjXG4iKTsN Cj4+ID4rCQlwcmludGYoIi0tLS0tLS0tIGJhY2t0cmFjZSAtLS0tLS0tLVxuIik7DQo+PiA+KwkJ YmFja3RyYWNlX3N5bWJvbHNfZmQoc3RhY2tkdW1wLCBzaXplLCBTVERPVVRfRklMRU5PKTsNCj4+ ID4rCX0NCj4+ID4NCj4+ID4gCWV4aXQoMCk7DQo+PiA+IH0NCj4+ID5kaWZmIC0tZ2l0IGEvdG9v bHMvcGVyZi91dGlsL3V0aWwuYyBiL3Rvb2xzL3BlcmYvdXRpbC91dGlsLmMNCj4+ID5pbmRleCA3 NTc1OWFlYmM3YjguLmIxZTU5MWIxMzEzMSAxMDA2NDQNCj4+ID4tLS0gYS90b29scy9wZXJmL3V0 aWwvdXRpbC5jDQo+PiA+KysrIGIvdG9vbHMvcGVyZi91dGlsL3V0aWwuYw0KPj4gPkBAIC0xNiw2 ICsxNiw5IEBADQo+PiA+ICNpbmNsdWRlIDxsaW51eC9rZXJuZWwuaD4NCj4+ID4gI2luY2x1ZGUg PHVuaXN0ZC5oPg0KPj4gPiAjaW5jbHVkZSAiY2FsbGNoYWluLmgiDQo+PiA+KyNpbmNsdWRlICJt YWNoaW5lLmgiDQo+PiA+KyNpbmNsdWRlICJ0aHJlYWQuaCINCj4+ID4rI2luY2x1ZGUgInRocmVh ZF9tYXAuaCINCj4+ID4NCj4+ID4gc3RydWN0IGNhbGxjaGFpbl9wYXJhbQljYWxsY2hhaW5fcGFy YW0gPSB7DQo+PiA+IAkubW9kZQk9IENIQUlOX0dSQVBIX0FCUywNCj4+ID5AQCAtNjk2LDMgKzY5 OSw2MyBAQCBmZXRjaF9rZXJuZWxfdmVyc2lvbih1bnNpZ25lZCBpbnQgKnB1aW50LCBjaGFyICpz dHIsDQo+PiA+IAkJKnB1aW50ID0gKHZlcnNpb24gPDwgMTYpICsgKHBhdGNobGV2ZWwgPDwgOCkg KyBzdWJsZXZlbDsNCj4+ID4gCXJldHVybiAwOw0KPj4gPiB9DQo+PiA+Kw0KPj4gPisNCj4+ID4r c3RhdGljIGludCBwcm9jZXNzX2V2ZW50KHN0cnVjdCBwZXJmX3Rvb2wgKnRvb2wsIHVuaW9uIHBl cmZfZXZlbnQgKmV2ZW50LA0KPj4gPisJCQkgc3RydWN0IHBlcmZfc2FtcGxlICpzYW1wbGUsIHN0 cnVjdCBtYWNoaW5lICptYWNoaW5lKQ0KPj4gPit7DQo+PiA+Kwlzd2l0Y2ggKGV2ZW50LT5oZWFk ZXIudHlwZSkgew0KPj4gPisJY2FzZSBQRVJGX1JFQ09SRF9DT01NOg0KPj4gPisJCXJldHVybiB0 b29sLT5jb21tKHRvb2wsIGV2ZW50LCBzYW1wbGUsIG1hY2hpbmUpOw0KPj4gPisJY2FzZSBQRVJG X1JFQ09SRF9NTUFQOg0KPj4gPisJCXJldHVybiB0b29sLT5tbWFwKHRvb2wsIGV2ZW50LCBzYW1w bGUsIG1hY2hpbmUpOw0KPj4gPisJY2FzZSBQRVJGX1JFQ09SRF9NTUFQMjoNCj4+ID4rCQlyZXR1 cm4gdG9vbC0+bW1hcDIodG9vbCwgZXZlbnQsIHNhbXBsZSwgbWFjaGluZSk7DQo+PiA+KwlkZWZh dWx0Og0KPj4gPisJCWJyZWFrOw0KPj4gPisJfQ0KPj4gPisJcmV0dXJuIDA7DQo+PiA+K30NCj4+ ID4rDQo+PiA+K3N0cnVjdCB0aHJlYWQgKnBlcmZfdGhyZWFkOw0KPj4gPisNCj4+ID4raW50IGNy ZWF0ZV9wZXJmX3RocmVhZCh2b2lkKQ0KPj4gPit7DQo+PiA+KwlzdHJ1Y3QgcGVyZl90b29sIHRv b2wgPSB7DQo+PiA+KwkJLmNvbW0JPSBwZXJmX2V2ZW50X19wcm9jZXNzX2NvbW0sDQo+PiA+KwkJ Lm1tYXAJPSBwZXJmX2V2ZW50X19wcm9jZXNzX21tYXAsDQo+PiA+KwkJLm1tYXAyCT0gcGVyZl9l dmVudF9fcHJvY2Vzc19tbWFwMiwNCj4+ID4rCX07DQo+PiA+KwlzdHJ1Y3QgdGhyZWFkX21hcCAq dG07DQo+PiA+KwlzdHJ1Y3QgbWFjaGluZSAqbWFjaGluZTsNCj4+ID4rCWludCBwaWQgPSBnZXRw aWQoKTsNCj4+ID4rDQo+PiA+KwltYWNoaW5lID0gbWFjaGluZV9fbmV3X2hvc3QoKTsNCj4+ID4r CWlmIChtYWNoaW5lID09IE5VTEwpDQo+PiA+KwkJcmV0dXJuIC0xOw0KPj4gPisNCj4+ID4rCXRt ID0gdGhyZWFkX21hcF9fbmV3X2R1bW15KCk7DQo+PiA+KwlpZiAodG0gPT0gTlVMTCkgew0KPj4g PisJCW1hY2hpbmVfX2RlbGV0ZShtYWNoaW5lKTsNCj4+ID4rCQlyZXR1cm4gLTE7DQo+PiA+Kwl9 DQo+PiA+Kw0KPj4gPisJdGhyZWFkX21hcF9fc2V0X3BpZCh0bSwgMCwgcGlkKTsNCj4+ID4rDQo+ PiA+KwlwZXJmX2V2ZW50X19zeW50aGVzaXplX3RocmVhZF9tYXAoJnRvb2wsIHRtLCBwcm9jZXNz X2V2ZW50LCBtYWNoaW5lLA0KPj4gPisJCQkJCSAgZmFsc2UsIDUwMCk7DQo+PiA+Kw0KPj4gPisJ cGVyZl90aHJlYWQgPSBtYWNoaW5lX19maW5kX3RocmVhZChtYWNoaW5lLCBwaWQsIHBpZCk7DQo+ PiA+KwlCVUdfT04ocGVyZl90aHJlYWQgPT0gTlVMTCk7DQo+PiA+Kw0KPj4gPisJdGhyZWFkX21h cF9fcHV0KHRtKTsNCj4+ID4rCXJldHVybiAwOw0KPj4gPit9DQo+PiA+Kw0KPj4gPit2b2lkIGRl c3Ryb3lfcGVyZl90aHJlYWQodm9pZCkNCj4+ID4rew0KPj4gPisJc3RydWN0IG1hY2hpbmUgKm1h Y2hpbmUgPSBwZXJmX3RocmVhZC0+bWctPm1hY2hpbmU7DQo+PiA+Kw0KPj4gPisJbWFjaGluZV9f ZGVsZXRlX3RocmVhZHMobWFjaGluZSk7DQo+PiA+KwltYWNoaW5lX19kZWxldGUobWFjaGluZSk7 DQo+PiA+K30NCj4+ID5kaWZmIC0tZ2l0IGEvdG9vbHMvcGVyZi91dGlsL3V0aWwuaCBiL3Rvb2xz L3BlcmYvdXRpbC91dGlsLmgNCj4+ID5pbmRleCBkY2M2NTkwMTc5NzYuLjc2OTk4NjA0NGE3YSAx MDA2NDQNCj4+ID4tLS0gYS90b29scy9wZXJmL3V0aWwvdXRpbC5oDQo+PiA+KysrIGIvdG9vbHMv cGVyZi91dGlsL3V0aWwuaA0KPj4gPkBAIC0zNTgsNCArMzU4LDkgQEAgaW50IGZldGNoX2tlcm5l bF92ZXJzaW9uKHVuc2lnbmVkIGludCAqcHVpbnQsDQo+PiA+ICNkZWZpbmUgS1ZFUl9GTVQJIiVk LiVkLiVkIg0KPj4gPiAjZGVmaW5lIEtWRVJfUEFSQU0oeCkJS1ZFUl9WRVJTSU9OKHgpLCBLVkVS X1BBVENITEVWRUwoeCksIEtWRVJfU1VCTEVWRUwoeCkNCj4+ID4NCj4+ID4rZXh0ZXJuIHN0cnVj dCB0aHJlYWQgKnBlcmZfdGhyZWFkOw0KPj4gPisNCj4+ID4raW50IGNyZWF0ZV9wZXJmX3RocmVh ZCh2b2lkKTsNCj4+ID4rdm9pZCBkZXN0cm95X3BlcmZfdGhyZWFkKHZvaWQpOw0KPj4gPisNCj4+ ID4gI2VuZGlmIC8qIEdJVF9DT01QQVRfVVRJTF9IICovDQo+PiA+LS0NCj4+ID4yLjYuMg0KPj4N Cg== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Namhyung Kim <namhyung@kernel.org> |
|---|---|
| Date | 2015-12-04 14:20 +0100 |
| Subject | Re: [PATCH v3] perf tools: Introduce perf_thread for backtrace |
| Message-ID | <qBYrg-38d-1@gated-at.bofh.it> |
| In reply to | #1282748 |
Hi Masami, On Thu, Dec 03, 2015 at 07:13:15AM +0000, 平松雅巳 / HIRAMATU，MASAMI wrote: > From: Namhyung Kim [mailto:namhyung@kernel.org] > > > >On Thu, Dec 03, 2015 at 12:15:12AM +0000, 平松雅巳 / HIRAMATU，MASAMI wrote: > >> >From: Namhyung Kim [mailto:namhyung@gmail.com] On Behalf Of Namhyung Kim > >> > > >> >Backtrace is a crucial info for debugging. And upcoming refcnt > >> >tracking facility also wants to use it. > >> > >> Note that the refcnt backtrace symbol resolution will work at > >> exit. This means that it can not depend on the feature in perf > >> tools itself. (and of course, since the refcnt tries to find unused > >> objects in perf tools at exit, if we use perf_thread, it will > >> detect the objects related to the perf_thread are leaked) > > > >Hmm.. right. > > > >I think we can leave the perf_thread outside of refcnt infrastructure. > >IOW it should be created before refcnt debugging is activated and > >released after refcnt is done. What do you think? > > Would you mean we don't debug the objects related to a perf_thread? > It will mean that you don't debug anything, since perf_thread involves > most of refcnt using objects, like dso, map, map_groups etc. And some > bugs are actually found at where those objects are handled. > > I would not like to care about the output quality of the backtrace_symbols. > I only need the top 2-3 addresses of the backtrace buffer, because I have > (eu-)addr2line command to find the actual source code lines from those > addresses :). If you need, I can also provide an address decoder awk/shell > script for that. > > Instead, I prefer to avoid complexity on the "debugging feature"(because > it can introduce new bugs,) and make it more robust (e.g. if we failed to > get symbol, just shows the raw address) > > BTW, the robustness is a key point for debugging. Please consider the case > that you hit an error on the objects in the perf_thread, it could cause > double fault(segv again) on the same object. That is what I actually don't > want. I understand your point. If you object, I won't insist it strongly. It's possible there's a bug in perf_thread symbol resolution. But it's pretty straightforward and simple use case so if there's a bug in that code, it should be found beforehand IMHO. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | 平松雅巳 / HIRAMATU，MASAMI <masami.hiramatsu.pt@hitachi.com> |
|---|---|
| Date | 2015-12-06 04:40 +0100 |
| Subject | RE: [PATCH v3] perf tools: Introduce perf_thread for backtrace |
| Message-ID | <qCyl3-1x2-3@gated-at.bofh.it> |
| In reply to | #1283808 |
SGkgTmFtaHl1bmcsDQoNCj5Gcm9tOiBOYW1oeXVuZyBLaW0gW21haWx0bzpuYW1oeXVuZ0BnbWFp bC5jb21dIE9uIEJlaGFsZiBPZiBOYW1oeXVuZyBLaW0NCj4NCj5IaSBNYXNhbWksDQo+DQo+T24g VGh1LCBEZWMgMDMsIDIwMTUgYXQgMDc6MTM6MTVBTSArMDAwMCwg5bmz5p2+6ZuF5bezIC8gSElS QU1BVFXvvIxNQVNBTUkgd3JvdGU6DQo+PiBGcm9tOiBOYW1oeXVuZyBLaW0gW21haWx0bzpuYW1o eXVuZ0BrZXJuZWwub3JnXQ0KPj4gPg0KPj4gPk9uIFRodSwgRGVjIDAzLCAyMDE1IGF0IDEyOjE1 OjEyQU0gKzAwMDAsIOW5s+advumbheW3syAvIEhJUkFNQVRV77yMTUFTQU1JIHdyb3RlOg0KPj4g Pj4gPkZyb206IE5hbWh5dW5nIEtpbSBbbWFpbHRvOm5hbWh5dW5nQGdtYWlsLmNvbV0gT24gQmVo YWxmIE9mIE5hbWh5dW5nIEtpbQ0KPj4gPj4gPg0KPj4gPj4gPkJhY2t0cmFjZSBpcyBhIGNydWNp YWwgaW5mbyBmb3IgZGVidWdnaW5nLiAgQW5kIHVwY29taW5nIHJlZmNudA0KPj4gPj4gPnRyYWNr aW5nIGZhY2lsaXR5IGFsc28gd2FudHMgdG8gdXNlIGl0Lg0KPj4gPj4NCj4+ID4+IE5vdGUgdGhh dCB0aGUgcmVmY250IGJhY2t0cmFjZSBzeW1ib2wgcmVzb2x1dGlvbiB3aWxsIHdvcmsgYXQNCj4+ ID4+IGV4aXQuIFRoaXMgbWVhbnMgdGhhdCBpdCBjYW4gbm90IGRlcGVuZCBvbiB0aGUgZmVhdHVy ZSBpbiBwZXJmDQo+PiA+PiB0b29scyBpdHNlbGYuIChhbmQgb2YgY291cnNlLCBzaW5jZSB0aGUg cmVmY250IHRyaWVzIHRvIGZpbmQgdW51c2VkDQo+PiA+PiBvYmplY3RzIGluIHBlcmYgdG9vbHMg YXQgZXhpdCwgaWYgd2UgdXNlIHBlcmZfdGhyZWFkLCBpdCB3aWxsDQo+PiA+PiBkZXRlY3QgdGhl IG9iamVjdHMgcmVsYXRlZCB0byB0aGUgcGVyZl90aHJlYWQgYXJlIGxlYWtlZCkNCj4+ID4NCj4+ ID5IbW0uLiByaWdodC4NCj4+ID4NCj4+ID5JIHRoaW5rIHdlIGNhbiBsZWF2ZSB0aGUgcGVyZl90 aHJlYWQgb3V0c2lkZSBvZiByZWZjbnQgaW5mcmFzdHJ1Y3R1cmUuDQo+PiA+SU9XIGl0IHNob3Vs ZCBiZSBjcmVhdGVkIGJlZm9yZSByZWZjbnQgZGVidWdnaW5nIGlzIGFjdGl2YXRlZCBhbmQNCj4+ ID5yZWxlYXNlZCBhZnRlciByZWZjbnQgaXMgZG9uZS4gIFdoYXQgZG8geW91IHRoaW5rPw0KPj4N Cj4+IFdvdWxkIHlvdSBtZWFuIHdlIGRvbid0IGRlYnVnIHRoZSBvYmplY3RzIHJlbGF0ZWQgdG8g YSBwZXJmX3RocmVhZD8NCj4+IEl0IHdpbGwgbWVhbiB0aGF0IHlvdSBkb24ndCBkZWJ1ZyBhbnl0 aGluZywgc2luY2UgcGVyZl90aHJlYWQgaW52b2x2ZXMNCj4+IG1vc3Qgb2YgcmVmY250IHVzaW5n IG9iamVjdHMsIGxpa2UgZHNvLCBtYXAsIG1hcF9ncm91cHMgZXRjLiBBbmQgc29tZQ0KPj4gYnVn cyBhcmUgYWN0dWFsbHkgZm91bmQgYXQgd2hlcmUgdGhvc2Ugb2JqZWN0cyBhcmUgaGFuZGxlZC4N Cj4+DQo+PiBJIHdvdWxkIG5vdCBsaWtlIHRvIGNhcmUgYWJvdXQgdGhlIG91dHB1dCBxdWFsaXR5 IG9mIHRoZSBiYWNrdHJhY2Vfc3ltYm9scy4NCj4+IEkgb25seSBuZWVkIHRoZSB0b3AgMi0zIGFk ZHJlc3NlcyBvZiB0aGUgYmFja3RyYWNlIGJ1ZmZlciwgYmVjYXVzZSBJIGhhdmUNCj4+IChldS0p YWRkcjJsaW5lIGNvbW1hbmQgdG8gZmluZCB0aGUgYWN0dWFsIHNvdXJjZSBjb2RlIGxpbmVzIGZy b20gdGhvc2UNCj4+IGFkZHJlc3NlcyA6KS4gSWYgeW91IG5lZWQsIEkgY2FuIGFsc28gcHJvdmlk ZSBhbiBhZGRyZXNzIGRlY29kZXIgYXdrL3NoZWxsDQo+PiBzY3JpcHQgZm9yIHRoYXQuDQo+Pg0K Pj4gSW5zdGVhZCwgSSBwcmVmZXIgdG8gYXZvaWQgY29tcGxleGl0eSBvbiB0aGUgImRlYnVnZ2lu ZyBmZWF0dXJlIihiZWNhdXNlDQo+PiBpdCBjYW4gaW50cm9kdWNlIG5ldyBidWdzLCkgYW5kIG1h a2UgaXQgbW9yZSByb2J1c3QgKGUuZy4gaWYgd2UgZmFpbGVkIHRvDQo+PiBnZXQgc3ltYm9sLCBq dXN0IHNob3dzIHRoZSByYXcgYWRkcmVzcykNCj4+DQo+PiBCVFcsIHRoZSByb2J1c3RuZXNzIGlz IGEga2V5IHBvaW50IGZvciBkZWJ1Z2dpbmcuIFBsZWFzZSBjb25zaWRlciB0aGUgY2FzZQ0KPj4g dGhhdCB5b3UgaGl0IGFuIGVycm9yIG9uIHRoZSBvYmplY3RzIGluIHRoZSBwZXJmX3RocmVhZCwg aXQgY291bGQgY2F1c2UNCj4+IGRvdWJsZSBmYXVsdChzZWd2IGFnYWluKSBvbiB0aGUgc2FtZSBv YmplY3QuIFRoYXQgaXMgd2hhdCBJIGFjdHVhbGx5IGRvbid0DQo+PiB3YW50Lg0KPg0KPkkgdW5k ZXJzdGFuZCB5b3VyIHBvaW50LiAgSWYgeW91IG9iamVjdCwgSSB3b24ndCBpbnNpc3QgaXQgc3Ry b25nbHkuDQo+DQo+SXQncyBwb3NzaWJsZSB0aGVyZSdzIGEgYnVnIGluIHBlcmZfdGhyZWFkIHN5 bWJvbCByZXNvbHV0aW9uLiAgQnV0DQo+aXQncyBwcmV0dHkgc3RyYWlnaHRmb3J3YXJkIGFuZCBz aW1wbGUgdXNlIGNhc2Ugc28gaWYgdGhlcmUncyBhIGJ1ZyBpbg0KPnRoYXQgY29kZSwgaXQgc2hv dWxkIGJlIGZvdW5kIGJlZm9yZWhhbmQgSU1ITy4NCg0KQWdyZWVkLCBteSBjb25jZXJuaW5nIGNh c2UgbWF5IHJhcmVseSBoYXBwZW5zLCBzbyBiZWZvcmVoYW5kIHdlJ2xsIGJlIGFibGUNCnRvIGhh bmRsZSBpdC4gKGFueXdheSwgd2UgYWxzbyBjYW4gdXNlIGdkYiBmb3IgdGhhdCBjYXNlKQ0KDQpJ J20gT0sgdGhpcyBvbmx5IGZvciB0aGUgc2lnc2VndiBiYWNrdHJhY2UuIEJ1dCBhdCBsZWFzdCBJ IGRvbid0IHdhbnQgdG8gdXNlDQp0aGUgcGVyZl90aHJlYWQgZm9yIHRoZSByZWZjbnQgZGVidWdn ZXIsIGJlY2F1c2UgZ2RiIGlzIHVzZWxlc3MgZm9yIHRoaXMga2luZA0Kb2YgZGVidWdnaW5nLiBJ J2QgbGlrZSB0byBtYWtlIGl0IHJvYnVzdC4gVGhhdCBpcyBteSBwb2ludC4NCg0KVGhhbmsgeW91 LA0KDQoNCg== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web