Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281911 > unrolled thread

[PATCH 1/4] EDAC: add DDR4 flag

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 1/4] EDAC: add DDR4 flag Hubert Chrzaniuk <hubert.chrzaniuk@intel.com> - 2015-12-02 16:40 +0100
    Re: [PATCH 1/4] EDAC: add DDR4 flag Borislav Petkov <bp@alien8.de> - 2015-12-02 20:30 +0100
      RE: [PATCH 1/4] EDAC: add DDR4 flag "Anaczkowski, Lukasz" <lukasz.anaczkowski@intel.com> - 2015-12-03 09:00 +0100
        Re: [PATCH 1/4] EDAC: add DDR4 flag Borislav Petkov <bp@alien8.de> - 2015-12-03 10:20 +0100

#1281911 — [PATCH 1/4] EDAC: add DDR4 flag

From: Jim Snow <jim.m.snow@intel.com>

Make EDAC aware of DDR4/RDDR4 mem types.

Signed-off-by: Jim Snow <jim.m.snow@intel.com>
Signed-off-by: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
Signed-off-by: Hubert Chrzaniuk <hubert.chrzaniuk@intel.com>

---
 include/linux/edac.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/include/linux/edac.h b/include/linux/edac.h
index 4fe67b8..da69648 100644
--- a/include/linux/edac.h
+++ b/include/linux/edac.h
@@ -237,8 +237,10 @@ enum mem_type {
 #define MEM_FLAG_FB_DDR2        BIT(MEM_FB_DDR2)
 #define MEM_FLAG_RDDR2          BIT(MEM_RDDR2)
 #define MEM_FLAG_XDR            BIT(MEM_XDR)
-#define MEM_FLAG_DDR3		 BIT(MEM_DDR3)
-#define MEM_FLAG_RDDR3		 BIT(MEM_RDDR3)
+#define MEM_FLAG_DDR3           BIT(MEM_DDR3)
+#define MEM_FLAG_RDDR3          BIT(MEM_RDDR3)
+#define MEM_FLAG_DDR4           BIT(MEM_DDR4)
+#define MEM_FLAG_RDDR4          BIT(MEM_RDDR4)
 
 /**
  * enum edac-type - Error Detection and Correction capabilities and mode
-- 
1.8.3.1

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1282291

On Wed, Dec 02, 2015 at 04:38:29PM +0100, Hubert Chrzaniuk wrote:
> From: Jim Snow <jim.m.snow@intel.com>
> 
> Make EDAC aware of DDR4/RDDR4 mem types.
> 
> Signed-off-by: Jim Snow <jim.m.snow@intel.com>
> Signed-off-by: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
> Signed-off-by: Hubert Chrzaniuk <hubert.chrzaniuk@intel.com>

How am I to understand this SoB chain?

Jim wrote it, Lukasz did something to it and Hubert sends it?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1282762

LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IEJvcmlzbGF2IFBldGtvdiBbbWFpbHRv
OmJwQGFsaWVuOC5kZV0gDQpTZW50OiBXZWRuZXNkYXksIERlY2VtYmVyIDIsIDIwMTUgODoyOCBQ
TQ0KVG86IENocnphbml1aywgSHViZXJ0IDxodWJlcnQuY2hyemFuaXVrQGludGVsLmNvbT4NCkNj
OiBBbmFjemtvd3NraSwgTHVrYXN6IDxsdWthc3ouYW5hY3prb3dza2lAaW50ZWwuY29tPjsgbWNo
ZWhhYkBvc2cuc2Ftc3VuZy5jb207IGRvdWd0aG9tcHNvbkB4bWlzc2lvbi5jb207IGxpbnV4LWVk
YWNAdmdlci5rZXJuZWwub3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOyBTbm93LCBK
aW0gTSA8amltLm0uc25vd0BpbnRlbC5jb20+DQpTdWJqZWN0OiBSZTogW1BBVENIIDEvNF0gRURB
QzogYWRkIEREUjQgZmxhZw0KDQo+IE9uIFdlZCwgRGVjIDAyLCAyMDE1IGF0IDA0OjM4OjI5UE0g
KzAxMDAsIEh1YmVydCBDaHJ6YW5pdWsgd3JvdGU6DQo+PiBTaWduZWQtb2ZmLWJ5OiBKaW0gU25v
dyA8amltLm0uc25vd0BpbnRlbC5jb20+DQo+PiBTaWduZWQtb2ZmLWJ5OiBMdWthc3ogQW5hY3pr
b3dza2kgPGx1a2Fzei5hbmFjemtvd3NraUBpbnRlbC5jb20+DQo+PiBTaWduZWQtb2ZmLWJ5OiBI
dWJlcnQgQ2hyemFuaXVrIDxodWJlcnQuY2hyemFuaXVrQGludGVsLmNvbT4NCj4NCj4gSG93IGFt
IEkgdG8gdW5kZXJzdGFuZCB0aGlzIFNvQiBjaGFpbj8NCj4NCj4gSmltIHdyb3RlIGl0LCBMdWth
c3ogZGlkIHNvbWV0aGluZyB0byBpdCBhbmQgSHViZXJ0IHNlbmRzIGl0Pw0KDQpXZWxsLCBhbHRo
b3VnaCBpdCBtYXkgc291bmQgc3RyYW5nZSwgeWVhaCB0aGlzIGlzIGV4YWN0bHkgdGhlIGNhc2Us
IHNpbmNlDQpFREFDIGZvciBLbmlnaHRzIExhbmRpbmcgaGFzIGJlZW4gZm9yIGEgd2hpbGUgaW4g
b3VyIHByaXZhdGUgYnJhbmNoLg0KDQpJcyB0aGlzIHNvcnQgb2YgYW4gaXNzdWUgb3IganVzdCBj
dXJpb3NpdHk/DQoNClRoYW5rcywNCkx1a2Fzeg0K
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1282834

On Thu, Dec 03, 2015 at 07:51:47AM +0000, Anaczkowski, Lukasz wrote:
> Well, although it may sound strange, yeah this is exactly the case, since
> EDAC for Knights Landing has been for a while in our private branch.
> 
> Is this sort of an issue or just curiosity?

Well, the fact that I'm asking, means it is not clear who did what. Please
document that like this:

        Signed-off-by: Random J Developer <random@developer.example.org>
        [lucky@maintainer.example.org: struct foo moved from foo.c to foo.h]
        Signed-off-by: Lucky K Maintainer <lucky@maintainer.example.org>

(example is from Documentation/SubmittingPatches where the whole authorship
 tracking is explained in detail.)

Alternatively, you can put it in free text in the commit message.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web