Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281580 > unrolled thread
| Started by | Sunil Goutham <sunil.kovvuri@gmail.com> |
|---|---|
| First post | 2015-12-02 11:10 +0100 |
| Last post | 2015-12-02 21:50 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2 0/5] net: thunderx: Miscellaneous fixes Sunil Goutham <sunil.kovvuri@gmail.com> - 2015-12-02 11:10 +0100
[PATCH v2 3/5] net: thunderx: Set CQ timer threshold properly Sunil Goutham <sunil.kovvuri@gmail.com> - 2015-12-02 11:10 +0100
Re: [PATCH v2 0/5] net: thunderx: Miscellaneous fixes David Miller <davem@davemloft.net> - 2015-12-02 21:50 +0100
| From | Sunil Goutham <sunil.kovvuri@gmail.com> |
|---|---|
| Date | 2015-12-02 11:10 +0100 |
| Subject | [PATCH v2 0/5] net: thunderx: Miscellaneous fixes |
| Message-ID | <qBcwh-5Mp-3@gated-at.bofh.it> |
From: Sunil Goutham <sgoutham@cavium.com> This patch series contains fixes for various issues observed with BGX and NIC drivers. Changes from v1: - Fixed comment syle in the first patch of the series - Removed 'Increase transmit queue length' patch from the series, will recheck if it's a driver or system issue and resubmit. Sunil Goutham (3): net: thunderx: Set CQ timer threshold properly net: thunderx: Switchon carrier only upon interface link up net: thunderx: Enable BGX LMAC's RX/TX only after VF is up Thanneeru Srinivasulu (2): net: thunderx: Force to load octeon-mdio before bgx driver. net: thunderx: Wait for delayed work to finish before destroying it drivers/net/ethernet/cavium/thunder/nic.h | 5 +-- drivers/net/ethernet/cavium/thunder/nic_main.c | 23 ++++++++++++++-- .../net/ethernet/cavium/thunder/nicvf_ethtool.c | 16 ++++++++++- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 4 +-- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 2 +- drivers/net/ethernet/cavium/thunder/nicvf_queues.h | 2 +- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 28 +++++++++++++++++--- drivers/net/ethernet/cavium/thunder/thunder_bgx.h | 2 + 8 files changed, 66 insertions(+), 16 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Sunil Goutham <sunil.kovvuri@gmail.com> |
|---|---|
| Date | 2015-12-02 11:10 +0100 |
| Subject | [PATCH v2 3/5] net: thunderx: Set CQ timer threshold properly |
| Message-ID | <qBcwj-5Mp-27@gated-at.bofh.it> |
| In reply to | #1281580 |
From: Sunil Goutham <sgoutham@cavium.com> Properly set CQ timer threshold and also set it to 2us. With previous incorrect settings it was set to 0.5us which is too less. Signed-off-by: Sunil Goutham <sgoutham@cavium.com> --- drivers/net/ethernet/cavium/thunder/nic.h | 5 ++--- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 2 +- drivers/net/ethernet/cavium/thunder/nicvf_queues.h | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cavium/thunder/nic.h b/drivers/net/ethernet/cavium/thunder/nic.h index d3950b2..39ca674 100644 --- a/drivers/net/ethernet/cavium/thunder/nic.h +++ b/drivers/net/ethernet/cavium/thunder/nic.h @@ -120,10 +120,9 @@ * Calculated for SCLK of 700Mhz * value written should be a 1/16th of what is expected * - * 1 tick per 0.05usec = value of 2.2 - * This 10% would be covered in CQ timer thresh value + * 1 tick per 0.025usec */ -#define NICPF_CLK_PER_INT_TICK 2 +#define NICPF_CLK_PER_INT_TICK 1 /* Time to wait before we decide that a SQ is stuck. * diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c index e404ea8..206b6a7 100644 --- a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c +++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c @@ -592,7 +592,7 @@ void nicvf_cmp_queue_config(struct nicvf *nic, struct queue_set *qs, /* Set threshold value for interrupt generation */ nicvf_queue_reg_write(nic, NIC_QSET_CQ_0_7_THRESH, qidx, cq->thresh); nicvf_queue_reg_write(nic, NIC_QSET_CQ_0_7_CFG2, - qidx, nic->cq_coalesce_usecs); + qidx, CMP_QUEUE_TIMER_THRESH); } /* Configures transmit queue */ diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.h b/drivers/net/ethernet/cavium/thunder/nicvf_queues.h index fb4957d..033e830 100644 --- a/drivers/net/ethernet/cavium/thunder/nicvf_queues.h +++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.h @@ -76,7 +76,7 @@ #define CMP_QSIZE CMP_QUEUE_SIZE2 #define CMP_QUEUE_LEN (1ULL << (CMP_QSIZE + 10)) #define CMP_QUEUE_CQE_THRESH 0 -#define CMP_QUEUE_TIMER_THRESH 220 /* 10usec */ +#define CMP_QUEUE_TIMER_THRESH 80 /* ~2usec */ #define RBDR_SIZE RBDR_SIZE0 #define RCV_BUF_COUNT (1ULL << (RBDR_SIZE + 13)) -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2015-12-02 21:50 +0100 |
| Message-ID | <qBmvE-3Jz-31@gated-at.bofh.it> |
| In reply to | #1281580 |
I'm not even looking at this patch series while it still causes unresolved bugs. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web