Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281544 > unrolled thread

Re: [PATCH 11/40] staging: lustre: DLC Feature dynamic net config

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 11/40] staging: lustre: DLC Feature dynamic net config Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-02 10:30 +0100

#1281544 — Re: [PATCH 11/40] staging: lustre: DLC Feature dynamic net config

On Fri, Nov 20, 2015 at 06:35:47PM -0500, James Simmons wrote:
> +
> +	return 0;
>  
>   failed4:
> -	lnet_ping_target_fini();
> - failed3:
>  	the_lnet.ln_refcount = 0;
> +	lnet_ping_md_unlink(pinfo, &md_handle);
> +	lnet_ping_info_free(pinfo);
> + failed3:
>  	lnet_acceptor_stop();
> +	rc = LNetEQFree(the_lnet.ln_ping_target_eq);
> +	LASSERT(rc == 0);
        ^^^^^^^^^^^^^^^^

>   failed2:
>  	lnet_destroy_routes();
>  	lnet_shutdown_lndnis();
> @@ -1263,8 +1609,12 @@ LNetNIInit(lnet_pid_t requested_pid)
>  	lnet_unprepare();
>   failed0:
>  	LASSERT(rc < 0);
        ^^^^^^^^^^^^^^^

These asserts contradict each other.


But mostly please remove all the GW-BASIC style numbered labeled names
from this patch.  You wouldn't name your variables "int var1, var2,
var3" so for label names you should give them meaningful names as well.
Don't name them after the goto location, name them after the label
location to say the first thing that the label does.

err_fini:
err_acceptor_stop:
err_destroy_routes:
err_empty_list:

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web