Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1281503 > unrolled thread

[PATCH v2] PCI: imx6:don't sleep in atomic context

Started bySanjeev Sharma <sanjeev_sharma@mentor.com>
First post2015-12-02 08:50 +0100
Last post2015-12-02 08:50 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v2] PCI: imx6:don't sleep in atomic context Sanjeev Sharma <sanjeev_sharma@mentor.com> - 2015-12-02 08:50 +0100

#1281503 — [PATCH v2] PCI: imx6:don't sleep in atomic context

FromSanjeev Sharma <sanjeev_sharma@mentor.com>
Date2015-12-02 08:50 +0100
Subject[PATCH v2] PCI: imx6:don't sleep in atomic context
Message-ID<qBakO-4bR-1@gated-at.bofh.it>
From: David Mueller <dave.mueller@gmx.ch>

If additional PCIe switch get connected between the
host and the NIC,the kernel crashes with "BUG:
scheduling while atomic". To handle this we need to
call mdelay() instead of usleep_range().

This is currently called from atomic context through
pci_config_{read,write).

For more detail please refer bugzilla.kernel.org, Bug
100031

Signed-off-by: David Mueller <dave.mueller@gmx.ch>
Signed-off-by: Sanjeev Sharma <sanjeev_sharma@mentor.com>

Changes in v2:
	-order of signoff has been change
	-Author of patch has been change
	-A mdelay(1000) is different timescale than
a usleep(1000).change it to correct scale i.e mdelay(1)
	-updated comment
---
 drivers/pci/host/pci-imx6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
index 233a196..c03527f 100644
--- a/drivers/pci/host/pci-imx6.c
+++ b/drivers/pci/host/pci-imx6.c
@@ -499,7 +499,7 @@ static int imx6_pcie_link_up(struct pcie_port *pp)
 		 * Wait a little bit, then re-check if the link finished
 		 * the training.
 		 */
-		usleep_range(1000, 2000);
+		mdelay(1);
 	}
 	/*
 	 * From L0, initiate MAC entry to gen2 if EP/RC supports gen2.
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web