Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283672 > unrolled thread

[PATCH] Staging: cdrom: fix space required after that ','

Started by"Shah, Yash (Y.)" <yshah1@visteon.com>
First post2015-12-04 10:30 +0100
Last post2015-12-04 17:50 +0100
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] Staging: cdrom: fix space required after that ',' "Shah, Yash (Y.)" <yshah1@visteon.com> - 2015-12-04 10:30 +0100
    Re: [PATCH] Staging: cdrom: fix space required after that ',' kbuild test robot <lkp@intel.com> - 2015-12-04 10:40 +0100
    Re: [PATCH] Staging: cdrom: fix space required after that ',' "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-04 11:40 +0100
      RE: [PATCH] Staging: cdrom: fix space required after that ',' "Shah, Yash (Y.)" <yshah1@visteon.com> - 2015-12-04 11:50 +0100
        Re: [PATCH] Staging: cdrom: fix space required after that ',' Jens Axboe <axboe@kernel.dk> - 2015-12-04 17:50 +0100
    Re: [PATCH] Staging: cdrom: fix space required after that ',' Jens Axboe <axboe@kernel.dk> - 2015-12-04 17:50 +0100

#1283672 — [PATCH] Staging: cdrom: fix space required after that ','

From"Shah, Yash (Y.)" <yshah1@visteon.com>
Date2015-12-04 10:30 +0100
Subject[PATCH] Staging: cdrom: fix space required after that ','
Message-ID<qBUQI-Pe-53@gated-at.bofh.it>
From: Yash Shah<yshah1@visteon.com>

fix space required after that ',' as detected by checkpatch.pl

Signed-off-by: Yash Shah <yshah1@visteon.com>
---
 drivers/cdrom/cdrom.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index c206ccd..2d759b6 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -536,7 +536,7 @@ static int cdrom_mrw_exit(struct cdrom_device_info *cdi)
 	int ret;
 
 	ret = cdrom_get_disc_info(cdi, &di);
-	if (ret < 0 || ret < (int)offsetof(typeof(di),disc_type))
+	if (ret < 0 || ret < (int)offsetof(typeof(di), disc_type))
 		return 1;
 
 	ret = 0;
@@ -788,7 +788,7 @@ static int cdrom_mrw_open_write(struct cdrom_device_info *cdi)
 	}
 
 	ret = cdrom_get_disc_info(cdi, &di);
-	if (ret < 0 || ret < offsetof(typeof(di),disc_type))
+	if (ret < 0 || ret < offsetof(typeof(di), disc_type))
 		return 1;
 
 	if (!di.erasable)
@@ -1050,7 +1050,7 @@ int open_for_data(struct cdrom_device_info *cdi)
 			if (CDROM_CAN(CDC_CLOSE_TRAY) &&
 			    cdi->options & CDO_AUTO_CLOSE) {
 				cd_dbg(CD_OPEN, "trying to close the tray\n");
-				ret=cdo->tray_move(cdi,0);
+				ret=cdo->tray_move(cdi, 0);
 				if (ret) {
 					cd_dbg(CD_OPEN, "bummer. tried to close the tray but failed.\n");
 					/* Ignore the error from the low
@@ -1215,7 +1215,7 @@ static int check_for_audio_disc(struct cdrom_device_info * cdi,
 			if (CDROM_CAN(CDC_CLOSE_TRAY) &&
 			    cdi->options & CDO_AUTO_CLOSE) {
 				cd_dbg(CD_OPEN, "trying to close the tray\n");
-				ret=cdo->tray_move(cdi,0);
+				ret=cdo->tray_move(cdi, 0);
 				if (ret) {
 					cd_dbg(CD_OPEN, "bummer. tried to close tray but failed.\n");
 					/* Ignore the error from the low
@@ -1591,8 +1591,8 @@ void init_cdrom_command(struct packet_command *cgc, void *buf, int len,
 
 /* DVD handling */
 
-#define copy_key(dest,src)	memcpy((dest), (src), sizeof(dvd_key))
-#define copy_chal(dest,src)	memcpy((dest), (src), sizeof(dvd_challenge))
+#define copy_key(dest, src)	memcpy((dest), (src), sizeof(dvd_key))
+#define copy_chal(dest, :src)	memcpy((dest), (src), sizeof(dvd_challenge))
 
 static void setup_report_key(struct packet_command *cgc, unsigned agid, unsigned type)
 {
-- 
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1283677

Fromkbuild test robot <lkp@intel.com>
Date2015-12-04 10:40 +0100
Message-ID<qBV0l-Sz-5@gated-at.bofh.it>
In reply to#1283672

[Multipart message — attachments visible in raw view] — view raw

Hi Yash,

[auto build test ERROR on v4.4-rc3]
[also build test ERROR on next-20151203]

url:    https://github.com/0day-ci/linux/commits/Shah-Yash-Y/Staging-cdrom-fix-space-required-after-that/20151204-172315
config: x86_64-randconfig-x015-12041303 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/cdrom/cdrom.c:1595:25: sparse: ":" may not appear in macro parameter list
   drivers/cdrom/cdrom.c:1684:17: sparse: undefined identifier 'copy_chal'
   drivers/cdrom/cdrom.c:1723:17: sparse: undefined identifier 'copy_chal'
>> drivers/cdrom/cdrom.c:1595:25: error: ":" may not appear in macro parameter list
    #define copy_chal(dest, :src) memcpy((dest), (src), sizeof(dvd_challenge))
                            ^
   drivers/cdrom/cdrom.c: In function 'dvd_do_auth':
>> drivers/cdrom/cdrom.c:1684:3: error: implicit declaration of function 'copy_chal' [-Werror=implicit-function-declaration]
      copy_chal(ai->lsc.chal, &buf[4]);
      ^
   cc1: some warnings being treated as errors

vim +1595 drivers/cdrom/cdrom.c

  1589		cgc->timeout = CDROM_DEF_TIMEOUT;
  1590	}
  1591	
  1592	/* DVD handling */
  1593	
  1594	#define copy_key(dest, src)	memcpy((dest), (src), sizeof(dvd_key))
> 1595	#define copy_chal(dest, :src)	memcpy((dest), (src), sizeof(dvd_challenge))
  1596	
  1597	static void setup_report_key(struct packet_command *cgc, unsigned agid, unsigned type)
  1598	{
  1599		cgc->cmd[0] = GPCMD_REPORT_KEY;
  1600		cgc->cmd[10] = type | (agid << 6);
  1601		switch (type) {
  1602			case 0: case 8: case 5: {
  1603				cgc->buflen = 8;
  1604				break;
  1605			}
  1606			case 1: {
  1607				cgc->buflen = 16;
  1608				break;
  1609			}
  1610			case 2: case 4: {
  1611				cgc->buflen = 12;
  1612				break;
  1613			}
  1614		}
  1615		cgc->cmd[9] = cgc->buflen;
  1616		cgc->data_direction = CGC_DATA_READ;
  1617	}
  1618	
  1619	static void setup_send_key(struct packet_command *cgc, unsigned agid, unsigned type)
  1620	{
  1621		cgc->cmd[0] = GPCMD_SEND_KEY;
  1622		cgc->cmd[10] = type | (agid << 6);
  1623		switch (type) {
  1624			case 1: {
  1625				cgc->buflen = 16;
  1626				break;
  1627			}
  1628			case 3: {
  1629				cgc->buflen = 12;
  1630				break;
  1631			}
  1632			case 6: {
  1633				cgc->buflen = 8;
  1634				break;
  1635			}
  1636		}
  1637		cgc->cmd[9] = cgc->buflen;
  1638		cgc->data_direction = CGC_DATA_WRITE;
  1639	}
  1640	
  1641	static int dvd_do_auth(struct cdrom_device_info *cdi, dvd_authinfo *ai)
  1642	{
  1643		int ret;
  1644		u_char buf[20];
  1645		struct packet_command cgc;
  1646		struct cdrom_device_ops *cdo = cdi->ops;
  1647		rpc_state_t rpc_state;
  1648	
  1649		memset(buf, 0, sizeof(buf));
  1650		init_cdrom_command(&cgc, buf, 0, CGC_DATA_READ);
  1651	
  1652		switch (ai->type) {
  1653		/* LU data send */
  1654		case DVD_LU_SEND_AGID:
  1655			cd_dbg(CD_DVD, "entering DVD_LU_SEND_AGID\n");
  1656			cgc.quiet = 1;
  1657			setup_report_key(&cgc, ai->lsa.agid, 0);
  1658	
  1659			if ((ret = cdo->generic_packet(cdi, &cgc)))
  1660				return ret;
  1661	
  1662			ai->lsa.agid = buf[7] >> 6;
  1663			/* Returning data, let host change state */
  1664			break;
  1665	
  1666		case DVD_LU_SEND_KEY1:
  1667			cd_dbg(CD_DVD, "entering DVD_LU_SEND_KEY1\n");
  1668			setup_report_key(&cgc, ai->lsk.agid, 2);
  1669	
  1670			if ((ret = cdo->generic_packet(cdi, &cgc)))
  1671				return ret;
  1672	
  1673			copy_key(ai->lsk.key, &buf[4]);
  1674			/* Returning data, let host change state */
  1675			break;
  1676	
  1677		case DVD_LU_SEND_CHALLENGE:
  1678			cd_dbg(CD_DVD, "entering DVD_LU_SEND_CHALLENGE\n");
  1679			setup_report_key(&cgc, ai->lsc.agid, 1);
  1680	
  1681			if ((ret = cdo->generic_packet(cdi, &cgc)))
  1682				return ret;
  1683	
> 1684			copy_chal(ai->lsc.chal, &buf[4]);
  1685			/* Returning data, let host change state */
  1686			break;
  1687	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [next] | [standalone]

#1283695

From"Geyslan G. Bem" <geyslan@gmail.com>
Date2015-12-04 11:40 +0100
Message-ID<qBVWq-1sC-23@gated-at.bofh.it>
In reply to#1283672
Hi Yash,

2015-12-04 6:21 GMT-03:00 Shah, Yash (Y.) <yshah1@visteon.com>:
> From: Yash Shah<yshah1@visteon.com>
>
> fix space required after that ',' as detected by checkpatch.pl
>
> Signed-off-by: Yash Shah <yshah1@visteon.com>
> ---
>  drivers/cdrom/cdrom.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index c206ccd..2d759b6 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -536,7 +536,7 @@ static int cdrom_mrw_exit(struct cdrom_device_info *cdi)
>         int ret;
>
>         ret = cdrom_get_disc_info(cdi, &di);
> -       if (ret < 0 || ret < (int)offsetof(typeof(di),disc_type))
> +       if (ret < 0 || ret < (int)offsetof(typeof(di), disc_type))
>                 return 1;
>
>         ret = 0;
> @@ -788,7 +788,7 @@ static int cdrom_mrw_open_write(struct cdrom_device_info *cdi)
>         }
>
>         ret = cdrom_get_disc_info(cdi, &di);
> -       if (ret < 0 || ret < offsetof(typeof(di),disc_type))
> +       if (ret < 0 || ret < offsetof(typeof(di), disc_type))
>                 return 1;
>
>         if (!di.erasable)
> @@ -1050,7 +1050,7 @@ int open_for_data(struct cdrom_device_info *cdi)
>                         if (CDROM_CAN(CDC_CLOSE_TRAY) &&
>                             cdi->options & CDO_AUTO_CLOSE) {
>                                 cd_dbg(CD_OPEN, "trying to close the tray\n");
> -                               ret=cdo->tray_move(cdi,0);
> +                               ret=cdo->tray_move(cdi, 0);

What do you think to add spaces between equal assignment too?

>                                 if (ret) {
>                                         cd_dbg(CD_OPEN, "bummer. tried to close the tray but failed.\n");
>                                         /* Ignore the error from the low
> @@ -1215,7 +1215,7 @@ static int check_for_audio_disc(struct cdrom_device_info * cdi,
>                         if (CDROM_CAN(CDC_CLOSE_TRAY) &&
>                             cdi->options & CDO_AUTO_CLOSE) {
>                                 cd_dbg(CD_OPEN, "trying to close the tray\n");
> -                               ret=cdo->tray_move(cdi,0);
> +                               ret=cdo->tray_move(cdi, 0);
>                                 if (ret) {
>                                         cd_dbg(CD_OPEN, "bummer. tried to close tray but failed.\n");
>                                         /* Ignore the error from the low
> @@ -1591,8 +1591,8 @@ void init_cdrom_command(struct packet_command *cgc, void *buf, int len,
>
>  /* DVD handling */
>
> -#define copy_key(dest,src)     memcpy((dest), (src), sizeof(dvd_key))
> -#define copy_chal(dest,src)    memcpy((dest), (src), sizeof(dvd_challenge))
> +#define copy_key(dest, src)    memcpy((dest), (src), sizeof(dvd_key))
> +#define copy_chal(dest, :src)  memcpy((dest), (src), sizeof(dvd_challenge))
>
>  static void setup_report_key(struct packet_command *cgc, unsigned agid, unsigned type)
>  {
> --
> 1.9.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1283702

From"Shah, Yash (Y.)" <yshah1@visteon.com>
Date2015-12-04 11:50 +0100
Message-ID<qBW66-1w3-17@gated-at.bofh.it>
In reply to#1283695
SGksDQoNCk9rIEkgd2lsbCBzZW5kIGFsbCB0aGUgc3BhY2VzIHJlbGF0ZWQgZXJyb3IgaW4gb25l
IHNpbmdsZSBwYXRjaC4NCg0KVGhhbmtzLA0KWWFzaCBTaGFoDQoNCi0tLS0tT3JpZ2luYWwgTWVz
c2FnZS0tLS0tDQpGcm9tOiBHZXlzbGFuIEcuIEJlbSBbbWFpbHRvOmdleXNsYW5AZ21haWwuY29t
XSANClNlbnQ6IEZyaWRheSwgRGVjZW1iZXIgMDQsIDIwMTUgNDowOCBQTQ0KVG86IFNoYWgsIFlh
c2ggKFkuKQ0KQ2M6IGF4Ym9lQGtlcm5lbC5kazsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9y
ZzsgQmFidSwgVmlzd2FuYXRoYW4gKFYuKQ0KU3ViamVjdDogUmU6IFtQQVRDSF0gU3RhZ2luZzog
Y2Ryb206IGZpeCBzcGFjZSByZXF1aXJlZCBhZnRlciB0aGF0ICcsJw0KDQpIaSBZYXNoLA0KDQoy
MDE1LTEyLTA0IDY6MjEgR01ULTAzOjAwIFNoYWgsIFlhc2ggKFkuKSA8eXNoYWgxQHZpc3Rlb24u
Y29tPjoNCj4gRnJvbTogWWFzaCBTaGFoPHlzaGFoMUB2aXN0ZW9uLmNvbT4NCj4NCj4gZml4IHNw
YWNlIHJlcXVpcmVkIGFmdGVyIHRoYXQgJywnIGFzIGRldGVjdGVkIGJ5IGNoZWNrcGF0Y2gucGwN
Cj4NCj4gU2lnbmVkLW9mZi1ieTogWWFzaCBTaGFoIDx5c2hhaDFAdmlzdGVvbi5jb20+DQo+IC0t
LQ0KPiAgZHJpdmVycy9jZHJvbS9jZHJvbS5jIHwgMTIgKysrKysrLS0tLS0tDQo+ICAxIGZpbGUg
Y2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQ0KPg0KPiBkaWZmIC0tZ2l0
IGEvZHJpdmVycy9jZHJvbS9jZHJvbS5jIGIvZHJpdmVycy9jZHJvbS9jZHJvbS5jIGluZGV4IA0K
PiBjMjA2Y2NkLi4yZDc1OWI2IDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2Nkcm9tL2Nkcm9tLmMN
Cj4gKysrIGIvZHJpdmVycy9jZHJvbS9jZHJvbS5jDQo+IEBAIC01MzYsNyArNTM2LDcgQEAgc3Rh
dGljIGludCBjZHJvbV9tcndfZXhpdChzdHJ1Y3QgY2Ryb21fZGV2aWNlX2luZm8gKmNkaSkNCj4g
ICAgICAgICBpbnQgcmV0Ow0KPg0KPiAgICAgICAgIHJldCA9IGNkcm9tX2dldF9kaXNjX2luZm8o
Y2RpLCAmZGkpOw0KPiAtICAgICAgIGlmIChyZXQgPCAwIHx8IHJldCA8IChpbnQpb2Zmc2V0b2Yo
dHlwZW9mKGRpKSxkaXNjX3R5cGUpKQ0KPiArICAgICAgIGlmIChyZXQgPCAwIHx8IHJldCA8IChp
bnQpb2Zmc2V0b2YodHlwZW9mKGRpKSwgZGlzY190eXBlKSkNCj4gICAgICAgICAgICAgICAgIHJl
dHVybiAxOw0KPg0KPiAgICAgICAgIHJldCA9IDA7DQo+IEBAIC03ODgsNyArNzg4LDcgQEAgc3Rh
dGljIGludCBjZHJvbV9tcndfb3Blbl93cml0ZShzdHJ1Y3QgY2Ryb21fZGV2aWNlX2luZm8gKmNk
aSkNCj4gICAgICAgICB9DQo+DQo+ICAgICAgICAgcmV0ID0gY2Ryb21fZ2V0X2Rpc2NfaW5mbyhj
ZGksICZkaSk7DQo+IC0gICAgICAgaWYgKHJldCA8IDAgfHwgcmV0IDwgb2Zmc2V0b2YodHlwZW9m
KGRpKSxkaXNjX3R5cGUpKQ0KPiArICAgICAgIGlmIChyZXQgPCAwIHx8IHJldCA8IG9mZnNldG9m
KHR5cGVvZihkaSksIGRpc2NfdHlwZSkpDQo+ICAgICAgICAgICAgICAgICByZXR1cm4gMTsNCj4N
Cj4gICAgICAgICBpZiAoIWRpLmVyYXNhYmxlKQ0KPiBAQCAtMTA1MCw3ICsxMDUwLDcgQEAgaW50
IG9wZW5fZm9yX2RhdGEoc3RydWN0IGNkcm9tX2RldmljZV9pbmZvICpjZGkpDQo+ICAgICAgICAg
ICAgICAgICAgICAgICAgIGlmIChDRFJPTV9DQU4oQ0RDX0NMT1NFX1RSQVkpICYmDQo+ICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBjZGktPm9wdGlvbnMgJiBDRE9fQVVUT19DTE9TRSkgew0K
PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNkX2RiZyhDRF9PUEVOLCAidHJ5aW5n
IHRvIGNsb3NlIHRoZSB0cmF5XG4iKTsNCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICByZXQ9Y2RvLT50cmF5X21vdmUoY2RpLDApOw0KPiArICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHJldD1jZG8tPnRyYXlfbW92ZShjZGksIDApOw0KDQpXaGF0IGRvIHlvdSB0aGluayB0
byBhZGQgc3BhY2VzIGJldHdlZW4gZXF1YWwgYXNzaWdubWVudCB0b28/DQoNCj4gICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBpZiAocmV0KSB7DQo+ICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBjZF9kYmcoQ0RfT1BFTiwgImJ1bW1lci4gdHJpZWQgdG8gY2xv
c2UgdGhlIHRyYXkgYnV0IGZhaWxlZC5cbiIpOw0KPiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgLyogSWdub3JlIHRoZSBlcnJvciBmcm9tIHRoZSANCj4gbG93IEBAIC0x
MjE1LDcgKzEyMTUsNyBAQCBzdGF0aWMgaW50IGNoZWNrX2Zvcl9hdWRpb19kaXNjKHN0cnVjdCBj
ZHJvbV9kZXZpY2VfaW5mbyAqIGNkaSwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgaWYgKENE
Uk9NX0NBTihDRENfQ0xPU0VfVFJBWSkgJiYNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg
IGNkaS0+b3B0aW9ucyAmIENET19BVVRPX0NMT1NFKSB7DQo+ICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgY2RfZGJnKENEX09QRU4sICJ0cnlpbmcgdG8gY2xvc2UgdGhlIHRyYXlcbiIp
Ow0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldD1jZG8tPnRyYXlfbW92ZShj
ZGksMCk7DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0PWNkby0+dHJheV9t
b3ZlKGNkaSwgMCk7DQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHJldCkg
ew0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2RfZGJnKENEX09Q
RU4sICJidW1tZXIuIHRyaWVkIHRvIGNsb3NlIHRyYXkgYnV0IGZhaWxlZC5cbiIpOw0KPiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLyogSWdub3JlIHRoZSBlcnJvciBm
cm9tIHRoZSANCj4gbG93IEBAIC0xNTkxLDggKzE1OTEsOCBAQCB2b2lkIGluaXRfY2Ryb21fY29t
bWFuZChzdHJ1Y3QgDQo+IHBhY2tldF9jb21tYW5kICpjZ2MsIHZvaWQgKmJ1ZiwgaW50IGxlbiwN
Cj4NCj4gIC8qIERWRCBoYW5kbGluZyAqLw0KPg0KPiAtI2RlZmluZSBjb3B5X2tleShkZXN0LHNy
YykgICAgIG1lbWNweSgoZGVzdCksIChzcmMpLCBzaXplb2YoZHZkX2tleSkpDQo+IC0jZGVmaW5l
IGNvcHlfY2hhbChkZXN0LHNyYykgICAgbWVtY3B5KChkZXN0KSwgKHNyYyksIHNpemVvZihkdmRf
Y2hhbGxlbmdlKSkNCj4gKyNkZWZpbmUgY29weV9rZXkoZGVzdCwgc3JjKSAgICBtZW1jcHkoKGRl
c3QpLCAoc3JjKSwgc2l6ZW9mKGR2ZF9rZXkpKQ0KPiArI2RlZmluZSBjb3B5X2NoYWwoZGVzdCwg
OnNyYykgIG1lbWNweSgoZGVzdCksIChzcmMpLCANCj4gK3NpemVvZihkdmRfY2hhbGxlbmdlKSkN
Cj4NCj4gIHN0YXRpYyB2b2lkIHNldHVwX3JlcG9ydF9rZXkoc3RydWN0IHBhY2tldF9jb21tYW5k
ICpjZ2MsIHVuc2lnbmVkIA0KPiBhZ2lkLCB1bnNpZ25lZCB0eXBlKSAgew0KPiAtLQ0KPiAxLjku
MQ0KPiAtLQ0KPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAi
dW5zdWJzY3JpYmUgDQo+IGxpbnV4LWtlcm5lbCIgaW4gdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRv
IG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcgDQo+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0
dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbA0KPiBQbGVhc2UgcmVhZCB0
aGUgRkFRIGF0ICBodHRwOi8vd3d3LnR1eC5vcmcvbGttbC8NCg0KDQoNCi0tDQpSZWdhcmRzLA0K
DQpHZXlzbGFuIEcuIEJlbQ0KaGFja2luZ2JpdHMuY29tDQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1284007

FromJens Axboe <axboe@kernel.dk>
Date2015-12-04 17:50 +0100
Message-ID<qC1It-5b5-9@gated-at.bofh.it>
In reply to#1283702
On 12/04/2015 03:49 AM, Shah, Yash (Y.) wrote:
> Hi,
>
> Ok I will send all the spaces related error in one single patch.

No top posting, please.

And don't send anymore of these patches, unless you automate it with 
coccinelle. As this previous attempt elegantly demonstrated, the risk of 
introducing errors is too high, and reviewing patches like this is very 
error prone.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1284014

FromJens Axboe <axboe@kernel.dk>
Date2015-12-04 17:50 +0100
Message-ID<qC1Iu-5b5-35@gated-at.bofh.it>
In reply to#1283672
On 12/04/2015 02:21 AM, Shah, Yash (Y.) wrote:
> From: Yash Shah<yshah1@visteon.com>
 >
> -#define copy_key(dest,src)	memcpy((dest), (src), sizeof(dvd_key))
> -#define copy_chal(dest,src)	memcpy((dest), (src), sizeof(dvd_challenge))
> +#define copy_key(dest, src)	memcpy((dest), (src), sizeof(dvd_key))
> +#define copy_chal(dest, :src)	memcpy((dest), (src), sizeof(dvd_challenge))

Sending patches that you haven't even compiled:

https://www.youtube.com/watch?v=y94KynIg-g8

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web