Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281353 > unrolled thread
| Started by | "Geyslan G. Bem" <geyslan@gmail.com> |
|---|---|
| First post | 2015-12-02 00:50 +0100 |
| Last post | 2015-12-10 01:50 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] kvm: remove unused variable 'vcpu_book3s' "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-02 00:50 +0100
Re: [PATCH] kvm: remove unused variable 'vcpu_book3s' Daniel Axtens <dja@axtens.net> - 2015-12-02 01:40 +0100
Re: [PATCH] kvm: remove unused variable 'vcpu_book3s' "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-02 02:20 +0100
Re: [PATCH] kvm: remove unused variable 'vcpu_book3s' Paul Mackerras <paulus@ozlabs.org> - 2015-12-10 01:50 +0100
| From | "Geyslan G. Bem" <geyslan@gmail.com> |
|---|---|
| Date | 2015-12-02 00:50 +0100 |
| Subject | [PATCH] kvm: remove unused variable 'vcpu_book3s' |
| Message-ID | <qB2Qi-7Sl-11@gated-at.bofh.it> |
The vcpu_book3s struct is assigned but never used. So remove it.
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---
arch/powerpc/kvm/book3s_64_mmu.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
index 774a253..9bf7031 100644
--- a/arch/powerpc/kvm/book3s_64_mmu.c
+++ b/arch/powerpc/kvm/book3s_64_mmu.c
@@ -377,15 +377,12 @@ no_seg_found:
static void kvmppc_mmu_book3s_64_slbmte(struct kvm_vcpu *vcpu, u64 rs, u64 rb)
{
- struct kvmppc_vcpu_book3s *vcpu_book3s;
u64 esid, esid_1t;
int slb_nr;
struct kvmppc_slb *slbe;
dprintk("KVM MMU: slbmte(0x%llx, 0x%llx)\n", rs, rb);
- vcpu_book3s = to_book3s(vcpu);
-
esid = GET_ESID(rb);
esid_1t = GET_ESID_1T(rb);
slb_nr = rb & 0xfff;
--
2.6.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Daniel Axtens <dja@axtens.net> |
|---|---|
| Date | 2015-12-02 01:40 +0100 |
| Message-ID | <qB3CG-8o5-17@gated-at.bofh.it> |
| In reply to | #1281353 |
[Multipart message — attachments visible in raw view] — view raw
"Geyslan G. Bem" <geyslan@gmail.com> writes:
> The vcpu_book3s struct is assigned but never used. So remove it.
Just out of interest, how did you find this? Compiler warning? Static
analysis? Manual inspection?
Thanks in advance!
Regards,
Daniel
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
> arch/powerpc/kvm/book3s_64_mmu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
> index 774a253..9bf7031 100644
> --- a/arch/powerpc/kvm/book3s_64_mmu.c
> +++ b/arch/powerpc/kvm/book3s_64_mmu.c
> @@ -377,15 +377,12 @@ no_seg_found:
>
> static void kvmppc_mmu_book3s_64_slbmte(struct kvm_vcpu *vcpu, u64 rs, u64 rb)
> {
> - struct kvmppc_vcpu_book3s *vcpu_book3s;
> u64 esid, esid_1t;
> int slb_nr;
> struct kvmppc_slb *slbe;
>
> dprintk("KVM MMU: slbmte(0x%llx, 0x%llx)\n", rs, rb);
>
> - vcpu_book3s = to_book3s(vcpu);
> -
> esid = GET_ESID(rb);
> esid_1t = GET_ESID_1T(rb);
> slb_nr = rb & 0xfff;
> --
> 2.6.2
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
[toc] | [prev] | [next] | [standalone]
| From | "Geyslan G. Bem" <geyslan@gmail.com> |
|---|---|
| Date | 2015-12-02 02:20 +0100 |
| Message-ID | <qB4fn-qG-5@gated-at.bofh.it> |
| In reply to | #1281375 |
2015-12-01 21:34 GMT-03:00 Daniel Axtens <dja@axtens.net>:
> "Geyslan G. Bem" <geyslan@gmail.com> writes:
>
>> The vcpu_book3s struct is assigned but never used. So remove it.
>
> Just out of interest, how did you find this? Compiler warning? Static
> analysis? Manual inspection?
Sorry, I should have done the patch self contained. I caught it
through static analysis (cppcheck).
>
> Thanks in advance!
You're welcome.
>
> Regards,
> Daniel
>
>>
>> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
>> ---
>> arch/powerpc/kvm/book3s_64_mmu.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
>> index 774a253..9bf7031 100644
>> --- a/arch/powerpc/kvm/book3s_64_mmu.c
>> +++ b/arch/powerpc/kvm/book3s_64_mmu.c
>> @@ -377,15 +377,12 @@ no_seg_found:
>>
>> static void kvmppc_mmu_book3s_64_slbmte(struct kvm_vcpu *vcpu, u64 rs, u64 rb)
>> {
>> - struct kvmppc_vcpu_book3s *vcpu_book3s;
>> u64 esid, esid_1t;
>> int slb_nr;
>> struct kvmppc_slb *slbe;
>>
>> dprintk("KVM MMU: slbmte(0x%llx, 0x%llx)\n", rs, rb);
>>
>> - vcpu_book3s = to_book3s(vcpu);
>> -
>> esid = GET_ESID(rb);
>> esid_1t = GET_ESID_1T(rb);
>> slb_nr = rb & 0xfff;
>> --
>> 2.6.2
>>
>> _______________________________________________
>> Linuxppc-dev mailing list
>> Linuxppc-dev@lists.ozlabs.org
>> https://lists.ozlabs.org/listinfo/linuxppc-dev
--
Regards,
Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Paul Mackerras <paulus@ozlabs.org> |
|---|---|
| Date | 2015-12-10 01:50 +0100 |
| Message-ID | <qDXAK-7eK-7@gated-at.bofh.it> |
| In reply to | #1281353 |
On Tue, Dec 01, 2015 at 08:42:10PM -0300, Geyslan G. Bem wrote: > The vcpu_book3s struct is assigned but never used. So remove it. > > Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> Thanks, applied to my kvm-ppc-next branch. Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web