Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1281410 > unrolled thread

Re: [PATCH 11/19] ARM: dts: imx: replace legacy *,wakeup property with wakeup-source

Started byShawn Guo <shawnguo@kernel.org>
First post2015-12-02 03:00 +0100
Last post2015-12-02 11:10 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 11/19] ARM: dts: imx: replace legacy *,wakeup property  with wakeup-source Shawn Guo <shawnguo@kernel.org> - 2015-12-02 03:00 +0100
    Re: [PATCH 11/19] ARM: dts: imx: replace legacy *,wakeup property  with wakeup-source Sudeep Holla <sudeep.holla@arm.com> - 2015-12-02 11:10 +0100

#1281410 — Re: [PATCH 11/19] ARM: dts: imx: replace legacy *,wakeup property with wakeup-source

FromShawn Guo <shawnguo@kernel.org>
Date2015-12-02 03:00 +0100
SubjectRe: [PATCH 11/19] ARM: dts: imx: replace legacy *,wakeup property with wakeup-source
Message-ID<qB4S6-Fg-3@gated-at.bofh.it>
On Thu, Nov 26, 2015 at 11:33:50AM +0000, Sudeep Holla wrote:
> 
> 
> On 23/11/15 05:37, Shawn Guo wrote:
> >On Wed, Oct 21, 2015 at 11:10:08AM +0100, Sudeep Holla wrote:
> >>Though the keyboard and other driver will continue to support the legacy
> >>"gpio-key,wakeup", "linux,wakeup" boolean property to enable the wakeup
> >>source, "wakeup-source" is the new standard binding.
> >>
> >>This patch replaces all the legacy wakeup properties with the unified
> >>"wakeup-source" property in order to avoid any futher copy-paste
> >>duplication.
> >>
> >>Cc: Shawn Guo <shawnguo@kernel.org>
> >>Cc: Sascha Hauer <kernel@pengutronix.de>
> >>Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> >
> ><snip>
> >
> >>diff --git a/arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi b/arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi
> >>index 321662f53e33..16fc69c69ab2 100644
> >>--- a/arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi
> >>+++ b/arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi
> >>@@ -156,7 +156,7 @@
> >>  	pinctrl-names = "default";
> >>  	pinctrl-0 = <&pinctrl_esdhc2>;
> >>  	cap-sdio-irq;
> >>-	enable-sdio-wakeup;
> >>+	wakeup-source;
> >
> >I do not see this be mentioned in commit log.  I do not see relevant
> >kernel changes in v4.4-rc1 to support that.  Am I missing anything?
> >
> 
> Sorry for that, you weren't copied on that patch[1], Ulf has queued it
> now [2]

My branch is based on v4.4-rc1 which doesn't have that patch.  That
said, I can not apply it for now.

Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1281578

FromSudeep Holla <sudeep.holla@arm.com>
Date2015-12-02 11:10 +0100
Message-ID<qBcwj-5Mp-17@gated-at.bofh.it>
In reply to#1281410

On 02/12/15 01:54, Shawn Guo wrote:
> On Thu, Nov 26, 2015 at 11:33:50AM +0000, Sudeep Holla wrote:
>>
>>
>> On 23/11/15 05:37, Shawn Guo wrote:
>>> On Wed, Oct 21, 2015 at 11:10:08AM +0100, Sudeep Holla wrote:
>>>> Though the keyboard and other driver will continue to support the legacy
>>>> "gpio-key,wakeup", "linux,wakeup" boolean property to enable the wakeup
>>>> source, "wakeup-source" is the new standard binding.
>>>>
>>>> This patch replaces all the legacy wakeup properties with the unified
>>>> "wakeup-source" property in order to avoid any futher copy-paste
>>>> duplication.
>>>>
>>>> Cc: Shawn Guo <shawnguo@kernel.org>
>>>> Cc: Sascha Hauer <kernel@pengutronix.de>
>>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>>>
>>> <snip>
>>>
>>>> diff --git a/arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi b/arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi
>>>> index 321662f53e33..16fc69c69ab2 100644
>>>> --- a/arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi
>>>> +++ b/arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi
>>>> @@ -156,7 +156,7 @@
>>>>   	pinctrl-names = "default";
>>>>   	pinctrl-0 = <&pinctrl_esdhc2>;
>>>>   	cap-sdio-irq;
>>>> -	enable-sdio-wakeup;
>>>> +	wakeup-source;
>>>
>>> I do not see this be mentioned in commit log.  I do not see relevant
>>> kernel changes in v4.4-rc1 to support that.  Am I missing anything?
>>>
>>
>> Sorry for that, you weren't copied on that patch[1], Ulf has queued it
>> now [2]
>
> My branch is based on v4.4-rc1 which doesn't have that patch.  That
> said, I can not apply it for now.
>

Ah OK, that's fine pick it up when appropriate. I just wanted to let you
know that dependent patch is already queued.

-- 
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web