Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281127 > unrolled thread
| Started by | Adrien Vergé <adrienverge@gmail.com> |
|---|---|
| First post | 2015-12-01 20:00 +0100 |
| Last post | 2015-12-02 10:00 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v5 0/2] Fixes for ELAN touchscreens Adrien Vergé <adrienverge@gmail.com> - 2015-12-01 20:00 +0100
[PATCH v5 2/2] USB: quirks: Apply ALWAYS_POLL to all ELAN devices Adrien Vergé <adrienverge@gmail.com> - 2015-12-01 20:00 +0100
Re: [PATCH v5 2/2] USB: quirks: Apply ALWAYS_POLL to all ELAN devices Jiri Kosina <jikos@kernel.org> - 2015-12-01 23:10 +0100
Re: [PATCH v5 2/2] USB: quirks: Apply ALWAYS_POLL to all ELAN devices Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-01 23:20 +0100
Re: [PATCH v5 2/2] USB: quirks: Apply ALWAYS_POLL to all ELAN devices Adrien Vergé <adrienverge@gmail.com> - 2015-12-02 10:00 +0100
| From | Adrien Vergé <adrienverge@gmail.com> |
|---|---|
| Date | 2015-12-01 20:00 +0100 |
| Subject | [PATCH v5 0/2] Fixes for ELAN touchscreens |
| Message-ID | <qAYjE-4To-7@gated-at.bofh.it> |
This is the fifth version of a patchset which originally aimed to fix a buggy touchscreen from ELAN Microelectronics. Changes since v4: - Cast HID_ANY_ID to an __u16 so to keep gcc happy on AVR32 arch. Changes since v3: - Use HID_ANY_ID to define a vendor-ID-global quirk, as suggested by Benjamin Tissoires. Changes since v2: - Apply ALWAYS_POLL quirk to all ELAN devices by default, as suggested by Jiri Kosina and Oliver Neukum. Adrien Vergé (2): USB: quirks: Fix another ELAN touchscreen USB: quirks: Apply ALWAYS_POLL to all ELAN devices drivers/hid/hid-ids.h | 5 ----- drivers/hid/usbhid/hid-quirks.c | 9 +++------ drivers/usb/core/quirks.c | 3 +++ 3 files changed, 6 insertions(+), 11 deletions(-) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Adrien Vergé <adrienverge@gmail.com> |
|---|---|
| Date | 2015-12-01 20:00 +0100 |
| Subject | [PATCH v5 2/2] USB: quirks: Apply ALWAYS_POLL to all ELAN devices |
| Message-ID | <qAYjF-4To-25@gated-at.bofh.it> |
| In reply to | #1281127 |
All ELAN hid devices seem to require the ALWAYS_POLL quirk. Let's use
this quirk for all devices from this vendor, rather than maintaining a
list of all its known product IDs.
Tested-by: Adrien Vergé <adrienverge@gmail.com>
Signed-off-by: Adrien Vergé <adrienverge@gmail.com>
---
drivers/hid/hid-ids.h | 5 -----
drivers/hid/usbhid/hid-quirks.c | 9 +++------
2 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index ac1feea..3c7e0c3 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -316,11 +316,6 @@
#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_A001 0xa001
#define USB_VENDOR_ID_ELAN 0x04f3
-#define USB_DEVICE_ID_ELAN_TOUCHSCREEN 0x0089
-#define USB_DEVICE_ID_ELAN_TOUCHSCREEN_009B 0x009b
-#define USB_DEVICE_ID_ELAN_TOUCHSCREEN_0103 0x0103
-#define USB_DEVICE_ID_ELAN_TOUCHSCREEN_010c 0x010c
-#define USB_DEVICE_ID_ELAN_TOUCHSCREEN_016F 0x016f
#define USB_VENDOR_ID_ELECOM 0x056e
#define USB_DEVICE_ID_ELECOM_BM084 0x0061
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 94bb137..78fc94a 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -72,11 +72,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_PIXART_USB_OPTICAL_MOUSE, HID_QUIRK_ALWAYS_POLL },
{ USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_DRAGONRISE, USB_DEVICE_ID_DRAGONRISE_WIIU, HID_QUIRK_MULTI_INPUT },
- { USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN, HID_QUIRK_ALWAYS_POLL },
- { USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN_009B, HID_QUIRK_ALWAYS_POLL },
- { USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN_0103, HID_QUIRK_ALWAYS_POLL },
- { USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN_010c, HID_QUIRK_ALWAYS_POLL },
- { USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN_016F, HID_QUIRK_ALWAYS_POLL },
+ { USB_VENDOR_ID_ELAN, HID_ANY_ID, HID_QUIRK_ALWAYS_POLL },
{ USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_FORMOSA, USB_DEVICE_ID_FORMOSA_IR_RECEIVER, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_FREESCALE, USB_DEVICE_ID_FREESCALE_MX28, HID_QUIRK_NOGET },
@@ -339,7 +335,8 @@ static const struct hid_blacklist *usbhid_exists_squirk(const u16 idVendor,
for (; hid_blacklist[n].idVendor; n++)
if (hid_blacklist[n].idVendor == idVendor &&
- hid_blacklist[n].idProduct == idProduct)
+ (hid_blacklist[n].idProduct == (__u16) HID_ANY_ID ||
+ hid_blacklist[n].idProduct == idProduct))
bl_entry = &hid_blacklist[n];
if (bl_entry != NULL)
--
2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2015-12-01 23:10 +0100 |
| Subject | Re: [PATCH v5 2/2] USB: quirks: Apply ALWAYS_POLL to all ELAN devices |
| Message-ID | <qB1hw-73C-1@gated-at.bofh.it> |
| In reply to | #1281128 |
On Tue, 1 Dec 2015, Adrien Vergé wrote: > All ELAN hid devices seem to require the ALWAYS_POLL quirk. Let's use > this quirk for all devices from this vendor, rather than maintaining a > list of all its known product IDs. > > Tested-by: Adrien Vergé <adrienverge@gmail.com> > Signed-off-by: Adrien Vergé <adrienverge@gmail.com> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Reviewed-by: Jiri Kosina <jkosina@suse.cz> Greg, I guess it makes sense to take both 1/2 and 2/2 together as a whole. Would you mind adding the tags above and taking it through usb git tree? Alternatively I can take it through my tree if you Ack the usb part. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-12-01 23:20 +0100 |
| Subject | Re: [PATCH v5 2/2] USB: quirks: Apply ALWAYS_POLL to all ELAN devices |
| Message-ID | <qB1rd-76P-25@gated-at.bofh.it> |
| In reply to | #1281240 |
On Tue, Dec 01, 2015 at 11:09:23PM +0100, Jiri Kosina wrote: > On Tue, 1 Dec 2015, Adrien Vergé wrote: > > > All ELAN hid devices seem to require the ALWAYS_POLL quirk. Let's use > > this quirk for all devices from this vendor, rather than maintaining a > > list of all its known product IDs. > > > > Tested-by: Adrien Vergé <adrienverge@gmail.com> > > Signed-off-by: Adrien Vergé <adrienverge@gmail.com> > > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > Reviewed-by: Jiri Kosina <jkosina@suse.cz> > > Greg, I guess it makes sense to take both 1/2 and 2/2 together as a whole. > Would you mind adding the tags above and taking it through usb git tree? > > Alternatively I can take it through my tree if you Ack the usb part. Sure, I'll take it as I've already applied the non-HID patch :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Adrien Vergé <adrienverge@gmail.com> |
|---|---|
| Date | 2015-12-02 10:00 +0100 |
| Subject | Re: [PATCH v5 2/2] USB: quirks: Apply ALWAYS_POLL to all ELAN devices |
| Message-ID | <qBbqx-4Qy-3@gated-at.bofh.it> |
| In reply to | #1281260 |
Thank you all for your help on this. Adrien -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web