Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1279582 > unrolled thread

Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-30 07:30 +0100
    Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap Mathias Nyman <mathias.nyman@intel.com> - 2015-11-30 10:10 +0100

#1279582 — Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

pinging in case this patch is lost.


On 6 November 2015 at 17:46, Saurabh Sengar <saurabh.truth@gmail.com> wrote:
> added iounmap inorder to free memory mapped to base before returning
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
> ---
>  drivers/usb/host/pci-quirks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index f940056..332f687 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
>                         /* We're reading garbage from the controller */
>                         dev_warn(&pdev->dev,
>                                  "xHCI controller failing to respond");
> -                       return;
> +                       goto iounmap;
>                 }
>
>                 if (!ext_cap_offset)
> @@ -1061,7 +1061,7 @@ hc_init:
>                          "xHCI HW did not halt within %d usec status = 0x%x\n",
>                          XHCI_MAX_HALT_USEC, val);
>         }
> -
> +iounmap:
>         iounmap(base);
>  }
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1279713

On 30.11.2015 08:28, Saurabh Sengar wrote:
> pinging in case this patch is lost.
>
>
> On 6 November 2015 at 17:46, Saurabh Sengar <saurabh.truth@gmail.com> wrote:
>> added iounmap inorder to free memory mapped to base before returning
>>
>> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
>> ---
>>   drivers/usb/host/pci-quirks.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
>> index f940056..332f687 100644
>> --- a/drivers/usb/host/pci-quirks.c
>> +++ b/drivers/usb/host/pci-quirks.c
>> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
>>                          /* We're reading garbage from the controller */
>>                          dev_warn(&pdev->dev,
>>                                   "xHCI controller failing to respond");
>> -                       return;
>> +                       goto iounmap;
>>                  }
>>
>>                  if (!ext_cap_offset)
>> @@ -1061,7 +1061,7 @@ hc_init:
>>                           "xHCI HW did not halt within %d usec status = 0x%x\n",
>>                           XHCI_MAX_HALT_USEC, val);
>>          }
>> -
>> +iounmap:
>>          iounmap(base);
>>   }
>>
>> --
>> 1.9.1
>>

Thanks, I'll add it send it forward soon

-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web