Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1279577 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2015-11-30 07:20 +0100 |
| Last post | 2015-12-08 17:20 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...) Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-30 07:20 +0100
Re: [PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...) Rob Herring <robh+dt@kernel.org> - 2015-12-06 21:50 +0100
Re: [PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...) Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-12-08 17:20 +0100
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2015-11-30 07:20 +0100 |
| Subject | [PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...) |
| Message-ID | <qApYB-8mg-1@gated-at.bofh.it> |
A trivial change suggested by checkpatch.pl.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/of/address.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/address.c b/drivers/of/address.c
index cd53fe4..5289c80 100644
--- a/drivers/of/address.c
+++ b/drivers/of/address.c
@@ -596,7 +596,7 @@ static u64 __of_translate_address(struct device_node *dev,
pbus = of_match_bus(parent);
pbus->count_cells(dev, &pna, &pns);
if (!OF_CHECK_COUNTS(pna, pns)) {
- printk(KERN_ERR "prom_parse: Bad cell count for %s\n",
+ pr_err("prom_parse: Bad cell count for %s\n",
of_node_full_name(dev));
break;
}
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Rob Herring <robh+dt@kernel.org> |
|---|---|
| Date | 2015-12-06 21:50 +0100 |
| Message-ID | <qCOpQ-3ma-9@gated-at.bofh.it> |
| In reply to | #1279577 |
On Mon, Nov 30, 2015 at 12:14 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> A trivial change suggested by checkpatch.pl.
You might as well all levels while you are at it. Looks like that is
only one more:
drivers/of/address.c: printk(KERN_DEBUG "%s", s);
Rob
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/of/address.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index cd53fe4..5289c80 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -596,7 +596,7 @@ static u64 __of_translate_address(struct device_node *dev,
> pbus = of_match_bus(parent);
> pbus->count_cells(dev, &pna, &pns);
> if (!OF_CHECK_COUNTS(pna, pns)) {
> - printk(KERN_ERR "prom_parse: Bad cell count for %s\n",
> + pr_err("prom_parse: Bad cell count for %s\n",
> of_node_full_name(dev));
> break;
> }
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2015-12-08 17:20 +0100 |
| Message-ID | <qDt9D-4CC-7@gated-at.bofh.it> |
| In reply to | #1284911 |
Hi Rob, 2015-12-07 5:40 GMT+09:00 Rob Herring <robh+dt@kernel.org>: > On Mon, Nov 30, 2015 at 12:14 AM, Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: >> A trivial change suggested by checkpatch.pl. > > You might as well all levels while you are at it. Looks like that is > only one more: > > drivers/of/address.c: printk(KERN_DEBUG "%s", s); > OK, I have just posted v2. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web